Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

RFC 6665 says:

Implementations conformant with the current specification MUST treat an incoming 202 response as identical to a 200 response and MUST NOT generate 202 response codes to SUBSCRIBE or NOTIFY requests.

I'm not sure if Kamailio is supposed to conform to the older RFC, so this change might not be acceptable.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2930

Commit Summary

• presence: return 200 instead of 202

File Changes

(1 file)

• M src/modules/presence/subscribe.c (12)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2930.patch
• https://github.com/kamailio/kamailio/pull/2930.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.