@miconda commented on this pull request.


In src/modules/topos/topos_mod.c:

> @@ -490,10 +503,9 @@ int tps_msg_received(sr_event_param_t *evp)
 			}
 		}
 		dialog = (get_to(&msg)->tag_value.len>0)?1:0;
-		if(dialog) {
-			/* dialog request */
-			tps_request_received(&msg, dialog);
-		}
+		
+		tps_request_received(&msg, dialog);
+		

The config has to process the SIP message as it would be without topos (or topoh), otherwise things become more complex to track (accounting, troubleshooting, sipdump, ...). Masking the call id comes with a prefix:

If the prefix is not matched, unmasking is not done, see th_unmask_callid() from topoh.

At the end, even it has to be more complexity added to topos module, it is the way to go, instead of affecting everything else.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3334/review/1270588538@github.com>