@nchaigne commented on this pull request.
In src/modules/http_client/doc/http_client_admin.xml:
> @@ -187,15 +187,35 @@ modparam("http_client", "maxdatasize", 2000) </para> <para> <emphasis> - Default value is zero, i.e., - the timeout function is disabled. + Default value is 4.
I probably should have not changed that in my pull request because it was unrelated to my changes.
The default value for connection_timeout is 4.
But actually it's more complicated than that, and a bit confusing...
If the parameter connection_timeout is explicitly set to 0, then it is changed back to 4 in function mod_init.
However, if "httpcon" are defined, they are initialized when they are parsed, i.e. before "mod_init" is called. Hence, for these connections the timeout is 0, which means "no timeout".
But for HTTP requests performed without a named connection, the timeout will be 4...
In all cases, the default is 4, not 0.
The documentation should probably better explain all this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.