Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #3350

Description

This PR fixes a crash when dns_cache_init=off.

The issue is described in #3350 and the crash is caused when trying to search in dns_cache.c LOCK_DNS_HASH();.

When dns_cache_init=off, the lock is never initialized and when trying to lock it crashes.

Per my understanding, when dns_cache_init=off, no calls to dns_cache.c should be made and instead call the alternative ones from resolve.c, since the whole functions are compiled only when USE_DNS_CACHE definition is present.

Just a question to clarify, what is the reasoning behind USE_DNS_CACHE definition and a separate dns_cache_init parameter?

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3858

Commit Summary

93801ed core/resolve: Check dns_cache_init and choose appropriate functions

File Changes

(1 file)

M src/core/resolve.c (16)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.