@vingarzan commented on this pull request.


In src/modules/ims_registrar_scscf/registrar_notify.c:

>  		tmb.t_request_within(&uac_r);
 	}
-	if(h.s)
-		pkg_free(h.s);
-	if(content.s) {
-		pkg_free(content.s);
+	watcher_contact = 0;

Shouldn't - both branches of the if before have the watcher_contact saved on the transaction. I think that freeing would result in a double-free, so instead we leave it for the uac_request_cb to clean up after the response or timeout is reached.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3895/review/2151196255@github.com>