Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

we have a use case where we need to drop the request within a transaction, and that is not possible because tm module will always send the final reply.

route[MYREQ]
{
    ## protect from retrans
    if (!t_newtran()) {
        xlog("L_ERROR", "$ci|log|failed to create transaction\n");
        drop;
    }

    if(some early business use case that requires drop) {
        xlog("L_INFO", "$ci|log|dropping request\n");
        t_drop();
    }

    async_func_that_suspends_and_continues("$anyparam", "TR_OK", "TR_ERROR");

}

failure_route[TR_ERROR]
{
    xlog("L_INFO", "$ci|log|failed $T_reply_code $T_reply_reason\n");
    t_drop();
}

onreply_route[TR_OK]
{
    xlog("L_INFO", "$ci|log|checking transaction result\n");
   if(some business use case that requires dropping the request) {
      t_drop();
   }
...
}

if we use drop instead of t_drop , we always get a final reply sent to the requestor

not sure if this is the right approach to the problem but at least fixes for us and can start the discussion.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1726

Commit Summary

• tmx: add t_drop

File Changes

• M src/modules/tmx/tmx_mod.c (22)

Patch Links:

• https://github.com/kamailio/kamailio/pull/1726.patch
• https://github.com/kamailio/kamailio/pull/1726.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.