… or reloading the list

Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

When a destination is added/removed or the whole list is reloaded, the calls that are being routed to another destination will fail.
This because ds_load_replace is returning an error not finding in the table the entry for the call being rerouted.
Another side effect of this is that when adding/removing destinations the actual load of the endpoints will be wrong since the current calls will never be deleted.
I've removed the calls to ds_clean_slots and modified ds_load_replace to not exit when the old destination is not found (the endpoint could have been removed after the failover list had been created) and to return a new error code (-2) when the new destination is not found (for the same reason).
Finally I've modified ds_update_dst to skip the current selected destination and select the next if ds_load_replace returns -2.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/2342

Commit Summary

dispatcher: don't reset load table when adding/removing a destination or reloading the list

File Changes

M src/modules/dispatcher/dispatch.c (37)

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.