@vingarzan commented on this pull request.


In src/modules/ims_isc/mark.c:

> +	str found = {0, 0};
+
+	LM_DBG("isc_mark_get_from_lumps: Trying to get the mark from the add_rm "
+		   "lumps \n");
+
+	memset(mark, 0, sizeof(isc_mark));
+
+	parse_headers(msg, HDR_EOH_F, 0);
+
+	anchor_lump(msg, msg->headers->name.s - msg->buf, 0, 0);
+
+	lmp = msg->add_rm;
+	while(lmp) {
+		tmp = lmp->before;
+		if(tmp && tmp->op == LUMP_ADD && tmp->u.value
+				&& (found.s = strstr(tmp->u.value, ISC_MARK_USERNAME))) {

These things are null-terminated, I hope.

(I never liked lumps...)


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4018/review/2501910979@github.com>