Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@miconda thanks for looking into this! Indeed it seems that structured logging takes care of most of our needs. But I'm not sure whether it would allow us to do uniform logging from config files. Let me explain: right now we're using custom log function from the PR and we're "manually" resolving $cfg(file)/$cfg(line) PVEs and feeding them into the log handler. I haven't seen such functionality in dprint.c/.h nor there seems to exist a version of LOG_XX macro that would allow to inject that data.
I suppose we could completely bypass LOG_XX macros and call the _ksr_slog_func function manually by passing it manually constructed ksr_logdata_t structure, although that could lead to some hard to catch bugs if the logger type is ever changed. How feasible is it to create another version of LOG_XX (for example LOG_SD, short for "source data") that takes source file and line number as arguments?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.