Fixes GH #3178. Sets TCP connection id for keepalive based on the value in the database
If unset, tcpconn_id will remain 0 and keepalives will work the same as they do today
Update documentation to clarify when it will use received vs AOR for keepalive

Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #3178 (replace XXXX with an open issue number)

Description

Updated usrloc module to re-use an active TCP session (if it exists). I marked this breaking only because the current code will use a UDP OPTIONS keepalive method even if the device is registered over TCP. I doubt that's what anyone would be expecting so I think the change is ok.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3219

Commit Summary

bb1e3ef usrloc: re-use TCP connections for keepalive

File Changes

(3 files)

M src/modules/usrloc/dlist.c (4)
M src/modules/usrloc/doc/usrloc_admin.xml (9)
M src/modules/usrloc/ul_keepalive.c (4)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.