Thanks for the PR, good addition. Out of curiosity, which modules do you anticipate will use the rtpengine API?

I want to implement siprec module and I need some of rtpengine module functionalities.

Regarding the PR, please fix the clang format checks by running clang-format on your files. I have also one question about the rtpengine_load_api(..) function, it should be placed in the module actually using the rtpengine API, and not in the module exporting the API, right?

As in:
https://github.com/kamailio/kamailio/blob/f5f7c913d4f008b9937677ae2c2d66baa01dcf0e/src/modules/sanity/api.h#L44
sanity_load_api function is defined in sanity module and is called in modules using the apis.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3948/c2294830125@github.com>