Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

loose_route() in rr checks request src ip/port against ip/port in flow tokens to detect direction and decide whether to apply flow tokens routing:

static inline int process_outbound(struct sip_msg *_m, str flow_token)
{
...
	} else if(!ip_addr_cmp(&rcv->src_ip, &_m->rcv.src_ip)
			  || rcv->src_port != _m->rcv.src_port) {
		LM_DBG("\"incoming\" request found. Using flow-token for "
			   "routing\n");
...

there are cases when remote UA changes ip/port for in-dialog messages and this approach does not work.
incoming message has route set with flow tokens and src ip/port different from ones in the flow tokens.
as a result, loose_route() routes message back to the client using flow tokens instead of using the normal part of the Route headers as expected.

new force_lr_no_outbound_flag allows to control flow tokens usage in the loose_route() when we know direction based on the some high level config logic (for example: by the result of ds_is_from_list() call)

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/4280

Commit Summary

6c42be3 rr: add force_lr_no_outbound_flag param

File Changes

(3 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.