Credits and reference to issues or PRs have to be done in the description content of the commit message, not in the first line, as per contributing guidelines.
Also, as I could see if I haven't missed something, in this case the PR was proposing exactly the same change, with proper commit message, so it could have just been merged directly, not doing a separate commit and reference the PR.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.