@henningw commented on this pull request.

Thanks for the PR. I have reviewed and added only one comment, where I was not sure if it was an intentional change. The CHAR to VARCHAR conversion is fine, I think - we are using VARCHAR everywhere usually.

In utils/kamctl/mysql/ims_usrloc_pcscf-create.sql:

> +    `protocol` INT(10) DEFAULT NULL,
+    `mode` VARCHAR(10) DEFAULT NULL,
+    `ck` VARCHAR(100) DEFAULT NULL,
+    `ik` VARCHAR(100) DEFAULT NULL,
+    `ealg` VARCHAR(20) DEFAULT NULL,
+    `ialg` VARCHAR(20) DEFAULT NULL,
+    `port_pc` INT(11) UNSIGNED DEFAULT NULL,
+    `port_ps` INT(11) UNSIGNED DEFAULT NULL,
+    `port_uc` INT(11) UNSIGNED DEFAULT NULL,
+    `port_us` INT(11) UNSIGNED DEFAULT NULL,
+    `spi_pc` INT(11) UNSIGNED DEFAULT NULL,
+    `spi_ps` INT(11) UNSIGNED DEFAULT NULL,
+    `spi_uc` INT(11) UNSIGNED DEFAULT NULL,
+    `spi_us` INT(11) UNSIGNED DEFAULT NULL,
+    `t_security_type` INT(11) DEFAULT NULL,
+    `t_protocol` INT(10) DEFAULT NULL,

This was char(5) before, maybe we want to convert to VARCHAR instead of INT?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4108/review/2555603169@github.com>