This has to be made parameter. Also, the expires for trying and early
state has to be configurable -- there was a discussions on sr-users
during past days ending up in such conclusion, but I didn't have time to
pursue yet.

And I think there is another thing to care of -- once terminated state
is published, the confirmed state document must be deleted. No time
either to analyze the code and decide how to do it. Because if
terminated state record is deleted, then the confirmed state remains
alone and the lines would appear busy to watchers.

Cheers,
Daniel

On 11/02/15 21:32, Ovidiu Sas wrote:
> Module: kamailio
> Branch: master
> Commit: dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5
> URL: https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5
>
> Author: Ovidiu Sas <osas@voipembedded.com>
> Committer: Ovidiu Sas <osas@voipembedded.com>
> Date: 2015-02-11T15:30:42-05:00
>
> pua_dialoginfo: set expiration timeout to 10s for dialogs in terminated state
>  - this will avoid accumulation of expired dialogs
>
> ---
>
> Modified: modules/pua_dialoginfo/pua_dialoginfo.c
>
> ---
>
> Diff:  https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5.diff
> Patch: https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5.patch
>
> ---
>
> diff --git a/modules/pua_dialoginfo/pua_dialoginfo.c b/modules/pua_dialoginfo/pua_dialoginfo.c
> index 7bed1998..de53e0f 100644
> --- a/modules/pua_dialoginfo/pua_dialoginfo.c
> +++ b/modules/pua_dialoginfo/pua_dialoginfo.c
> @@ -269,11 +269,11 @@ __dialog_sendpublish(struct dlg_cell *dlg, int type, struct dlg_cb_params *_para
>                                       dlginfo->from_uri.s);
>                       dialog_publish_multi("terminated", dlginfo->pubruris_caller,
>                                       &(dlginfo->from_uri), &uri, &(dlginfo->callid), 1,
> -                                     dlginfo->lifetime, 0, 0, &(dlginfo->from_contact),
> +                                     10, 0, 0, &(dlginfo->from_contact),
>                                       &target, send_publish_flag==-1?1:0);
>                       dialog_publish_multi("terminated", dlginfo->pubruris_callee,
>                                       &uri, &(dlginfo->from_uri), &(dlginfo->callid), 0,
> -                                     dlginfo->lifetime, 0, 0, &target, &(dlginfo->from_contact),
> +                                     10, 0, 0, &target, &(dlginfo->from_contact),
>                                       send_publish_flag==-1?1:0);
>                       break;
>               case DLGCB_CONFIRMED:
> @@ -364,11 +364,11 @@ __dialog_sendpublish(struct dlg_cell *dlg, int type, struct dlg_cb_params *_para
>                                       type, dlginfo->from_uri.len, dlginfo->from_uri.s);
>                       dialog_publish_multi("terminated", dlginfo->pubruris_caller,
>                                       &(dlginfo->from_uri), &uri, &(dlginfo->callid), 1,
> -                                     dlginfo->lifetime, 0, 0, &(dlginfo->from_contact), &target,
> +                                     10, 0, 0, &(dlginfo->from_contact), &target,
>                                       send_publish_flag==-1?1:0);
>                       dialog_publish_multi("terminated", dlginfo->pubruris_callee, &uri,
>                                       &(dlginfo->from_uri), &(dlginfo->callid), 0,
> -                                     dlginfo->lifetime, 0, 0, &target, &(dlginfo->from_contact),
> +                                     10, 0, 0, &target, &(dlginfo->from_contact),
>                                       send_publish_flag==-1?1:0);
>
>       }
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev@lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com

_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev