Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@xkaraman commented on this pull request.
In src/modules/ipops/ipops_mod.c:
> +/**
+ *
+ */
+static int w_ptr_query(sip_msg_t *msg, char *ip, char *pv_name)
+{
+ str ip_address;
+ str name;
+
+ if(msg == NULL) {
+ LM_ERR("received null msg\n");
+ return -1;
+ }
+
+ if(fixup_get_svalue(msg, (gparam_t *)ip, &ip_address) < 0) {
+ LM_ERR("cannot get the IP address\n");
+ return -1;
Main reason i see for separating errors is for debugging purposes.
Another thing, that might be good, would be to separate the failure over bad input and successful call with no hostname associated (getnameinfo). Do you think this makes sense to separate and document it?
Other than that, as you have said the code just want to know it had failed and not how.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.