The POSIX sh(1) specification says that strings are compared with
test(1) (also "[") with "=". Bash accepts "==" and this leads to
non-portable code. This commit simply changes "==" within test/[ to
"=".

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• [] PR should be backported to stable branches
• Tested changes locally
• Related to issue #2157

Description

This changes instances of "==" as a an operator to test(1) to "=".
I have not yes tested running the script, because I am still working through issues to package kamailio in pkgsrc. However, this patch avoids a lint-type warning from pkgsrc about non-portable shell script constructs.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2159

Commit Summary

• utils: Change sh(1) "test ==" usage to "="

File Changes

• M utils/kamctl/kamdbctl (10)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2159.patch
• https://github.com/kamailio/kamailio/pull/2159.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.