@xkaraman commented on this pull request.


In src/modules/rtpengine/rtpengine.c:

> @@ -3549,6 +3606,10 @@ static int rtpp_test(struct rtpp_node *node, int isdisabled, int force)
 		return 1;
 	}
 	if(force == 0) {
+		/* If ping_interval is set, the timer will ping and test
+		the rtps. No need to do something during routing */
+		if(rtpengine_ping_interval > 0)
+			return 1;

Well, i don't really see any problems no. Adding the interval check in force==0 block can work as expected probably.

What I suggested was just a thought, that might have simplified how all these are handled and more logically structured.

I will update it accordingly.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4016/review/2430148860@github.com>