@agranig commented on this pull request.


In src/modules/mqtt/doc/mqtt_admin.xml:

> @@ -324,6 +324,27 @@ modparam("mqtt", "ca_path", "/etc/ssl/certs")
 		<programlisting format="linespecific">
 ...
 modparam("mqtt", "tls_method", "tlsv1.3")
+...
+		</programlisting>
+		</example>
+	</section>
+	<section id="mqtt.p.tls_alpn">
+		<title><varname>tls_alpn</varname> (str)</title>
+		<para>
+        Used to set the TLS ALPN option for cases where one TLS port is used to share multiple services. Prominent
+        example is AWS IoT, where you have to set the <varname>tls_alpn</varname> to "mqtt" to be able to connect
+        via MQTT.
+		</para>
+		<para>
+		<emphasis>
+			Default value is NULL, where no ALPN is set on the TLS connection.

Is there actually good practice on how to document a param which has no default value (aka is NULL)? I'm finding quite some old modules having it documented like this, see https://www.kamailio.org/docs/modules/devel/modules/auth_db.html#auth_db.p.load_credentials for example.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3261/review/1140196789@github.com>