sure . Its long back pull request. i need to check whether those comments<br>
incorporated or not.<br>
<br>
On Sat, May 5, 2018 at 1:07 PM, Daniel-Constantin Mierla &lt;<br>
notifications@github.com&gt; wrote:<br>
<br>
&gt; There was a discussion on mailing lists (sr-dev and sr-users) started in<br>
&gt; February with the subject &quot;RFC: db_redisusrloc module - review and how to<br>
&gt; deal with&quot; - can you follow up on that thread, some people had comments and<br>
&gt; it is better that you express your point of view.<br>
&gt;<br>
&gt; I haven&#39;t checked yet, but there were some comments/reviews on code for<br>
&gt; initial PR #1422 &lt;https://github.com/kamailio/kamailio/pull/1422&gt;, have<br>
&gt; you dealt with them in this PR?<br>
&gt;<br>
&gt; —<br>
&gt; You are receiving this because you commented.<br>
&gt; Reply to this email directly, view it on GitHub<br>
&gt; &lt;https://github.com/kamailio/kamailio/pull/1446#issuecomment-386786987&gt;,<br>
&gt; or mute the thread<br>
&gt; &lt;https://github.com/notifications/unsubscribe-auth/AGb9UQObnq5JAKSibvEUuUEj7t9ivmohks5tvVaqgaJpZM4SJS1k&gt;<br>
&gt; .<br>
&gt;<br>
<br>
<br>
<br>
-- <br>
With Regards,<br>
Surendra Tiwari<br>
VoIP Application Developer,<br>
Plivo Comm<br>
+91-9967609476<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1446#issuecomment-386787235">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZSKDHlChrcLNKhM8Wjc4WCvC8zdeks5tvVergaJpZM4SJS1k">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZUj2Mv5v89FtyRo5YXS0a5qs9dKlks5tvVergaJpZM4SJS1k.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1446#issuecomment-386787235"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@surendratiwari3 in #1446: sure . Its long back pull request. i need to check whether those comments\nincorporated or not.\n\nOn Sat, May 5, 2018 at 1:07 PM, Daniel-Constantin Mierla \u003c\nnotifications@github.com\u003e wrote:\n\n\u003e There was a discussion on mailing lists (sr-dev and sr-users) started in\n\u003e February with the subject \"RFC: db_redisusrloc module - review and how to\n\u003e deal with\" - can you follow up on that thread, some people had comments and\n\u003e it is better that you express your point of view.\n\u003e\n\u003e I haven't checked yet, but there were some comments/reviews on code for\n\u003e initial PR #1422 \u003chttps://github.com/kamailio/kamailio/pull/1422\u003e, have\n\u003e you dealt with them in this PR?\n\u003e\n\u003e —\n\u003e You are receiving this because you commented.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/kamailio/kamailio/pull/1446#issuecomment-386786987\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/AGb9UQObnq5JAKSibvEUuUEj7t9ivmohks5tvVaqgaJpZM4SJS1k\u003e\n\u003e .\n\u003e\n\n\n\n-- \nWith Regards,\nSurendra Tiwari\nVoIP Application Developer,\nPlivo Comm\n+91-9967609476\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1446#issuecomment-386787235"}}}</script>