Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

Currently we need a onsend_route{} (empty is ok) block in config before KEMI ksr_onsend_route() is invoked. The latter will override the route block.

This PR will unconditonally invoke KEMI ksr_onsend_route() so we do not need a placeholder in config.

For discussion: this will unconditionally invoke ksr_onsend_route() so it might break scripts that don't have an implementation. Should be document that ksr_onsend_route should be implemented (just return 1 is ok).

I'm not too clear about the error handling in run_onsend(): it's possible that if KEMI ksr_onsend_route throws error (not implemented rather than real error) then the message might be dropped.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1475

Commit Summary

• core: invoke KEMI ksr_onsend_route()

File Changes

• M src/core/onsend.h (7)

Patch Links:

• https://github.com/kamailio/kamailio/pull/1475.patch
• https://github.com/kamailio/kamailio/pull/1475.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.