xkaraman left a comment (kamailio/kamailio#4192)

As i said before:

i am not sure but i think the PR action check was not honored before. i can see in the config file that dangle_parens = True was set already but the PR checks didn't fail on older PRs. (I am quite sure there were a cmake PRs before this change with the wrong format).

EDIT: I just saw you made some changes last week regarding the cmake-format with some script. i was not referring to this but to the older way of checking, just to be clear. Hope your new way with script it does take into account the config file.

I think this is the first PR regarding CMake after you have introduced the scripts. Before it was done directly (I guess?) but it seemed that it was not honoring the config file (realised this due to config already have the dangle_parens = True but the format in files was not like that) .

The script check now seems to pass, but let me push a wrongly formatted file to verify it.

Cheers,
Xenofon

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.