set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call

Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

Using kamailio 5.4 version, we have seen that dlg_isflagset is not detecting a dialog flag set in the request route for the initial INVITE, when a CANCEL request arrives.

We have applied this change to set the dialog context unique ide for this request. Since it's done on dlg_onreply, dlg_onroute and dlg_ontimeout functions. This way, dlg_get_by_iuid(&dctx->iuid) in the function ki_dlg_isflagset is not NULL and dialog flags are detected.

Is this change correct? Or can it generate any kind of issues?

thanks a lot and regards
David

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3096

Commit Summary

53778ca dialog: set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call

File Changes

(1 file)

M src/modules/dialog/dlg_handlers.c (3)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.