sr-dev

sr-dev@lists.kamailio.org

16 participants
45365 discussions

[kamailio/kamailio] ims_ipsec_pcscf: fill_contact() build AOR from VIA as fallback on SIP_REPLY (PR #4335)
by Victor Seva 22 Jul '25

22 Jul '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally #### Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4335 -- Commit Summary -- * ims_ipsec_pcscf: fill_contact() build AOR from VIA as fallback on SIP_REPLY -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (39) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4335.patch https://github.com/kamailio/kamailio/pull/4335.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4335 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4335(a)github.com>

1 0

git:master:c6cee2a0: ims_ipsec_pcscf: fill_contact() don't leak on error
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: master Commit: c6cee2a0c2acf5174c610b610ed827a5d888c7cc URL: https://github.com/kamailio/kamailio/commit/c6cee2a0c2acf5174c610b610ed827a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T16:40:27+02:00 ims_ipsec_pcscf: fill_contact() don't leak on error --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/c6cee2a0c2acf5174c610b610ed827a… Patch: https://github.com/kamailio/kamailio/commit/c6cee2a0c2acf5174c610b610ed827a… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 4672a45906a..4271e9c519d 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -344,10 +344,9 @@ static int fill_contact( } free_sip_msg(&tmsg); - vb = cscf_get_ue_via(m); - if(!vb) { + if((vb = cscf_get_ue_via(m)) == NULL) { LM_ERR("Reply No via body headers\n"); - return -1; + goto error; } // populate CI with bare minimum @@ -357,8 +356,8 @@ static int fill_contact( ci->searchflag = SEARCH_RECEIVED; if((srcip = pkg_malloc(50)) == NULL) { - LM_ERR("Error allocating memory for source IP address\n"); - return -1; + PKG_MEM_ERROR; + goto error; } ci->received_host.len =

1 0

git:master:11199330: ims_qos: rx_avp add AVP_EPC_Min_Requested_Bandwidth_[UD]L non-mandatory AVPs
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: master Commit: 11199330436341768ff3277302b204e02eda6530 URL: https://github.com/kamailio/kamailio/commit/11199330436341768ff3277302b204e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T15:56:02+02:00 ims_qos: rx_avp add AVP_EPC_Min_Requested_Bandwidth_[UD]L non-mandatory AVPs --- Modified: src/modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/11199330436341768ff3277302b204e… Patch: https://github.com/kamailio/kamailio/commit/11199330436341768ff3277302b204e… --- diff --git a/src/modules/ims_qos/rx_avp.c b/src/modules/ims_qos/rx_avp.c index 4fb750d2f6f..6270e7a9b3d 100644 --- a/src/modules/ims_qos/rx_avp.c +++ b/src/modules/ims_qos/rx_avp.c @@ -385,7 +385,9 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, AAA_AVP *codec_data1, *codec_data2; AAA_AVP *media_sub_component[PCC_Media_Sub_Components]; AAA_AVP *flow_status; - AAA_AVP *dl_bw, *ul_bw, *rs_bw, *rr_bw; + AAA_AVP *dl_max_bw, *ul_max_bw; + AAA_AVP *dl_min_bw, *ul_min_bw; + AAA_AVP *rs_bw, *rr_bw; int media_sub_component_number = 0; unsigned int bandwidth = 0; @@ -471,10 +473,15 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, // Add AVP set_4bytes(x, bandwidth); - ul_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_UL, + ul_max_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_UL, AAA_AVP_FLAG_MANDATORY | AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, AVP_DUPLICATE_DATA); - cdpb.AAAAddAVPToList(&list, ul_bw); + cdpb.AAAAddAVPToList(&list, ul_max_bw); + + ul_min_bw = cdpb.AAACreateAVP(AVP_EPC_Min_Requested_Bandwidth_UL, + AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, + AVP_DUPLICATE_DATA); + cdpb.AAAAddAVPToList(&list, ul_min_bw); // Get bandwidth from SDP: bandwidth = sdp_b_value(rpl_raw_payload, "AS"); @@ -490,10 +497,15 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, // Add AVP set_4bytes(x, bandwidth); - dl_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_DL, + dl_max_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_DL, AAA_AVP_FLAG_MANDATORY | AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, AVP_DUPLICATE_DATA); - cdpb.AAAAddAVPToList(&list, dl_bw); + cdpb.AAAAddAVPToList(&list, dl_max_bw); + + dl_min_bw = cdpb.AAACreateAVP(AVP_EPC_Min_Requested_Bandwidth_DL, + AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, + AVP_DUPLICATE_DATA); + cdpb.AAAAddAVPToList(&list, dl_min_bw); // Get A=RS-bandwidth from SDP-Reply: bandwidth = sdp_b_value(rpl_raw_payload, "RS");

1 0

git:master:7edec9ec: cdp: added support for Min-Requested-Bandwidth-[DU]L AVPs
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: master Commit: 7edec9ec8420f9239134f408e6c829e299b4d213 URL: https://github.com/kamailio/kamailio/commit/7edec9ec8420f9239134f408e6c829e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T15:17:03+02:00 cdp: added support for Min-Requested-Bandwidth-[DU]L AVPs From 3GPP TS 29.214 version 10.6.0 Release 10: > 5.3.31 Min-Requested-Bandwidth-DL AVP > The Min-Requested-Bandwidth-DL AVP (AVP code 534) is of type Unsigned32, and it indicates the minimum > requested bandwidth in bits per second for a downlink IP flow. The bandwidth contains all the overhead coming from > the IP-layer and the layers above, e.g. IP, TCP, UDP, HTTP, RTP and RTP payload. > When provided in an AA-Request, it indicates the minimum requested bandwidth. > > 5.3.32 Min-Requested-Bandwidth-UL AVP > The Min-Requested-Bandwidth-UL AVP (AVP code 535) is of type Unsigned32, and it indicates the minimum > requested bandwidth in bits per second for an uplink IP flow. The bandwidth contains all the overhead coming from the > IP-layer and the layers above, e.g. IP, TCP, UDP, HTTP, RTP and RTP payload. > When provided in an AA-Request, it indicates the minimum requested bandwidth. --- Modified: src/modules/cdp/diameter_epc_code_avp.h --- Diff: https://github.com/kamailio/kamailio/commit/7edec9ec8420f9239134f408e6c829e… Patch: https://github.com/kamailio/kamailio/commit/7edec9ec8420f9239134f408e6c829e… --- diff --git a/src/modules/cdp/diameter_epc_code_avp.h b/src/modules/cdp/diameter_epc_code_avp.h index 186b75fe678..7c294bf21d1 100644 --- a/src/modules/cdp/diameter_epc_code_avp.h +++ b/src/modules/cdp/diameter_epc_code_avp.h @@ -112,6 +112,8 @@ enum AVP_EPC_Service_URN = 525, AVP_EPC_Acceptable_Service_Info = 526, AVP_EPC_Service_Info_Status = 527, + AVP_EPC_Min_Requested_Bandwidth_DL = 534, + AVP_EPC_Min_Requested_Bandwidth_UL = 535, /** 600 to 699 reserved for TS29.229 */ /** 700 to 799 reserved for TS29.329 */

1 0

[kamailio/kamailio] cmake: build on ppc64le arch (Issue #4333)
by sergey-safarov 22 Jul '25

22 Jul '25

sergey-safarov created an issue (kamailio/kamailio#4333) ### Description I want to compile Kamailio sources on `ppc64le` arch. During compilation, I see an error ```sh [ 0%] Building C object src/CMakeFiles/kamailio.dir/main.c.o In file included from /tmp/kamailio/src/core/parser/../mem/../lock_ops.h:92, from /tmp/kamailio/src/core/parser/../mem/shm.h:44, from /tmp/kamailio/src/core/parser/../mem/shm_mem.h:32, from /tmp/kamailio/src/core/parser/../ut.h:46, from /tmp/kamailio/src/core/parser/../ip_addr.h:41, from /tmp/kamailio/src/core/parser/msg_parser.h:39, from /tmp/kamailio/src/core/select.h:36, from /tmp/kamailio/src/core/route_struct.h:35, from /tmp/kamailio/src/core/route.h:39, from /tmp/kamailio/src/main.c:79: /tmp/kamailio/src/core/parser/../mem/../fastlock.h:130:2: error: #error "unknown architecture" 130 | #error "unknown architecture" | ^~~~~ /tmp/kamailio/src/core/parser/../mem/../fastlock.h: In function ‘tsl’: /tmp/kamailio/src/core/parser/../mem/../fastlock.h:294:2: error: #error "unknown architecture" 294 | #error "unknown architecture" | ^~~~~ /tmp/kamailio/src/core/parser/../mem/../fastlock.h: In function ‘get_lock’: /tmp/kamailio/src/core/parser/../mem/../fastlock.h:317:9: error: implicit declaration of function ‘membar_getlock’ [-Wimplicit-function-declaration] 317 | membar_getlock(); | ^~~~~~~~~~~~~~ /tmp/kamailio/src/core/parser/../mem/../fastlock.h: In function ‘release_lock’: /tmp/kamailio/src/core/parser/../mem/../fastlock.h:436:2: error: #error "unknown architecture" 436 | #error "unknown architecture" | ^~~~~ In file included from /tmp/kamailio/src/core/atomic_ops.h:180, from /tmp/kamailio/src/core/locking.h:74, from /tmp/kamailio/src/core/rpc.h:36, from /tmp/kamailio/src/core/sr_module.h:38, from /tmp/kamailio/src/main.c:85: /tmp/kamailio/src/core/atomic/atomic_unknown.h: At top level: /tmp/kamailio/src/core/atomic/atomic_unknown.h:53:2: warning: #warning no native memory barrier implementations, falling back to slow lock based workaround [-Wcpp] 53 | #warning no native memory barrier implementations, falling back to slow lock \ | ^~~~~~~ gmake[2]: *** [src/CMakeFiles/kamailio.dir/build.make:76: src/CMakeFiles/kamailio.dir/main.c.o] Error 1 gmake[1]: *** [CMakeFiles/Makefile2:3359: src/CMakeFiles/kamailio.dir/all] Error 2 gmake: *** [Makefile:156: all] Error 2 ``` ### Expected behavior Sources compiled without error messages. #### Actual observed behavior Build failed be error described above. ### Reproduction ```sh git clone https://github.com/kamailio/kamailio.git docker run -it \ --platform linux/ppc64le \ -v ./kamailio:/usr/src/kamailio \ ghcr.io/sergey-safarov/kamailio-builder:centos-10 cd /usr/src/kamailio cmake -S . -B build cmake --build build ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4333 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4333(a)github.com>

2 9

[kamailio/kamailio] dialog: docs: Remove dlg_flag related mentions (PR #4334)
by Xenofon Karamanos 22 Jul '25

22 Jul '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4321 #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4334 -- Commit Summary -- * dialog: docs: Remove dlg_flag related mentions -- File Changes -- M src/modules/dialog/doc/dialog_admin.xml (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4334.patch https://github.com/kamailio/kamailio/pull/4334.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4334 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4334(a)github.com>

2 1

[kamailio/kamailio] cmake glitches (Issue #4317)
by Дилян Палаузов 22 Jul '25

22 Jul '25

dilyanpalauzov created an issue (kamailio/kamailio#4317) In the 6.0 branch the FLAVOUR option allows in cmake-gui (ccmake) setting `kamailio` as only option. As it is no-op, it should not be displayed in cmake-gui. The option MODULE_GROUP_NAME is documented as „Group of modules to build (one or multiple space seperated group)“. In cmake-gui it allows with enter to toggle between several values: DEFAULT, STANDARD, COMMON, KSTANDARD, KMINI, KPCRE, KMYSQL, KPOSTGRES, …. Using ccmake it is not possible to to set multiple values. The help string should mention all possible values. It should be plural: groups. The options in ccmake-gui `XSLT_VALIDATE,` and `XSLT_VERBOSE,` have a comma in their names too much. The option `CMAKE_BUILD_TYPE` allows in Kamailio toggling between four possible values: Debug, Release, MinSizeRel and RelWithDebInfo. ClamAV adds one more value for cmake-gui: `None`. This toggling is not yet available in the build system of cmake (when building cmake using cmake) - https://gitlab.kitware.com/cmake/cmake/-/issues/26434 . Is it reasonable to have for CMAKE_BUILD_TYPE also `None` as permitted value? I do not know the answer, that is why I am raising this question. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4317 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4317(a)github.com>

2 5

git:master:5ac0428c: ims_registrar_scscf: clang-format
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: master Commit: 5ac0428c2228bc8be70104fe8ff14fd1ac9724cb URL: https://github.com/kamailio/kamailio/commit/5ac0428c2228bc8be70104fe8ff14fd… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T12:39:02+02:00 ims_registrar_scscf: clang-format --- Modified: src/modules/ims_registrar_scscf/config.c Modified: src/modules/ims_registrar_scscf/cxdx_avp.h Modified: src/modules/ims_registrar_scscf/cxdx_sar.c Modified: src/modules/ims_registrar_scscf/registrar_notify.c Modified: src/modules/ims_registrar_scscf/save.c Modified: src/modules/ims_registrar_scscf/userdata_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/5ac0428c2228bc8be70104fe8ff14fd… Patch: https://github.com/kamailio/kamailio/commit/5ac0428c2228bc8be70104fe8ff14fd…

1 0

git:master:25a5ab9f: pre-commit: update hook [skip ci]
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: master Commit: 25a5ab9f66b23e1cf293d9e3037320ebba79f21e URL: https://github.com/kamailio/kamailio/commit/25a5ab9f66b23e1cf293d9e3037320e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T12:37:10+02:00 pre-commit: update hook [skip ci] --- Modified: .pre-commit-config.yaml --- Diff: https://github.com/kamailio/kamailio/commit/25a5ab9f66b23e1cf293d9e3037320e… Patch: https://github.com/kamailio/kamailio/commit/25a5ab9f66b23e1cf293d9e3037320e… --- diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f84473cb199..caa7f5c64c7 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -9,9 +9,11 @@ repos: - id: check-merge-conflict - id: mixed-line-ending - repo: https://github.com/pre-commit/mirrors-clang-format - rev: v15.0.7 + rev: v20.1.8 hooks: - id: clang-format + args: + - --style=file:.clang-format - repo: https://github.com/cheshirekow/cmake-format-precommit rev: v0.6.13 hooks:

1 0

git:5.8:a747d3bb: ims_icscf: cxdx_send_lir() return error on fail send message
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: 5.8 Commit: a747d3bb1f23d0032b30898380d4b5761b0f1ea0 URL: https://github.com/kamailio/kamailio/commit/a747d3bb1f23d0032b30898380d4b57… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T11:20:26+02:00 ims_icscf: cxdx_send_lir() return error on fail send message (cherry picked from commit 73119407a0999ca32eed75e56e412f3087a37800) (cherry picked from commit 5993ec85431f5d23dcc2aac12a5e98eb6f7de989) --- Modified: src/modules/ims_icscf/cxdx_lir.c --- Diff: https://github.com/kamailio/kamailio/commit/a747d3bb1f23d0032b30898380d4b57… Patch: https://github.com/kamailio/kamailio/commit/a747d3bb1f23d0032b30898380d4b57… --- diff --git a/src/modules/ims_icscf/cxdx_lir.c b/src/modules/ims_icscf/cxdx_lir.c index e72510fd3db..b6f6f56f28a 100644 --- a/src/modules/ims_icscf/cxdx_lir.c +++ b/src/modules/ims_icscf/cxdx_lir.c @@ -263,6 +263,7 @@ int cxdx_send_lir(struct sip_msg *msg, str public_identity, AAAMessage *lir = 0; AAASession *session = 0; + int ret = -1; session = cdpb.AAACreateSession(0); @@ -285,12 +286,16 @@ int cxdx_send_lir(struct sip_msg *msg, str public_identity, goto error1; if(cxdx_forced_peer.len) - cdpb.AAASendMessageToPeer(lir, &cxdx_forced_peer, + ret = cdpb.AAASendMessageToPeer(lir, &cxdx_forced_peer, (void *)async_cdp_lir_callback, (void *)transaction_data); else - cdpb.AAASendMessage( + ret = cdpb.AAASendMessage( lir, (void *)async_cdp_lir_callback, (void *)transaction_data); + if(ret != 1) { + LM_DBG("Error sending async diameter (%d)\n", ret); + return -1; + } LM_DBG("Successfully sent async diameter\n"); return 0;

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev