From notifications@github.com Tue Jul 20 16:19:13 2021
From: Norbixin <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] [kamailio/kamailio] Wrong return code used by
 sl_reply_error() (#2802)
Date: Tue, 20 Jul 2021 07:19:10 -0700
Message-ID: <kamailio/kamailio/issues/2802@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2050671008=="

--===============2050671008==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requ=
ests. Please use this template only for bug reports.

If you have questions about using Kamailio or related to its configuration fi=
le, ask on sr-users mailing list:

  * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

If you have questions about developing extensions to Kamailio or its existing=
 C code, ask on sr-dev mailing list:

  * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Please try to fill this template as much as possible for any issue. It helps =
the developers to troubleshoot the issue.

If there is no content to be filled in a section, the entire section can be r=
emoved.

You can delete the comments from the template sections when filling.

You can delete next line and everything above before submitting (it is a comm=
ent).
-->

### Description

I wanted to change 478 response to 503 in case of t_relay() failure, but leav=
e default behavior in rest error cases. I used part of code from "Example 1.1=
." inside https://www.kamailio.org/docs/modules/devel/modules/outbound.html. =
When I get -478 from t_relay() it works fine, but when this code is different=
 sl_reply_erorr() don't use it as it should be.=20

This is my part of kamailio.cfg:
```
route[RELAY] {
    if (!t_relay()) {
        switch($rc) {
            case -478:
                xlog("L_WARN","T_Relay returned 478, sending back 503.\n");
                sl_send_reply("503", "Service Unavailable");
                exit;
            default:
                sl_reply_error();
                exit;
        }
    }
    exit;
}
```

When I log $rc value before sl_reply_error() it is valid, but not used by sl_=
reply_error() as SIP error value, it sends 500 instead.

### Troubleshooting

#### Reproduction

I've added incorrect hostnames with flag 16 to set where the message should b=
e sent and t_relay() returns -478. To check the default case inside switch I =
changed case -478 to -479.

#### Log Messages

<!--
Check the syslog file and if there are relevant log messages printed by Kamai=
lio, add them next, or attach to issue, or provide a link to download them (e=
.g., to a pastebin site).
-->

```
1(8) ERROR: <core> [core/resolve.c:1731]: sip_hostport2su(): could not resolv=
e hostname: "va4brhino"
 1(8) ERROR: tm [ut.h:309]: uri2dst2(): failed to resolve "va4brhino"
 1(8) ERROR: tm [t_fwd.c:1759]: t_forward_nonack(): failure to add branches
 1(8) ERROR: sl [sl_funcs.c:414]: sl_reply_error(): stateless error reply use=
d: I'm terribly sorry, server error occurred (1/SL)
```

Logs with different route relay
```
route[RELAY] {
    if (!t_relay()) {
        switch($rc) {
            case -479:
                xlog("L_WARN","T_Relay returned 479, sending back 503.\n");
                sl_send_reply("503", "Service Unavailable");
                exit;
            default:
                xlog("L_WARN","Return code: $rc\n");
                sl_reply_error();
                exit;
        }
    }
    exit;
}
```
```
 1(8) ERROR: <core> [core/resolve.c:1731]: sip_hostport2su(): could not resol=
ve hostname: "va4brhino"
 1(8) ERROR: tm [ut.h:309]: uri2dst2(): failed to resolve "va4brhino"
 1(8) ERROR: tm [t_fwd.c:1759]: t_forward_nonack(): failure to add branches
 1(8) WARNING: <script>: Return code: -478
 1(8) ERROR: sl [sl_funcs.c:414]: sl_reply_error(): stateless error reply use=
d: I'm terribly sorry, server error occurred (1/SL)
```


### Additional Information

  * **Kamailio Version** - output of `kamailio -v`

```
version: kamailio 5.5.0 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, U=
SE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC,=
 DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_
DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF=
_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 4.8.4
```

* **Operating System**:

<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubunt=
u 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->

```
Linux v4bkamailio 5.10.25-linuxkit #1 SMP Tue Mar 23 09:27:39 UTC 2021 x86_64=
 x86_64 x86_64 GNU/Linux
```


--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2802



--===============2050671008==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgoKPGgzPkRlc2NyaXB0aW9uPC9oMz4KPHA+SSB3YW50ZWQgdG8gY2hhbmdlIDQ3OCBy
ZXNwb25zZSB0byA1MDMgaW4gY2FzZSBvZiB0X3JlbGF5KCkgZmFpbHVyZSwgYnV0IGxlYXZlIGRl
ZmF1bHQgYmVoYXZpb3IgaW4gcmVzdCBlcnJvciBjYXNlcy4gSSB1c2VkIHBhcnQgb2YgY29kZSBm
cm9tICJFeGFtcGxlIDEuMS4iIGluc2lkZSA8YSBocmVmPSJodHRwczovL3d3dy5rYW1haWxpby5v
cmcvZG9jcy9tb2R1bGVzL2RldmVsL21vZHVsZXMvb3V0Ym91bmQuaHRtbCIgcmVsPSJub2ZvbGxv
dyI+aHR0cHM6Ly93d3cua2FtYWlsaW8ub3JnL2RvY3MvbW9kdWxlcy9kZXZlbC9tb2R1bGVzL291
dGJvdW5kLmh0bWw8L2E+LiBXaGVuIEkgZ2V0IC00NzggZnJvbSB0X3JlbGF5KCkgaXQgd29ya3Mg
ZmluZSwgYnV0IHdoZW4gdGhpcyBjb2RlIGlzIGRpZmZlcmVudCBzbF9yZXBseV9lcm9ycigpIGRv
bid0IHVzZSBpdCBhcyBpdCBzaG91bGQgYmUuPC9wPgo8cD5UaGlzIGlzIG15IHBhcnQgb2Yga2Ft
YWlsaW8uY2ZnOjwvcD4KPHByZT48Y29kZT5yb3V0ZVtSRUxBWV0gewogICAgaWYgKCF0X3JlbGF5
KCkpIHsKICAgICAgICBzd2l0Y2goJHJjKSB7CiAgICAgICAgICAgIGNhc2UgLTQ3ODoKICAgICAg
ICAgICAgICAgIHhsb2coIkxfV0FSTiIsIlRfUmVsYXkgcmV0dXJuZWQgNDc4LCBzZW5kaW5nIGJh
Y2sgNTAzLlxuIik7CiAgICAgICAgICAgICAgICBzbF9zZW5kX3JlcGx5KCI1MDMiLCAiU2Vydmlj
ZSBVbmF2YWlsYWJsZSIpOwogICAgICAgICAgICAgICAgZXhpdDsKICAgICAgICAgICAgZGVmYXVs
dDoKICAgICAgICAgICAgICAgIHNsX3JlcGx5X2Vycm9yKCk7CiAgICAgICAgICAgICAgICBleGl0
OwogICAgICAgIH0KICAgIH0KICAgIGV4aXQ7Cn0KPC9jb2RlPjwvcHJlPgo8cD5XaGVuIEkgbG9n
ICRyYyB2YWx1ZSBiZWZvcmUgc2xfcmVwbHlfZXJyb3IoKSBpdCBpcyB2YWxpZCwgYnV0IG5vdCB1
c2VkIGJ5IHNsX3JlcGx5X2Vycm9yKCkgYXMgU0lQIGVycm9yIHZhbHVlLCBpdCBzZW5kcyA1MDAg
aW5zdGVhZC48L3A+CjxoMz5Ucm91Ymxlc2hvb3Rpbmc8L2gzPgo8aDQ+UmVwcm9kdWN0aW9uPC9o
ND4KPHA+SSd2ZSBhZGRlZCBpbmNvcnJlY3QgaG9zdG5hbWVzIHdpdGggZmxhZyAxNiB0byBzZXQg
d2hlcmUgdGhlIG1lc3NhZ2Ugc2hvdWxkIGJlIHNlbnQgYW5kIHRfcmVsYXkoKSByZXR1cm5zIC00
NzguIFRvIGNoZWNrIHRoZSBkZWZhdWx0IGNhc2UgaW5zaWRlIHN3aXRjaCBJIGNoYW5nZWQgY2Fz
ZSAtNDc4IHRvIC00NzkuPC9wPgo8aDQ+TG9nIE1lc3NhZ2VzPC9oND4KCjxwcmU+PGNvZGU+MSg4
KSBFUlJPUjogJmx0O2NvcmUmZ3Q7IFtjb3JlL3Jlc29sdmUuYzoxNzMxXTogc2lwX2hvc3Rwb3J0
MnN1KCk6IGNvdWxkIG5vdCByZXNvbHZlIGhvc3RuYW1lOiAidmE0YnJoaW5vIgogMSg4KSBFUlJP
UjogdG0gW3V0Lmg6MzA5XTogdXJpMmRzdDIoKTogZmFpbGVkIHRvIHJlc29sdmUgInZhNGJyaGlu
byIKIDEoOCkgRVJST1I6IHRtIFt0X2Z3ZC5jOjE3NTldOiB0X2ZvcndhcmRfbm9uYWNrKCk6IGZh
aWx1cmUgdG8gYWRkIGJyYW5jaGVzCiAxKDgpIEVSUk9SOiBzbCBbc2xfZnVuY3MuYzo0MTRdOiBz
bF9yZXBseV9lcnJvcigpOiBzdGF0ZWxlc3MgZXJyb3IgcmVwbHkgdXNlZDogSSdtIHRlcnJpYmx5
IHNvcnJ5LCBzZXJ2ZXIgZXJyb3Igb2NjdXJyZWQgKDEvU0wpCjwvY29kZT48L3ByZT4KPHA+TG9n
cyB3aXRoIGRpZmZlcmVudCByb3V0ZSByZWxheTwvcD4KPHByZT48Y29kZT5yb3V0ZVtSRUxBWV0g
ewogICAgaWYgKCF0X3JlbGF5KCkpIHsKICAgICAgICBzd2l0Y2goJHJjKSB7CiAgICAgICAgICAg
IGNhc2UgLTQ3OToKICAgICAgICAgICAgICAgIHhsb2coIkxfV0FSTiIsIlRfUmVsYXkgcmV0dXJu
ZWQgNDc5LCBzZW5kaW5nIGJhY2sgNTAzLlxuIik7CiAgICAgICAgICAgICAgICBzbF9zZW5kX3Jl
cGx5KCI1MDMiLCAiU2VydmljZSBVbmF2YWlsYWJsZSIpOwogICAgICAgICAgICAgICAgZXhpdDsK
ICAgICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgIHhsb2coIkxfV0FSTiIsIlJldHVy
biBjb2RlOiAkcmNcbiIpOwogICAgICAgICAgICAgICAgc2xfcmVwbHlfZXJyb3IoKTsKICAgICAg
ICAgICAgICAgIGV4aXQ7CiAgICAgICAgfQogICAgfQogICAgZXhpdDsKfQo8L2NvZGU+PC9wcmU+
CjxwcmU+PGNvZGU+IDEoOCkgRVJST1I6ICZsdDtjb3JlJmd0OyBbY29yZS9yZXNvbHZlLmM6MTcz
MV06IHNpcF9ob3N0cG9ydDJzdSgpOiBjb3VsZCBub3QgcmVzb2x2ZSBob3N0bmFtZTogInZhNGJy
aGlubyIKIDEoOCkgRVJST1I6IHRtIFt1dC5oOjMwOV06IHVyaTJkc3QyKCk6IGZhaWxlZCB0byBy
ZXNvbHZlICJ2YTRicmhpbm8iCiAxKDgpIEVSUk9SOiB0bSBbdF9md2QuYzoxNzU5XTogdF9mb3J3
YXJkX25vbmFjaygpOiBmYWlsdXJlIHRvIGFkZCBicmFuY2hlcwogMSg4KSBXQVJOSU5HOiAmbHQ7
c2NyaXB0Jmd0OzogUmV0dXJuIGNvZGU6IC00NzgKIDEoOCkgRVJST1I6IHNsIFtzbF9mdW5jcy5j
OjQxNF06IHNsX3JlcGx5X2Vycm9yKCk6IHN0YXRlbGVzcyBlcnJvciByZXBseSB1c2VkOiBJJ20g
dGVycmlibHkgc29ycnksIHNlcnZlciBlcnJvciBvY2N1cnJlZCAoMS9TTCkKPC9jb2RlPjwvcHJl
Pgo8aDM+QWRkaXRpb25hbCBJbmZvcm1hdGlvbjwvaDM+Cjx1bD4KPGxpPjxzdHJvbmc+S2FtYWls
aW8gVmVyc2lvbjwvc3Ryb25nPiAtIG91dHB1dCBvZiA8Y29kZT5rYW1haWxpbyAtdjwvY29kZT48
L2xpPgo8L3VsPgo8cHJlPjxjb2RlPnZlcnNpb246IGthbWFpbGlvIDUuNS4wICh4ODZfNjQvbGlu
dXgpCmZsYWdzOiBVU0VfVENQLCBVU0VfVExTLCBVU0VfU0NUUCwgVExTX0hPT0tTLCBVU0VfUkFX
X1NPQ0tTLCBESVNBQkxFX05BR0xFLCBVU0VfTUNBU1QsIEROU19JUF9IQUNLLCBTSE1fTU1BUCwg
UEtHX01BTExPQywgUV9NQUxMT0MsIEZfTUFMTE9DLCBUTFNGX01BTExPQywgREJHX1NSX01FTU9S
WSwgVVNFX0ZVVEVYLCBGQVNUX0xPQ0stQURBUFRJVkVfV0FJVCwgVVNFXwpETlNfQ0FDSEUsIFVT
RV9ETlNfRkFJTE9WRVIsIFVTRV9OQVBUUiwgVVNFX0RTVF9CTE9DS0xJU1QsIEhBVkVfUkVTT0xW
X1JFUwpBREFQVElWRV9XQUlUX0xPT1BTIDEwMjQsIE1BWF9SRUNWX0JVRkZFUl9TSVpFIDI2MjE0
NCwgTUFYX1VSSV9TSVpFIDEwMjQsIEJVRl9TSVpFIDY1NTM1LCBERUZBVUxUIFBLR19TSVpFIDhN
Qgpwb2xsIG1ldGhvZCBzdXBwb3J0OiBwb2xsLCBlcG9sbF9sdCwgZXBvbGxfZXQsIHNpZ2lvX3J0
LCBzZWxlY3QuCmlkOiB1bmtub3duCmNvbXBpbGVkIHdpdGggZ2NjIDQuOC40CjwvY29kZT48L3By
ZT4KPHVsPgo8bGk+PHN0cm9uZz5PcGVyYXRpbmcgU3lzdGVtPC9zdHJvbmc+OjwvbGk+CjwvdWw+
Cgo8cHJlPjxjb2RlPkxpbnV4IHY0YmthbWFpbGlvIDUuMTAuMjUtbGludXhraXQgIzEgU01QIFR1
ZSBNYXIgMjMgMDk6Mjc6MzkgVVRDIDIwMjEgeDg2XzY0IHg4Nl82NCB4ODZfNjQgR05VL0xpbnV4
CjwvY29kZT48L3ByZT4KCjxwIHN0eWxlPSJmb250LXNpemU6c21hbGw7LXdlYmtpdC10ZXh0LXNp
emUtYWRqdXN0Om5vbmU7Y29sb3I6IzY2NjsiPiZtZGFzaDs8YnIgLz5Zb3UgYXJlIHJlY2Vpdmlu
ZyB0aGlzIGJlY2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRvIHRoaXMgdGhyZWFkLjxiciAvPlJl
cGx5IHRvIHRoaXMgZW1haWwgZGlyZWN0bHksIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9r
YW1haWxpby9rYW1haWxpby9pc3N1ZXMvMjgwMiI+dmlldyBpdCBvbiBHaXRIdWI8L2E+LCBvciA8
YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy91bnN1YnNjcmliZS1hdXRo
L0FCTzdVWk1VSVFKSVVJRVRTQzJWTjJUVFlXQVY1QU5DTkZTTTVBVjQyWjVBIj51bnN1YnNjcmli
ZTwvYT4uPGltZyBzcmM9Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRpb25zL2JlYWNvbi9B
Qk83VVpLQ1c2RUVIWjZaVzVPWVJZVFRZV0FWNUE1Q05GU001QVY0Mlo1S1lZM1BOVldXSzNUVUw1
MkhTNERGVVZFWEc0M1ZNV1ZHRzMzTk5WU1c0NUM3TkZTTTRPRU1CV1NBLmdpZiIgaGVpZ2h0PSIx
IiB3aWR0aD0iMSIgYWx0PSIiIC8+PC9wPgo8c2NyaXB0IHR5cGU9ImFwcGxpY2F0aW9uL2xkK2pz
b24iPlsKewoiQGNvbnRleHQiOiAiaHR0cDovL3NjaGVtYS5vcmciLAoiQHR5cGUiOiAiRW1haWxN
ZXNzYWdlIiwKInBvdGVudGlhbEFjdGlvbiI6IHsKIkB0eXBlIjogIlZpZXdBY3Rpb24iLAoidGFy
Z2V0IjogImh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvMjgwMiIs
CiJ1cmwiOiAiaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8yODAy
IiwKIm5hbWUiOiAiVmlldyBJc3N1ZSIKfSwKImRlc2NyaXB0aW9uIjogIlZpZXcgdGhpcyBJc3N1
ZSBvbiBHaXRIdWIiLAoicHVibGlzaGVyIjogewoiQHR5cGUiOiAiT3JnYW5pemF0aW9uIiwKIm5h
bWUiOiAiR2l0SHViIiwKInVybCI6ICJodHRwczovL2dpdGh1Yi5jb20iCn0KfQpdPC9zY3JpcHQ+

--===============2050671008==--


From notifications@github.com Mon Jul 26 17:36:31 2021
From: Daniel-Constantin Mierla <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] Wrong return code used by
 sl_reply_error() (#2802)
Date: Mon, 26 Jul 2021 08:36:29 -0700
Message-ID: <kamailio/kamailio/issues/2802/886809685@github.com>
In-Reply-To: <kamailio/kamailio/issues/2802@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0065863427=="

--===============0065863427==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

`sl_send_error()` is for generic error reply. You can send any reply code usi=
ng send_reply("code", "text"), use `sl_send_error()` only when you want the b=
ehaviour from the C code. For further discussions, email to sr-users(a)lists.=
kamailio.org .

--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2802#issuecomment-886809685



--===============0065863427==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgo8cD48Y29kZT5zbF9zZW5kX2Vycm9yKCk8L2NvZGU+IGlzIGZvciBnZW5lcmljIGVy
cm9yIHJlcGx5LiBZb3UgY2FuIHNlbmQgYW55IHJlcGx5IGNvZGUgdXNpbmcgc2VuZF9yZXBseSgi
Y29kZSIsICJ0ZXh0IiksIHVzZSA8Y29kZT5zbF9zZW5kX2Vycm9yKCk8L2NvZGU+IG9ubHkgd2hl
biB5b3Ugd2FudCB0aGUgYmVoYXZpb3VyIGZyb20gdGhlIEMgY29kZS4gRm9yIGZ1cnRoZXIgZGlz
Y3Vzc2lvbnMsIGVtYWlsIHRvIDxhIGhyZWY9Im1haWx0bzpzci11c2Vyc0BsaXN0cy5rYW1haWxp
by5vcmciPnNyLXVzZXJzQGxpc3RzLmthbWFpbGlvLm9yZzwvYT4gLjwvcD4KCjxwIHN0eWxlPSJm
b250LXNpemU6c21hbGw7LXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0Om5vbmU7Y29sb3I6IzY2Njsi
PiZtZGFzaDs8YnIgLz5Zb3UgYXJlIHJlY2VpdmluZyB0aGlzIGJlY2F1c2UgeW91IGFyZSBzdWJz
Y3JpYmVkIHRvIHRoaXMgdGhyZWFkLjxiciAvPlJlcGx5IHRvIHRoaXMgZW1haWwgZGlyZWN0bHks
IDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvMjgw
MiNpc3N1ZWNvbW1lbnQtODg2ODA5Njg1Ij52aWV3IGl0IG9uIEdpdEh1YjwvYT4sIG9yIDxhIGhy
ZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9ub3RpZmljYXRpb25zL3Vuc3Vic2NyaWJlLWF1dGgvQUJP
N1VaSU1NWTdKVFJUSEdYNEZDSDNUWlY2SDNBTkNORlNNNUFWNDJaNUEiPnVuc3Vic2NyaWJlPC9h
Pi48aW1nIHNyYz0iaHR0cHM6Ly9naXRodWIuY29tL25vdGlmaWNhdGlvbnMvYmVhY29uL0FCTzdV
Wk5SRE1YSldISFhFSldLRlZUVFpWNkgzQTVDTkZTTTVBVjQyWjVLWVkzUE5WV1dLM1RVTDUySFM0
REZWUkVYRzQzVk1WQlc2M0xOTVZYSEpLVERONVdXMlpMT09SUFdTWkdPR1ROMklWSS5naWYiIGhl
aWdodD0iMSIgd2lkdGg9IjEiIGFsdD0iIiAvPjwvcD4KPHNjcmlwdCB0eXBlPSJhcHBsaWNhdGlv
bi9sZCtqc29uIj5bCnsKIkBjb250ZXh0IjogImh0dHA6Ly9zY2hlbWEub3JnIiwKIkB0eXBlIjog
IkVtYWlsTWVzc2FnZSIsCiJwb3RlbnRpYWxBY3Rpb24iOiB7CiJAdHlwZSI6ICJWaWV3QWN0aW9u
IiwKInRhcmdldCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVz
LzI4MDIjaXNzdWVjb21tZW50LTg4NjgwOTY4NSIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRodWIuY29t
L2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8yODAyI2lzc3VlY29tbWVudC04ODY4MDk2ODUiLAoi
bmFtZSI6ICJWaWV3IElzc3VlIgp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlzIElzc3VlIG9u
IEdpdEh1YiIsCiJwdWJsaXNoZXIiOiB7CiJAdHlwZSI6ICJPcmdhbml6YXRpb24iLAoibmFtZSI6
ICJHaXRIdWIiLAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbSIKfQp9Cl08L3NjcmlwdD4=

--===============0065863427==--


From notifications@github.com Mon Jul 26 17:36:32 2021
From: Daniel-Constantin Mierla <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] Wrong return code used by
 sl_reply_error() (#2802)
Date: Mon, 26 Jul 2021 08:36:30 -0700
Message-ID: <kamailio/kamailio/issue/2802/issue_event/5069205364@github.com>
In-Reply-To: <kamailio/kamailio/issues/2802@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1333939453=="

--===============1333939453==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Closed #2802.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2802#event-5069205364



--===============1333939453==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgo8cD5DbG9zZWQgPGEgY2xhc3M9Imlzc3VlLWxpbmsganMtaXNzdWUtbGluayIgZGF0
YS1lcnJvci10ZXh0PSJGYWlsZWQgdG8gbG9hZCB0aXRsZSIgZGF0YS1pZD0iOTQ4NzAyNjI4IiBk
YXRhLXBlcm1pc3Npb24tdGV4dD0iVGl0bGUgaXMgcHJpdmF0ZSIgZGF0YS11cmw9Imh0dHBzOi8v
Z2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvMjgwMiIgZGF0YS1ob3ZlcmNhcmQt
dHlwZT0iaXNzdWUiIGRhdGEtaG92ZXJjYXJkLXVybD0iL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vl
cy8yODAyL2hvdmVyY2FyZCIgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFp
bGlvL2lzc3Vlcy8yODAyIj4jMjgwMjwvYT4uPC9wPgoKPHAgc3R5bGU9ImZvbnQtc2l6ZTpzbWFs
bDstd2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6bm9uZTtjb2xvcjojNjY2OyI+Jm1kYXNoOzxiciAv
PllvdSBhcmUgcmVjZWl2aW5nIHRoaXMgYmVjYXVzZSB5b3UgYXJlIHN1YnNjcmliZWQgdG8gdGhp
cyB0aHJlYWQuPGJyIC8+UmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJlY3RseSwgPGEgaHJlZj0iaHR0
cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8yODAyI2V2ZW50LTUwNjky
MDUzNjQiPnZpZXcgaXQgb24gR2l0SHViPC9hPiwgb3IgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIu
Y29tL25vdGlmaWNhdGlvbnMvdW5zdWJzY3JpYmUtYXV0aC9BQk83VVpKT1NPSjc2U1ZDRzNaS0lL
RFRaVjZINUFOQ05GU001QVY0Mlo1QSI+dW5zdWJzY3JpYmU8L2E+LjxpbWcgc3JjPSJodHRwczov
L2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy9iZWFjb24vQUJPN1VaSU1VSFZOSlc1V0tXVEhWWURU
WlY2SDVBNUNORlNNNUFWNDJaNUtZWTNQTlZXV0szVFVMNTJIUzRERldaRVhHNDNWTVZDWE1aTE9P
UkhHNjVESk1aVVdHWUxVTkZYVzVLVERONVdXMlpMT09SUFdTWkdQQUFBQUFBSk9FWFhYSS5naWYi
IGhlaWdodD0iMSIgd2lkdGg9IjEiIGFsdD0iIiAvPjwvcD4KPHNjcmlwdCB0eXBlPSJhcHBsaWNh
dGlvbi9sZCtqc29uIj5bCnsKIkBjb250ZXh0IjogImh0dHA6Ly9zY2hlbWEub3JnIiwKIkB0eXBl
IjogIkVtYWlsTWVzc2FnZSIsCiJwb3RlbnRpYWxBY3Rpb24iOiB7CiJAdHlwZSI6ICJWaWV3QWN0
aW9uIiwKInRhcmdldCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNz
dWVzLzI4MDIjZXZlbnQtNTA2OTIwNTM2NCIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRodWIuY29tL2th
bWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8yODAyI2V2ZW50LTUwNjkyMDUzNjQiLAoibmFtZSI6ICJW
aWV3IElzc3VlIgp9LAoiZGVzY3JpcHRpb24iOiAiVmlldyB0aGlzIElzc3VlIG9uIEdpdEh1YiIs
CiJwdWJsaXNoZXIiOiB7CiJAdHlwZSI6ICJPcmdhbml6YXRpb24iLAoibmFtZSI6ICJHaXRIdWIi
LAoidXJsIjogImh0dHBzOi8vZ2l0aHViLmNvbSIKfQp9Cl08L3NjcmlwdD4=

--===============1333939453==--


From notifications@github.com Mon Jul 26 17:59:00 2021
From: Piotr Grabowski <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] Wrong return code used by
 sl_reply_error() (#2802)
Date: Mon, 26 Jul 2021 08:58:57 -0700
Message-ID: <kamailio/kamailio/issues/2802/886826241@github.com>
In-Reply-To: <kamailio/kamailio/issues/2802@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1786696517=="

--===============1786696517==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi @miconda . I think you misunderstood bug here. Issue is that if and switch=
 statements change behaviour of sl_send_error(). Same examples as configurati=
on from this bug report are in Kamailio documentation so it looks like a bug,=
 if not maybe documentation needs an update.

--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2802#issuecomment-886826241



--===============1786696517==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgo8cD5IaSA8YSBjbGFzcz0idXNlci1tZW50aW9uIiBkYXRhLWhvdmVyY2FyZC10eXBl
PSJ1c2VyIiBkYXRhLWhvdmVyY2FyZC11cmw9Ii91c2Vycy9taWNvbmRhL2hvdmVyY2FyZCIgZGF0
YS1vY3RvLWNsaWNrPSJob3ZlcmNhcmQtbGluay1jbGljayIgZGF0YS1vY3RvLWRpbWVuc2lvbnM9
ImxpbmtfdHlwZTpzZWxmIiBocmVmPSJodHRwczovL2dpdGh1Yi5jb20vbWljb25kYSI+QG1pY29u
ZGE8L2E+IC4gSSB0aGluayB5b3UgbWlzdW5kZXJzdG9vZCBidWcgaGVyZS4gSXNzdWUgaXMgdGhh
dCBpZiBhbmQgc3dpdGNoIHN0YXRlbWVudHMgY2hhbmdlIGJlaGF2aW91ciBvZiBzbF9zZW5kX2Vy
cm9yKCkuIFNhbWUgZXhhbXBsZXMgYXMgY29uZmlndXJhdGlvbiBmcm9tIHRoaXMgYnVnIHJlcG9y
dCBhcmUgaW4gS2FtYWlsaW8gZG9jdW1lbnRhdGlvbiBzbyBpdCBsb29rcyBsaWtlIGEgYnVnLCBp
ZiBub3QgbWF5YmUgZG9jdW1lbnRhdGlvbiBuZWVkcyBhbiB1cGRhdGUuPC9wPgoKPHAgc3R5bGU9
ImZvbnQtc2l6ZTpzbWFsbDstd2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6bm9uZTtjb2xvcjojNjY2
OyI+Jm1kYXNoOzxiciAvPllvdSBhcmUgcmVjZWl2aW5nIHRoaXMgYmVjYXVzZSB5b3UgYXJlIHN1
YnNjcmliZWQgdG8gdGhpcyB0aHJlYWQuPGJyIC8+UmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJlY3Rs
eSwgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8y
ODAyI2lzc3VlY29tbWVudC04ODY4MjYyNDEiPnZpZXcgaXQgb24gR2l0SHViPC9hPiwgb3IgPGEg
aHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL25vdGlmaWNhdGlvbnMvdW5zdWJzY3JpYmUtYXV0aC9B
Qk83VVpNUFBLU0JRRkZKQkhFNVRNM1RaV0E0REFOQ05GU001QVY0Mlo1QSI+dW5zdWJzY3JpYmU8
L2E+LjxpbWcgc3JjPSJodHRwczovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy9iZWFjb24vQUJP
N1VaSVJMREFaVkxZVzRPSVdMNFRUWldBNERBNUNORlNNNUFWNDJaNUtZWTNQTlZXV0szVFVMNTJI
UzRERlZSRVhHNDNWTVZCVzYzTE5NVlhISktURE41V1cyWkxPT1JQV1NaR09HVE42S0FJLmdpZiIg
aGVpZ2h0PSIxIiB3aWR0aD0iMSIgYWx0PSIiIC8+PC9wPgo8c2NyaXB0IHR5cGU9ImFwcGxpY2F0
aW9uL2xkK2pzb24iPlsKewoiQGNvbnRleHQiOiAiaHR0cDovL3NjaGVtYS5vcmciLAoiQHR5cGUi
OiAiRW1haWxNZXNzYWdlIiwKInBvdGVudGlhbEFjdGlvbiI6IHsKIkB0eXBlIjogIlZpZXdBY3Rp
b24iLAoidGFyZ2V0IjogImh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1
ZXMvMjgwMiNpc3N1ZWNvbW1lbnQtODg2ODI2MjQxIiwKInVybCI6ICJodHRwczovL2dpdGh1Yi5j
b20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzI4MDIjaXNzdWVjb21tZW50LTg4NjgyNjI0MSIs
CiJuYW1lIjogIlZpZXcgSXNzdWUiCn0sCiJkZXNjcmlwdGlvbiI6ICJWaWV3IHRoaXMgSXNzdWUg
b24gR2l0SHViIiwKInB1Ymxpc2hlciI6IHsKIkB0eXBlIjogIk9yZ2FuaXphdGlvbiIsCiJuYW1l
IjogIkdpdEh1YiIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRodWIuY29tIgp9Cn0KXTwvc2NyaXB0Pg==

--===============1786696517==--


From notifications@github.com Mon Jul 26 18:16:33 2021
From: Daniel-Constantin Mierla <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] Wrong return code used by
 sl_reply_error() (#2802)
Date: Mon, 26 Jul 2021 09:16:30 -0700
Message-ID: <kamailio/kamailio/issues/2802/886841189@github.com>
In-Reply-To: <kamailio/kamailio/issues/2802@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0385390736=="

--===============0385390736==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Then I still do not understand properly after your last comment.

Note that $rc can be updated by any kamailio action, so you should save its v=
alue in a $var(...) if you want to use it later. If you do an xlog(), after i=
t the $rc is updated to the return of xlog().

--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2802#issuecomment-886841189



--===============0385390736==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgo8cD5UaGVuIEkgc3RpbGwgZG8gbm90IHVuZGVyc3RhbmQgcHJvcGVybHkgYWZ0ZXIg
eW91ciBsYXN0IGNvbW1lbnQuPC9wPgo8cD5Ob3RlIHRoYXQgJHJjIGNhbiBiZSB1cGRhdGVkIGJ5
IGFueSBrYW1haWxpbyBhY3Rpb24sIHNvIHlvdSBzaG91bGQgc2F2ZSBpdHMgdmFsdWUgaW4gYSAk
dmFyKC4uLikgaWYgeW91IHdhbnQgdG8gdXNlIGl0IGxhdGVyLiBJZiB5b3UgZG8gYW4geGxvZygp
LCBhZnRlciBpdCB0aGUgJHJjIGlzIHVwZGF0ZWQgdG8gdGhlIHJldHVybiBvZiB4bG9nKCkuPC9w
PgoKPHAgc3R5bGU9ImZvbnQtc2l6ZTpzbWFsbDstd2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6bm9u
ZTtjb2xvcjojNjY2OyI+Jm1kYXNoOzxiciAvPllvdSBhcmUgcmVjZWl2aW5nIHRoaXMgYmVjYXVz
ZSB5b3UgYXJlIHN1YnNjcmliZWQgdG8gdGhpcyB0aHJlYWQuPGJyIC8+UmVwbHkgdG8gdGhpcyBl
bWFpbCBkaXJlY3RseSwgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFp
bGlvL2lzc3Vlcy8yODAyI2lzc3VlY29tbWVudC04ODY4NDExODkiPnZpZXcgaXQgb24gR2l0SHVi
PC9hPiwgb3IgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL25vdGlmaWNhdGlvbnMvdW5zdWJz
Y3JpYmUtYXV0aC9BQk83VVpONlpPSklTM0wzTkZRSDNZVFRaV0M1NUFOQ05GU001QVY0Mlo1QSI+
dW5zdWJzY3JpYmU8L2E+LjxpbWcgc3JjPSJodHRwczovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9u
cy9iZWFjb24vQUJPN1VaUEVQV1RaVUs0TklCNkpKQTNUWldDNTVBNUNORlNNNUFWNDJaNUtZWTNQ
TlZXV0szVFVMNTJIUzRERlZSRVhHNDNWTVZCVzYzTE5NVlhISktURE41V1cyWkxPT1JQV1NaR09H
VE9CNlpJLmdpZiIgaGVpZ2h0PSIxIiB3aWR0aD0iMSIgYWx0PSIiIC8+PC9wPgo8c2NyaXB0IHR5
cGU9ImFwcGxpY2F0aW9uL2xkK2pzb24iPlsKewoiQGNvbnRleHQiOiAiaHR0cDovL3NjaGVtYS5v
cmciLAoiQHR5cGUiOiAiRW1haWxNZXNzYWdlIiwKInBvdGVudGlhbEFjdGlvbiI6IHsKIkB0eXBl
IjogIlZpZXdBY3Rpb24iLAoidGFyZ2V0IjogImh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9r
YW1haWxpby9pc3N1ZXMvMjgwMiNpc3N1ZWNvbW1lbnQtODg2ODQxMTg5IiwKInVybCI6ICJodHRw
czovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzI4MDIjaXNzdWVjb21tZW50
LTg4Njg0MTE4OSIsCiJuYW1lIjogIlZpZXcgSXNzdWUiCn0sCiJkZXNjcmlwdGlvbiI6ICJWaWV3
IHRoaXMgSXNzdWUgb24gR2l0SHViIiwKInB1Ymxpc2hlciI6IHsKIkB0eXBlIjogIk9yZ2FuaXph
dGlvbiIsCiJuYW1lIjogIkdpdEh1YiIsCiJ1cmwiOiAiaHR0cHM6Ly9naXRodWIuY29tIgp9Cn0K
XTwvc2NyaXB0Pg==

--===============0385390736==--


From notifications@github.com Mon Jul 26 18:44:55 2021
From: Piotr Grabowski <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio/kamailio] Wrong return code used by
 sl_reply_error() (#2802)
Date: Mon, 26 Jul 2021 09:44:52 -0700
Message-ID: <kamailio/kamailio/issues/2802/886860352@github.com>
In-Reply-To: <kamailio/kamailio/issues/2802@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1757668759=="

--===============1757668759==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Please have a look at https://www.kamailio.org/docs/modules/devel/modules/out=
bound.html "Example 1.1. Edge Proxy Configuration" it uses exact same syntax.=
 If expected behaviour is that any statement can affect sl_reply_error() then=
 this example needs updating.

--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2802#issuecomment-886860352



--===============1757668759==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+PC9wPgo8cD5QbGVhc2UgaGF2ZSBhIGxvb2sgYXQgPGEgaHJlZj0iaHR0cHM6Ly93d3cua2Ft
YWlsaW8ub3JnL2RvY3MvbW9kdWxlcy9kZXZlbC9tb2R1bGVzL291dGJvdW5kLmh0bWwiIHJlbD0i
bm9mb2xsb3ciPmh0dHBzOi8vd3d3LmthbWFpbGlvLm9yZy9kb2NzL21vZHVsZXMvZGV2ZWwvbW9k
dWxlcy9vdXRib3VuZC5odG1sPC9hPiAiRXhhbXBsZSAxLjEuIEVkZ2UgUHJveHkgQ29uZmlndXJh
dGlvbiIgaXQgdXNlcyBleGFjdCBzYW1lIHN5bnRheC4gSWYgZXhwZWN0ZWQgYmVoYXZpb3VyIGlz
IHRoYXQgYW55IHN0YXRlbWVudCBjYW4gYWZmZWN0IHNsX3JlcGx5X2Vycm9yKCkgdGhlbiB0aGlz
IGV4YW1wbGUgbmVlZHMgdXBkYXRpbmcuPC9wPgoKPHAgc3R5bGU9ImZvbnQtc2l6ZTpzbWFsbDst
d2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6bm9uZTtjb2xvcjojNjY2OyI+Jm1kYXNoOzxiciAvPllv
dSBhcmUgcmVjZWl2aW5nIHRoaXMgYmVjYXVzZSB5b3UgYXJlIHN1YnNjcmliZWQgdG8gdGhpcyB0
aHJlYWQuPGJyIC8+UmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJlY3RseSwgPGEgaHJlZj0iaHR0cHM6
Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vlcy8yODAyI2lzc3VlY29tbWVudC04
ODY4NjAzNTIiPnZpZXcgaXQgb24gR2l0SHViPC9hPiwgb3IgPGEgaHJlZj0iaHR0cHM6Ly9naXRo
dWIuY29tL25vdGlmaWNhdGlvbnMvdW5zdWJzY3JpYmUtYXV0aC9BQk83VVpPVVU2TEs1WEFGV1o3
TEVETFRaV0dJSkFOQ05GU001QVY0Mlo1QSI+dW5zdWJzY3JpYmU8L2E+LjxpbWcgc3JjPSJodHRw
czovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy9iZWFjb24vQUJPN1VaSjNQSzdKS1JKUllET1hJ
TExUWldHSUpBNUNORlNNNUFWNDJaNUtZWTNQTlZXV0szVFVMNTJIUzRERlZSRVhHNDNWTVZCVzYz
TE5NVlhISktURE41V1cyWkxPT1JQV1NaR09HVE9HVVFBLmdpZiIgaGVpZ2h0PSIxIiB3aWR0aD0i
MSIgYWx0PSIiIC8+PC9wPgo8c2NyaXB0IHR5cGU9ImFwcGxpY2F0aW9uL2xkK2pzb24iPlsKewoi
QGNvbnRleHQiOiAiaHR0cDovL3NjaGVtYS5vcmciLAoiQHR5cGUiOiAiRW1haWxNZXNzYWdlIiwK
InBvdGVudGlhbEFjdGlvbiI6IHsKIkB0eXBlIjogIlZpZXdBY3Rpb24iLAoidGFyZ2V0IjogImh0
dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvMjgwMiNpc3N1ZWNvbW1l
bnQtODg2ODYwMzUyIiwKInVybCI6ICJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWls
aW8vaXNzdWVzLzI4MDIjaXNzdWVjb21tZW50LTg4Njg2MDM1MiIsCiJuYW1lIjogIlZpZXcgSXNz
dWUiCn0sCiJkZXNjcmlwdGlvbiI6ICJWaWV3IHRoaXMgSXNzdWUgb24gR2l0SHViIiwKInB1Ymxp
c2hlciI6IHsKIkB0eXBlIjogIk9yZ2FuaXphdGlvbiIsCiJuYW1lIjogIkdpdEh1YiIsCiJ1cmwi
OiAiaHR0cHM6Ly9naXRodWIuY29tIgp9Cn0KXTwvc2NyaXB0Pg==

--===============1757668759==--