From miconda@gmail.com Wed Mar 17 10:44:18 2021
From: Daniel-Constantin Mierla <miconda@gmail.com>
To: sr-dev@lists.kamailio.org
Subject:
 Re: [sr-dev] git:master:91c5626d: lrkproxy: update doc/ folder for README
Date: Wed, 17 Mar 2021 10:44:14 +0100
Message-ID: <6b581108-b973-9ee9-972c-0453deb976e2@gmail.com>
In-Reply-To: <E1lMSKx-0006Ec-HD@www.kamailio.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1097091268=="

--===============1097091268==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

this commit seems to introduce some English language mistakes, actually
replacing what was good English (in my opinion) - see comments inline:

On 17.03.21 10:19, mojtaba wrote:
> Module: kamailio
> Branch: master
> Commit: 91c5626d7119cd9c78028d9b3bf968ecd7db5952
> URL: https://github.com/kamailio/kamailio/commit/91c5626d7119cd9c78028d9b3b=
f968ecd7db5952
>
> Author: mojtaba <mespio(a)gmail.com>
> Committer: mojtaba <mespio(a)gmail.com>
> Date: 2021-03-17T12:49:04+03:30
>
> lrkproxy: update doc/ folder for README
>
> ---
>
> Modified: src/modules/lrkproxy/doc/lrkproxy_admin.xml
>
> ---
>
> Diff:  https://github.com/kamailio/kamailio/commit/91c5626d7119cd9c78028d9b=
3bf968ecd7db5952.diff
> Patch: https://github.com/kamailio/kamailio/commit/91c5626d7119cd9c78028d9b=
3bf968ecd7db5952.patch
>
> ---
>
> diff --git a/src/modules/lrkproxy/doc/lrkproxy_admin.xml b/src/modules/lrkp=
roxy/doc/lrkproxy_admin.xml
> index 57cc2faab3..1f9eacc534 100644
> --- a/src/modules/lrkproxy/doc/lrkproxy_admin.xml
> +++ b/src/modules/lrkproxy/doc/lrkproxy_admin.xml
> [...]
> =20
> @@ -33,12 +35,12 @@
>  	<section>
>  		<title>LRKP_Controlling Layer (LRKP_CL)</title>
>  		<para>
> -			The first layer is developed as User-Space
> +			The first layer develope as User-Space

You replaced "is developed" with "develope", which is not a valid
English word.


>  			application that allows User-Space to directly
>  			access and manipulate cache data
>  			buffer and packet buffer in Kernel-Space. This layer
>  			gets all information about creating new sessions,
> -			active sessions and tear-down sessions which is
> +			active sessions and teardown sessions which is
>  	       		gotten from SDP body during signaling plan and relay
>  			them to the LRKP-Transport Stateful Layer (LRKP-
>  			TSL).
> @@ -47,7 +49,7 @@
>  	<section>
>  		<title>LRKP_Transport Stateful Layer (LRKP_TSL)</title>
>  		<para>
> -			The second layer is developed in Kernel-Space as
> +			The second layer develope in Kernel-Space as

You replaced again "is developed" with "develope", which is not a valid
English word.

Cheers,
Daniel

--=20
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Funding: https://www.paypal.me/dcmierla



--===============1097091268==--