From notifications@github.com Mon Jan 19 14:35:25 2015
From: Walter Doekes <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] [kamailio] websocket: `tcpconn_get()` error gets turned into
 `E_OUT_OF_MEM` which becomes "500 No Error" (#47)
Date: Mon, 19 Jan 2015 05:35:18 -0800
Message-ID: <kamailio/kamailio/issues/47@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0730433579=="

--===============0730433579==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

My websocket TLS server is full of these kinds of messages:

    Jan 18 18:10:26 ws0 /usr/sbin/kamailio[19701]: NOTICE: <script>:
      http:217.120.x.x:55386: WS connection closed
    ...
    Jan 18 18:10:26 ws0 /usr/sbin/kamailio[19689]: WARNING: <core>
      [msg_translator.c:2506]: via_builder(): TCP/TLS connection (id: 0) for =
WebSocket could not be found
    Jan 18 18:10:26 ws0 /usr/sbin/kamailio[19689]: ERROR: <core>
      [msg_translator.c:1722]: build_req_buf_from_sip_req(): could not create=
 Via header
    Jan 18 18:10:26 ws0 /usr/sbin/kamailio[19689]: ERROR: tm
      [t_fwd.c:527]: prepare_new_uac(): could not build request
    Jan 18 18:10:26 ws0 /usr/sbin/kamailio[19689]: ERROR: tm
      [t_fwd.c:1773]: t_forward_nonack(): ERROR: t_forward_nonack: failure to=
 add branches
    Jan 18 18:10:26 ws0 /usr/sbin/kamailio[19689]: ERROR: sl
      [sl_funcs.c:387]: sl_reply_error(): ERROR: sl_reply_error used: No erro=
r (2/SL)
    (repeat these last errors for a bunch of attempted NOTIFY forwards)

The route block does basically something like this:

        # add_contact_alias(); # only for requests from the outside
        loose_route();
        if (!t_relay()) {
                sl_reply_error();
        }

The problem arises here:

    }else if (send_info->proto=3D=3DPROTO_WS){
    ...
        con =3D tcpconn_get(send_info->id, &ip, port, from, 0)
    ...
        if (con =3D=3D NULL) {
            LM_WARN("TCP/TLS connection (id: %d) for WebSocket could not be f=
ound\n", send_info->id);

The NULL failure status gets returned up to `prepare_new_uac` in `t_fwd.c`:

        shbuf=3Dbuild_req_buf_from_sip_req( i_req, &len, dst, BUILD_IN_SHM);
        if (!shbuf) {
                LM_ERR("could not build request\n");
                ret=3DE_OUT_OF_MEM;
                goto error01;
        }

At this point, ser_error will become `E_OUT_OF_MEM` while it should be someth=
ing like `E_SEND`.

And `E_OUT_OF_MEM` gets translated to `500 No Error` because we're not runnin=
g in DEBUG mode.

What causes the connection to drop in the first place, you ask?

    18:10:18.690738 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [S], seq 132=
3983240, win 8192, options [mss 1460,nop,wscale 8,nop,nop,sackOK], length 0
    18:10:18.690863 IP 195.35.x.x.443 > 217.120.x.x.55386: Flags [S.], seq 40=
77761781, ack 1323983241, win 14600, options [mss 1460,nop,nop,sackOK,nop,wsc=
ale 3], length 0
    18:10:18.710846 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [.], ack 1, =
win 256, length 0
    18:10:18.808751 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [P.], seq 1:=
246, ack 1, win 256, length 245
    ...
    18:10:19.233415 IP 195.35.x.x.443 > 217.120.x.x.55386: Flags [.], ack 313=
48, win 5126, length 0
    18:10:26.489764 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [P.], seq 31=
348:32473, ack 34578, win 255, length 1125
    ...
    18:10:26.501409 IP 195.35.x.x.443 > 217.120.x.x.55386: Flags [P.], seq 42=
255:42916, ack 46010, win 5046, length 661
    18:10:26.527755 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [.], ack 369=
93, win 252, length 0
    18:10:26.527860 IP 195.35.x.x.443 > 217.120.x.x.55386: Flags [.], seq 429=
16:47296, ack 46010, win 5278, length 4380
    18:10:26.527888 IP 195.35.x.x.443 > 217.120.x.x.55386: Flags [FP.], seq 4=
7296:48663, ack 46010, win 5278, length 1367
    18:10:26.529179 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [.], ack 405=
01, win 254, length 0
    18:10:26.529200 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [.], ack 429=
16, win 251, length 0
    18:10:26.547276 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [.], ack 486=
64, win 251, length 0
    18:10:26.549712 IP 217.120.x.x.55386 > 195.35.x.x.443: Flags [F.], seq 46=
010, ack 48664, win 251, length 0
    18:10:26.549750 IP 195.35.x.x.443 > 217.120.x.x.55386: Flags [.], ack 460=
11, win 5278, length 0

Where you see that the FIN is initiated by `195.35.x.x` which is the Kamailio=
 websocket server.

The cause (probably) is the WS client closing the connection. In this case af=
ter re-subscribing with Expires:0. The presence server attempts to reply with=
 a bunch of NOTIFYs with `Subscription-State: terminated;reason=3Dtimeout` bu=
t they bounce on the broken connection. If Kamailio would return a nice "477 =
Unfortunately error on sending to next hop occurred" it'd be prettier.

Getting less "error" messages (a total of 6 *per* expired/unsubscribed subscr=
iption) after this error --which is apparently very common -- would be benefi=
cial too.

As for fixing:
- We could change the `via_builder` to set `ser_error` (and check that in `bu=
ild_req_buf_from_sip_req`), or
- add error-code-out-parameters to all calls from `build_req_buf_from_sip_req=
` and down.
I'm not sure if either is the best way.

As for the excessive error reporting, would looking at `ser_error` before pri=
nting (another) error be an acceptable fix?

Cheers,
Walter Doekes
OSSO B.V.

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/47



--===============0730433579==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+TXkgd2Vic29ja2V0IFRMUyBzZXJ2ZXIgaXMgZnVsbCBvZiB0aGVzZSBraW5kcyBvZiBtZXNz
YWdlczo8L3A+Cgo8cHJlPjxjb2RlPkphbiAxOCAxODoxMDoyNiB3czAgL3Vzci9zYmluL2thbWFp
bGlvWzE5NzAxXTogTk9USUNFOiAmbHQ7c2NyaXB0Jmd0OzoKICBodHRwOjIxNy4xMjAueC54OjU1
Mzg2OiBXUyBjb25uZWN0aW9uIGNsb3NlZAouLi4KSmFuIDE4IDE4OjEwOjI2IHdzMCAvdXNyL3Ni
aW4va2FtYWlsaW9bMTk2ODldOiBXQVJOSU5HOiAmbHQ7Y29yZSZndDsKICBbbXNnX3RyYW5zbGF0
b3IuYzoyNTA2XTogdmlhX2J1aWxkZXIoKTogVENQL1RMUyBjb25uZWN0aW9uIChpZDogMCkgZm9y
IFdlYlNvY2tldCBjb3VsZCBub3QgYmUgZm91bmQKSmFuIDE4IDE4OjEwOjI2IHdzMCAvdXNyL3Ni
aW4va2FtYWlsaW9bMTk2ODldOiBFUlJPUjogJmx0O2NvcmUmZ3Q7CiAgW21zZ190cmFuc2xhdG9y
LmM6MTcyMl06IGJ1aWxkX3JlcV9idWZfZnJvbV9zaXBfcmVxKCk6IGNvdWxkIG5vdCBjcmVhdGUg
VmlhIGhlYWRlcgpKYW4gMTggMTg6MTA6MjYgd3MwIC91c3Ivc2Jpbi9rYW1haWxpb1sxOTY4OV06
IEVSUk9SOiB0bQogIFt0X2Z3ZC5jOjUyN106IHByZXBhcmVfbmV3X3VhYygpOiBjb3VsZCBub3Qg
YnVpbGQgcmVxdWVzdApKYW4gMTggMTg6MTA6MjYgd3MwIC91c3Ivc2Jpbi9rYW1haWxpb1sxOTY4
OV06IEVSUk9SOiB0bQogIFt0X2Z3ZC5jOjE3NzNdOiB0X2ZvcndhcmRfbm9uYWNrKCk6IEVSUk9S
OiB0X2ZvcndhcmRfbm9uYWNrOiBmYWlsdXJlIHRvIGFkZCBicmFuY2hlcwpKYW4gMTggMTg6MTA6
MjYgd3MwIC91c3Ivc2Jpbi9rYW1haWxpb1sxOTY4OV06IEVSUk9SOiBzbAogIFtzbF9mdW5jcy5j
OjM4N106IHNsX3JlcGx5X2Vycm9yKCk6IEVSUk9SOiBzbF9yZXBseV9lcnJvciB1c2VkOiBObyBl
cnJvciAoMi9TTCkKKHJlcGVhdCB0aGVzZSBsYXN0IGVycm9ycyBmb3IgYSBidW5jaCBvZiBhdHRl
bXB0ZWQgTk9USUZZIGZvcndhcmRzKQo8L2NvZGU+PC9wcmU+Cgo8cD5UaGUgcm91dGUgYmxvY2sg
ZG9lcyBiYXNpY2FsbHkgc29tZXRoaW5nIGxpa2UgdGhpczo8L3A+Cgo8cHJlPjxjb2RlPiAgICAj
IGFkZF9jb250YWN0X2FsaWFzKCk7ICMgb25seSBmb3IgcmVxdWVzdHMgZnJvbSB0aGUgb3V0c2lk
ZQogICAgbG9vc2Vfcm91dGUoKTsKICAgIGlmICghdF9yZWxheSgpKSB7CiAgICAgICAgICAgIHNs
X3JlcGx5X2Vycm9yKCk7CiAgICB9CjwvY29kZT48L3ByZT4KCjxwPlRoZSBwcm9ibGVtIGFyaXNl
cyBoZXJlOjwvcD4KCjxwcmU+PGNvZGU+fWVsc2UgaWYgKHNlbmRfaW5mby0mZ3Q7cHJvdG89PVBS
T1RPX1dTKXsKLi4uCiAgICBjb24gPSB0Y3Bjb25uX2dldChzZW5kX2luZm8tJmd0O2lkLCAmYW1w
O2lwLCBwb3J0LCBmcm9tLCAwKQouLi4KICAgIGlmIChjb24gPT0gTlVMTCkgewogICAgICAgIExN
X1dBUk4oIlRDUC9UTFMgY29ubmVjdGlvbiAoaWQ6ICVkKSBmb3IgV2ViU29ja2V0IGNvdWxkIG5v
dCBiZSBmb3VuZFxuIiwgc2VuZF9pbmZvLSZndDtpZCk7CjwvY29kZT48L3ByZT4KCjxwPlRoZSBO
VUxMIGZhaWx1cmUgc3RhdHVzIGdldHMgcmV0dXJuZWQgdXAgdG8gPGNvZGU+cHJlcGFyZV9uZXdf
dWFjPC9jb2RlPiBpbiA8Y29kZT50X2Z3ZC5jPC9jb2RlPjo8L3A+Cgo8cHJlPjxjb2RlPiAgICBz
aGJ1Zj1idWlsZF9yZXFfYnVmX2Zyb21fc2lwX3JlcSggaV9yZXEsICZhbXA7bGVuLCBkc3QsIEJV
SUxEX0lOX1NITSk7CiAgICBpZiAoIXNoYnVmKSB7CiAgICAgICAgICAgIExNX0VSUigiY291bGQg
bm90IGJ1aWxkIHJlcXVlc3RcbiIpOwogICAgICAgICAgICByZXQ9RV9PVVRfT0ZfTUVNOwogICAg
ICAgICAgICBnb3RvIGVycm9yMDE7CiAgICB9CjwvY29kZT48L3ByZT4KCjxwPkF0IHRoaXMgcG9p
bnQsIHNlcl9lcnJvciB3aWxsIGJlY29tZSA8Y29kZT5FX09VVF9PRl9NRU08L2NvZGU+IHdoaWxl
IGl0IHNob3VsZCBiZSBzb21ldGhpbmcgbGlrZSA8Y29kZT5FX1NFTkQ8L2NvZGU+LjwvcD4KCjxw
PkFuZCA8Y29kZT5FX09VVF9PRl9NRU08L2NvZGU+IGdldHMgdHJhbnNsYXRlZCB0byA8Y29kZT41
MDAgTm8gRXJyb3I8L2NvZGU+IGJlY2F1c2Ugd2UncmUgbm90IHJ1bm5pbmcgaW4gREVCVUcgbW9k
ZS48L3A+Cgo8cD5XaGF0IGNhdXNlcyB0aGUgY29ubmVjdGlvbiB0byBkcm9wIGluIHRoZSBmaXJz
dCBwbGFjZSwgeW91IGFzaz88L3A+Cgo8cHJlPjxjb2RlPjE4OjEwOjE4LjY5MDczOCBJUCAyMTcu
MTIwLngueC41NTM4NiAmZ3Q7IDE5NS4zNS54LnguNDQzOiBGbGFncyBbU10sIHNlcSAxMzIzOTgz
MjQwLCB3aW4gODE5Miwgb3B0aW9ucyBbbXNzIDE0NjAsbm9wLHdzY2FsZSA4LG5vcCxub3Asc2Fj
a09LXSwgbGVuZ3RoIDAKMTg6MTA6MTguNjkwODYzIElQIDE5NS4zNS54LnguNDQzICZndDsgMjE3
LjEyMC54LnguNTUzODY6IEZsYWdzIFtTLl0sIHNlcSA0MDc3NzYxNzgxLCBhY2sgMTMyMzk4MzI0
MSwgd2luIDE0NjAwLCBvcHRpb25zIFttc3MgMTQ2MCxub3Asbm9wLHNhY2tPSyxub3Asd3NjYWxl
IDNdLCBsZW5ndGggMAoxODoxMDoxOC43MTA4NDYgSVAgMjE3LjEyMC54LnguNTUzODYgJmd0OyAx
OTUuMzUueC54LjQ0MzogRmxhZ3MgWy5dLCBhY2sgMSwgd2luIDI1NiwgbGVuZ3RoIDAKMTg6MTA6
MTguODA4NzUxIElQIDIxNy4xMjAueC54LjU1Mzg2ICZndDsgMTk1LjM1LngueC40NDM6IEZsYWdz
IFtQLl0sIHNlcSAxOjI0NiwgYWNrIDEsIHdpbiAyNTYsIGxlbmd0aCAyNDUKLi4uCjE4OjEwOjE5
LjIzMzQxNSBJUCAxOTUuMzUueC54LjQ0MyAmZ3Q7IDIxNy4xMjAueC54LjU1Mzg2OiBGbGFncyBb
Ll0sIGFjayAzMTM0OCwgd2luIDUxMjYsIGxlbmd0aCAwCjE4OjEwOjI2LjQ4OTc2NCBJUCAyMTcu
MTIwLngueC41NTM4NiAmZ3Q7IDE5NS4zNS54LnguNDQzOiBGbGFncyBbUC5dLCBzZXEgMzEzNDg6
MzI0NzMsIGFjayAzNDU3OCwgd2luIDI1NSwgbGVuZ3RoIDExMjUKLi4uCjE4OjEwOjI2LjUwMTQw
OSBJUCAxOTUuMzUueC54LjQ0MyAmZ3Q7IDIxNy4xMjAueC54LjU1Mzg2OiBGbGFncyBbUC5dLCBz
ZXEgNDIyNTU6NDI5MTYsIGFjayA0NjAxMCwgd2luIDUwNDYsIGxlbmd0aCA2NjEKMTg6MTA6MjYu
NTI3NzU1IElQIDIxNy4xMjAueC54LjU1Mzg2ICZndDsgMTk1LjM1LngueC40NDM6IEZsYWdzIFsu
XSwgYWNrIDM2OTkzLCB3aW4gMjUyLCBsZW5ndGggMAoxODoxMDoyNi41Mjc4NjAgSVAgMTk1LjM1
LngueC40NDMgJmd0OyAyMTcuMTIwLngueC41NTM4NjogRmxhZ3MgWy5dLCBzZXEgNDI5MTY6NDcy
OTYsIGFjayA0NjAxMCwgd2luIDUyNzgsIGxlbmd0aCA0MzgwCjE4OjEwOjI2LjUyNzg4OCBJUCAx
OTUuMzUueC54LjQ0MyAmZ3Q7IDIxNy4xMjAueC54LjU1Mzg2OiBGbGFncyBbRlAuXSwgc2VxIDQ3
Mjk2OjQ4NjYzLCBhY2sgNDYwMTAsIHdpbiA1Mjc4LCBsZW5ndGggMTM2NwoxODoxMDoyNi41Mjkx
NzkgSVAgMjE3LjEyMC54LnguNTUzODYgJmd0OyAxOTUuMzUueC54LjQ0MzogRmxhZ3MgWy5dLCBh
Y2sgNDA1MDEsIHdpbiAyNTQsIGxlbmd0aCAwCjE4OjEwOjI2LjUyOTIwMCBJUCAyMTcuMTIwLngu
eC41NTM4NiAmZ3Q7IDE5NS4zNS54LnguNDQzOiBGbGFncyBbLl0sIGFjayA0MjkxNiwgd2luIDI1
MSwgbGVuZ3RoIDAKMTg6MTA6MjYuNTQ3Mjc2IElQIDIxNy4xMjAueC54LjU1Mzg2ICZndDsgMTk1
LjM1LngueC40NDM6IEZsYWdzIFsuXSwgYWNrIDQ4NjY0LCB3aW4gMjUxLCBsZW5ndGggMAoxODox
MDoyNi41NDk3MTIgSVAgMjE3LjEyMC54LnguNTUzODYgJmd0OyAxOTUuMzUueC54LjQ0MzogRmxh
Z3MgW0YuXSwgc2VxIDQ2MDEwLCBhY2sgNDg2NjQsIHdpbiAyNTEsIGxlbmd0aCAwCjE4OjEwOjI2
LjU0OTc1MCBJUCAxOTUuMzUueC54LjQ0MyAmZ3Q7IDIxNy4xMjAueC54LjU1Mzg2OiBGbGFncyBb
Ll0sIGFjayA0NjAxMSwgd2luIDUyNzgsIGxlbmd0aCAwCjwvY29kZT48L3ByZT4KCjxwPldoZXJl
IHlvdSBzZWUgdGhhdCB0aGUgRklOIGlzIGluaXRpYXRlZCBieSA8Y29kZT4xOTUuMzUueC54PC9j
b2RlPiB3aGljaCBpcyB0aGUgS2FtYWlsaW8gd2Vic29ja2V0IHNlcnZlci48L3A+Cgo8cD5UaGUg
Y2F1c2UgKHByb2JhYmx5KSBpcyB0aGUgV1MgY2xpZW50IGNsb3NpbmcgdGhlIGNvbm5lY3Rpb24u
IEluIHRoaXMgY2FzZSBhZnRlciByZS1zdWJzY3JpYmluZyB3aXRoIEV4cGlyZXM6MC4gVGhlIHBy
ZXNlbmNlIHNlcnZlciBhdHRlbXB0cyB0byByZXBseSB3aXRoIGEgYnVuY2ggb2YgTk9USUZZcyB3
aXRoIDxjb2RlPlN1YnNjcmlwdGlvbi1TdGF0ZTogdGVybWluYXRlZDtyZWFzb249dGltZW91dDwv
Y29kZT4gYnV0IHRoZXkgYm91bmNlIG9uIHRoZSBicm9rZW4gY29ubmVjdGlvbi4gSWYgS2FtYWls
aW8gd291bGQgcmV0dXJuIGEgbmljZSAiNDc3IFVuZm9ydHVuYXRlbHkgZXJyb3Igb24gc2VuZGlu
ZyB0byBuZXh0IGhvcCBvY2N1cnJlZCIgaXQnZCBiZSBwcmV0dGllci48L3A+Cgo8cD5HZXR0aW5n
IGxlc3MgImVycm9yIiBtZXNzYWdlcyAoYSB0b3RhbCBvZiA2IDxlbT5wZXI8L2VtPiBleHBpcmVk
L3Vuc3Vic2NyaWJlZCBzdWJzY3JpcHRpb24pIGFmdGVyIHRoaXMgZXJyb3IgLS13aGljaCBpcyBh
cHBhcmVudGx5IHZlcnkgY29tbW9uIC0tIHdvdWxkIGJlIGJlbmVmaWNpYWwgdG9vLjwvcD4KCjxw
PkFzIGZvciBmaXhpbmc6PC9wPgoKPHVsIGNsYXNzPSJ0YXNrLWxpc3QiPgo8bGk+V2UgY291bGQg
Y2hhbmdlIHRoZSA8Y29kZT52aWFfYnVpbGRlcjwvY29kZT4gdG8gc2V0IDxjb2RlPnNlcl9lcnJv
cjwvY29kZT4gKGFuZCBjaGVjayB0aGF0IGluIDxjb2RlPmJ1aWxkX3JlcV9idWZfZnJvbV9zaXBf
cmVxPC9jb2RlPiksIG9yPC9saT4KPGxpPmFkZCBlcnJvci1jb2RlLW91dC1wYXJhbWV0ZXJzIHRv
IGFsbCBjYWxscyBmcm9tIDxjb2RlPmJ1aWxkX3JlcV9idWZfZnJvbV9zaXBfcmVxPC9jb2RlPiBh
bmQgZG93bi4KSSdtIG5vdCBzdXJlIGlmIGVpdGhlciBpcyB0aGUgYmVzdCB3YXkuPC9saT4KPC91
bD4KCjxwPkFzIGZvciB0aGUgZXhjZXNzaXZlIGVycm9yIHJlcG9ydGluZywgd291bGQgbG9va2lu
ZyBhdCA8Y29kZT5zZXJfZXJyb3I8L2NvZGU+IGJlZm9yZSBwcmludGluZyAoYW5vdGhlcikgZXJy
b3IgYmUgYW4gYWNjZXB0YWJsZSBmaXg/PC9wPgoKPHA+Q2hlZXJzLDxicj4KV2FsdGVyIERvZWtl
czxicj4KT1NTTyBCLlYuPC9wPgoKPHAgc3R5bGU9ImZvbnQtc2l6ZTpzbWFsbDstd2Via2l0LXRl
eHQtc2l6ZS1hZGp1c3Q6bm9uZTtjb2xvcjojNjY2OyI+Jm1kYXNoOzxicj5SZXBseSB0byB0aGlz
IGVtYWlsIGRpcmVjdGx5IG9yIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9r
YW1haWxpby9pc3N1ZXMvNDciPnZpZXcgaXQgb24gR2l0SHViPC9hPi48aW1nIGFsdD0iIiBoZWln
aHQ9IjEiIHNyYz0iaHR0cHM6Ly9naXRodWIuY29tL25vdGlmaWNhdGlvbnMvYmVhY29uL0FGMzZa
UjVDY2otLV9kSnVtM2lBaThwSmtUVVZsZzMya3M1bmpQLVdnYUpwWk00RFVKR3MuZ2lmIiB3aWR0
aD0iMSIgLz48L3A+CjxkaXYgaXRlbXNjb3BlIGl0ZW10eXBlPSJodHRwOi8vc2NoZW1hLm9yZy9F
bWFpbE1lc3NhZ2UiPgogIDxkaXYgaXRlbXByb3A9ImFjdGlvbiIgaXRlbXNjb3BlIGl0ZW10eXBl
PSJodHRwOi8vc2NoZW1hLm9yZy9WaWV3QWN0aW9uIj4KICAgIDxsaW5rIGl0ZW1wcm9wPSJ1cmwi
IGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9pc3N1ZXMvNDciPjwv
bGluaz4KICAgIDxtZXRhIGl0ZW1wcm9wPSJuYW1lIiBjb250ZW50PSJWaWV3IElzc3VlIj48L21l
dGE+CiAgPC9kaXY+CiAgPG1ldGEgaXRlbXByb3A9ImRlc2NyaXB0aW9uIiBjb250ZW50PSJWaWV3
IHRoaXMgSXNzdWUgb24gR2l0SHViIj48L21ldGE+CjwvZGl2Pgo=

--===============0730433579==--


From notifications@github.com Fri Jan 23 10:40:53 2015
From: Daniel-Constantin Mierla <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio] websocket: `tcpconn_get()` error gets turned
 into `E_OUT_OF_MEM` which becomes "500 No Error" (#47)
Date: Fri, 23 Jan 2015 01:40:46 -0800
Message-ID: <kamailio/kamailio/issues/47/71169069@github.com>
In-Reply-To: <kamailio/kamailio/issues/47@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1806632259=="

--===============1806632259==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

What version are you using? The lines reported in logs are not matching lates=
t 4.2 or master branches.

Using ser_error should work to differentiate on what happened inside via_buil=
der() is ok. You can make a patch for that and if works for you, submit it he=
re.

Not sure I get how you would protect with ser_error against excessive logging=
, but perhaps when I see the code it will be more clear. Make this a second p=
atch to be reviewed separately, allowing the first to be merged without depen=
dency on this one.

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/47#issuecomment-71169069



--===============1806632259==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+V2hhdCB2ZXJzaW9uIGFyZSB5b3UgdXNpbmc/IFRoZSBsaW5lcyByZXBvcnRlZCBpbiBsb2dz
IGFyZSBub3QgbWF0Y2hpbmcgbGF0ZXN0IDQuMiBvciBtYXN0ZXIgYnJhbmNoZXMuPC9wPgoKPHA+
VXNpbmcgc2VyX2Vycm9yIHNob3VsZCB3b3JrIHRvIGRpZmZlcmVudGlhdGUgb24gd2hhdCBoYXBw
ZW5lZCBpbnNpZGUgdmlhX2J1aWxkZXIoKSBpcyBvay4gWW91IGNhbiBtYWtlIGEgcGF0Y2ggZm9y
IHRoYXQgYW5kIGlmIHdvcmtzIGZvciB5b3UsIHN1Ym1pdCBpdCBoZXJlLjwvcD4KCjxwPk5vdCBz
dXJlIEkgZ2V0IGhvdyB5b3Ugd291bGQgcHJvdGVjdCB3aXRoIHNlcl9lcnJvciBhZ2FpbnN0IGV4
Y2Vzc2l2ZSBsb2dnaW5nLCBidXQgcGVyaGFwcyB3aGVuIEkgc2VlIHRoZSBjb2RlIGl0IHdpbGwg
YmUgbW9yZSBjbGVhci4gTWFrZSB0aGlzIGEgc2Vjb25kIHBhdGNoIHRvIGJlIHJldmlld2VkIHNl
cGFyYXRlbHksIGFsbG93aW5nIHRoZSBmaXJzdCB0byBiZSBtZXJnZWQgd2l0aG91dCBkZXBlbmRl
bmN5IG9uIHRoaXMgb25lLjwvcD4KCjxwIHN0eWxlPSJmb250LXNpemU6c21hbGw7LXdlYmtpdC10
ZXh0LXNpemUtYWRqdXN0Om5vbmU7Y29sb3I6IzY2NjsiPiZtZGFzaDs8YnI+UmVwbHkgdG8gdGhp
cyBlbWFpbCBkaXJlY3RseSBvciA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8v
a2FtYWlsaW8vaXNzdWVzLzQ3I2lzc3VlY29tbWVudC03MTE2OTA2OSI+dmlldyBpdCBvbiBHaXRI
dWI8L2E+LjxpbWcgYWx0PSIiIGhlaWdodD0iMSIgc3JjPSJodHRwczovL2dpdGh1Yi5jb20vbm90
aWZpY2F0aW9ucy9iZWFjb24vQUYzNlphYVpJY1JadG03M0NjdzlYRDVKeUxNR3VVM1NrczVua2c2
ZWdhSnBaTTREVUpHcy5naWYiIHdpZHRoPSIxIiAvPjwvcD4KPGRpdiBpdGVtc2NvcGUgaXRlbXR5
cGU9Imh0dHA6Ly9zY2hlbWEub3JnL0VtYWlsTWVzc2FnZSI+CiAgPGRpdiBpdGVtcHJvcD0iYWN0
aW9uIiBpdGVtc2NvcGUgaXRlbXR5cGU9Imh0dHA6Ly9zY2hlbWEub3JnL1ZpZXdBY3Rpb24iPgog
ICAgPGxpbmsgaXRlbXByb3A9InVybCIgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlv
L2thbWFpbGlvL2lzc3Vlcy80NyNpc3N1ZWNvbW1lbnQtNzExNjkwNjkiPjwvbGluaz4KICAgIDxt
ZXRhIGl0ZW1wcm9wPSJuYW1lIiBjb250ZW50PSJWaWV3IElzc3VlIj48L21ldGE+CiAgPC9kaXY+
CiAgPG1ldGEgaXRlbXByb3A9ImRlc2NyaXB0aW9uIiBjb250ZW50PSJWaWV3IHRoaXMgSXNzdWUg
b24gR2l0SHViIj48L21ldGE+CjwvZGl2Pgo=

--===============1806632259==--


From notifications@github.com Fri Jan 23 16:12:46 2015
From: Walter Doekes <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio] websocket: `tcpconn_get()` error gets turned
 into `E_OUT_OF_MEM` which becomes "500 No Error" (#47)
Date: Fri, 23 Jan 2015 07:12:37 -0800
Message-ID: <kamailio/kamailio/issues/47/71206932@github.com>
In-Reply-To: <kamailio/kamailio/issues/47@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1751755555=="

--===============1751755555==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

That's a 4.1.6 (patched with #26), but I believe I checked master when lookin=
g into the source why this happens.

Thanks for the feedback. Now I'll "just" have to reliably reproduce this firs=
t :)

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/47#issuecomment-71206932



--===============1751755555==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+VGhhdCdzIGEgNC4xLjYgKHBhdGNoZWQgd2l0aCA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5j
b20va2FtYWlsaW8va2FtYWlsaW8vcHVsbC8yNiIgY2xhc3M9Imlzc3VlLWxpbmsiIHRpdGxlPSJ3
ZWJzb2NrZXQ6IENoZWNrIGZyYW1lLSZndDt3c2MgaW4gd3NfZnJhbWVfdHJhbnNtaXQgZm9yIE5V
TEwuIj4jMjY8L2E+KSwgYnV0IEkgYmVsaWV2ZSBJIGNoZWNrZWQgbWFzdGVyIHdoZW4gbG9va2lu
ZyBpbnRvIHRoZSBzb3VyY2Ugd2h5IHRoaXMgaGFwcGVucy48L3A+Cgo8cD5UaGFua3MgZm9yIHRo
ZSBmZWVkYmFjay4gTm93IEknbGwgImp1c3QiIGhhdmUgdG8gcmVsaWFibHkgcmVwcm9kdWNlIHRo
aXMgZmlyc3QgOik8L3A+Cgo8cCBzdHlsZT0iZm9udC1zaXplOnNtYWxsOy13ZWJraXQtdGV4dC1z
aXplLWFkanVzdDpub25lO2NvbG9yOiM2NjY7Ij4mbWRhc2g7PGJyPlJlcGx5IHRvIHRoaXMgZW1h
aWwgZGlyZWN0bHkgb3IgPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFp
bGlvL2lzc3Vlcy80NyNpc3N1ZWNvbW1lbnQtNzEyMDY5MzIiPnZpZXcgaXQgb24gR2l0SHViPC9h
Pi48aW1nIGFsdD0iIiBoZWlnaHQ9IjEiIHNyYz0iaHR0cHM6Ly9naXRodWIuY29tL25vdGlmaWNh
dGlvbnMvYmVhY29uL0FGMzZaUUNnQWc1YTR1akNQWWhVeTBhOGQ1S3l2cndaa3M1bmtseGxnYUpw
Wk00RFVKR3MuZ2lmIiB3aWR0aD0iMSIgLz48L3A+CjxkaXYgaXRlbXNjb3BlIGl0ZW10eXBlPSJo
dHRwOi8vc2NoZW1hLm9yZy9FbWFpbE1lc3NhZ2UiPgogIDxkaXYgaXRlbXByb3A9ImFjdGlvbiIg
aXRlbXNjb3BlIGl0ZW10eXBlPSJodHRwOi8vc2NoZW1hLm9yZy9WaWV3QWN0aW9uIj4KICAgIDxs
aW5rIGl0ZW1wcm9wPSJ1cmwiIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1h
aWxpby9pc3N1ZXMvNDcjaXNzdWVjb21tZW50LTcxMjA2OTMyIj48L2xpbms+CiAgICA8bWV0YSBp
dGVtcHJvcD0ibmFtZSIgY29udGVudD0iVmlldyBJc3N1ZSI+PC9tZXRhPgogIDwvZGl2PgogIDxt
ZXRhIGl0ZW1wcm9wPSJkZXNjcmlwdGlvbiIgY29udGVudD0iVmlldyB0aGlzIElzc3VlIG9uIEdp
dEh1YiI+PC9tZXRhPgo8L2Rpdj4K

--===============1751755555==--


From notifications@github.com Wed Apr  1 13:47:31 2015
From: Daniel-Constantin Mierla <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio] websocket: `tcpconn_get()` error gets turned
 into `E_OUT_OF_MEM` which becomes "500 No Error" (#47)
Date: Wed, 01 Apr 2015 04:47:30 -0700
Message-ID: <kamailio/kamailio/issue/47/issue_event/270539049@github.com>
In-Reply-To: <kamailio/kamailio/issues/47@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0515143833=="

--===============0515143833==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Closed #47.

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/47#event-270539049



--===============0515143833==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+Q2xvc2VkIDxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9rYW1haWxpby9rYW1haWxpby9p
c3N1ZXMvNDciIGNsYXNzPSJpc3N1ZS1saW5rIiB0aXRsZT0nd2Vic29ja2V0OiBgdGNwY29ubl9n
ZXQoKWAgZXJyb3IgZ2V0cyB0dXJuZWQgaW50byBgRV9PVVRfT0ZfTUVNYCB3aGljaCBiZWNvbWVz
ICI1MDAgTm8gRXJyb3IiJz4jNDc8L2E+LjwvcD4KCjxwIHN0eWxlPSJmb250LXNpemU6c21hbGw7
LXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0Om5vbmU7Y29sb3I6IzY2NjsiPiZtZGFzaDs8YnI+UmVw
bHkgdG8gdGhpcyBlbWFpbCBkaXJlY3RseSBvciA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20v
a2FtYWlsaW8va2FtYWlsaW8vaXNzdWVzLzQ3I2V2ZW50LTI3MDUzOTA0OSI+dmlldyBpdCBvbiBH
aXRIdWI8L2E+LjxpbWcgYWx0PSIiIGhlaWdodD0iMSIgc3JjPSJodHRwczovL2dpdGh1Yi5jb20v
bm90aWZpY2F0aW9ucy9iZWFjb24vQUYzNlpUMnd1c2F3RVFRZWFjcy1yWXR5OVlJOUQ0Q2VrczVu
NjlKU2dhSnBaTTREVUpHcy5naWYiIHdpZHRoPSIxIiAvPjwvcD4KPGRpdiBpdGVtc2NvcGUgaXRl
bXR5cGU9Imh0dHA6Ly9zY2hlbWEub3JnL0VtYWlsTWVzc2FnZSI+CiAgPGRpdiBpdGVtcHJvcD0i
YWN0aW9uIiBpdGVtc2NvcGUgaXRlbXR5cGU9Imh0dHA6Ly9zY2hlbWEub3JnL1ZpZXdBY3Rpb24i
PgogICAgPGxpbmsgaXRlbXByb3A9InVybCIgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFp
bGlvL2thbWFpbGlvL2lzc3Vlcy80NyNldmVudC0yNzA1MzkwNDkiPjwvbGluaz4KICAgIDxtZXRh
IGl0ZW1wcm9wPSJuYW1lIiBjb250ZW50PSJWaWV3IElzc3VlIj48L21ldGE+CiAgPC9kaXY+CiAg
PG1ldGEgaXRlbXByb3A9ImRlc2NyaXB0aW9uIiBjb250ZW50PSJWaWV3IHRoaXMgSXNzdWUgb24g
R2l0SHViIj48L21ldGE+CjwvZGl2Pgo=

--===============0515143833==--


From notifications@github.com Wed Apr  1 13:47:31 2015
From: Daniel-Constantin Mierla <notifications@github.com>
To: sr-dev@lists.kamailio.org
Subject: Re: [sr-dev] [kamailio] websocket: `tcpconn_get()` error gets turned
 into `E_OUT_OF_MEM` which becomes "500 No Error" (#47)
Date: Wed, 01 Apr 2015 04:47:30 -0700
Message-ID: <kamailio/kamailio/issues/47/88448636@github.com>
In-Reply-To: <kamailio/kamailio/issues/47@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1027211620=="

--===============1027211620==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Closing this one not having a follow up for two months. Open a new one whenev=
er you have new details to provide.

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/47#issuecomment-88448636



--===============1027211620==
Content-Type: text/html
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="attachment.html"
MIME-Version: 1.0

PHA+Q2xvc2luZyB0aGlzIG9uZSBub3QgaGF2aW5nIGEgZm9sbG93IHVwIGZvciB0d28gbW9udGhz
LiBPcGVuIGEgbmV3IG9uZSB3aGVuZXZlciB5b3UgaGF2ZSBuZXcgZGV0YWlscyB0byBwcm92aWRl
LjwvcD4KCjxwIHN0eWxlPSJmb250LXNpemU6c21hbGw7LXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0
Om5vbmU7Y29sb3I6IzY2NjsiPiZtZGFzaDs8YnI+UmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJlY3Rs
eSBvciA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20va2FtYWlsaW8va2FtYWlsaW8vaXNzdWVz
LzQ3I2lzc3VlY29tbWVudC04ODQ0ODYzNiI+dmlldyBpdCBvbiBHaXRIdWI8L2E+LjxpbWcgYWx0
PSIiIGhlaWdodD0iMSIgc3JjPSJodHRwczovL2dpdGh1Yi5jb20vbm90aWZpY2F0aW9ucy9iZWFj
b24vQUYzNlpUMnd1c2F3RVFRZWFjcy1yWXR5OVlJOUQ0Q2VrczVuNjlKU2dhSnBaTTREVUpHcy5n
aWYiIHdpZHRoPSIxIiAvPjwvcD4KPGRpdiBpdGVtc2NvcGUgaXRlbXR5cGU9Imh0dHA6Ly9zY2hl
bWEub3JnL0VtYWlsTWVzc2FnZSI+CiAgPGRpdiBpdGVtcHJvcD0iYWN0aW9uIiBpdGVtc2NvcGUg
aXRlbXR5cGU9Imh0dHA6Ly9zY2hlbWEub3JnL1ZpZXdBY3Rpb24iPgogICAgPGxpbmsgaXRlbXBy
b3A9InVybCIgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2thbWFpbGlvL2thbWFpbGlvL2lzc3Vl
cy80NyNpc3N1ZWNvbW1lbnQtODg0NDg2MzYiPjwvbGluaz4KICAgIDxtZXRhIGl0ZW1wcm9wPSJu
YW1lIiBjb250ZW50PSJWaWV3IElzc3VlIj48L21ldGE+CiAgPC9kaXY+CiAgPG1ldGEgaXRlbXBy
b3A9ImRlc2NyaXB0aW9uIiBjb250ZW50PSJWaWV3IHRoaXMgSXNzdWUgb24gR2l0SHViIj48L21l
dGE+CjwvZGl2Pgo=

--===============1027211620==--