From bugtracker@sip-router.org Sat May 25 13:29:52 2013
From: sip-router <bugtracker@sip-router.org>
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] [tracker] Comment added: tm:branch-failure event_route is
	not executed on all branch failures
Date: Sat, 25 May 2013 11:29:49 +0000
Message-ID: <1369481389.51a0a0adc6888@sip-router.org>
In-Reply-To: <FS296@sip-router.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1511976678=="

--===============1511976678==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#296 -  tm:branch-failure event_route is not executed on all branch failures
User who did this - Juha Heinanen (jh)

----------
unfortunately i need to reopen this task.  i started to do more tests and and=
 branch failure route execution is not deterministic.  closer examination of =
daniel's test output showed that branch failure router was not executed in th=
at test either.  attached is complete test config.  i use sipsak to send requ=
est to it like this:

sipsak -s sip:foo(a)127.0.0.1:5060

first time i got:

May 25 14:21:23 siika sip-proxy[6697]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:23 siika sip-proxy[6697]: ERROR: <script>: =3D=3D=3D=3D=3D after=
 t_newtrans()
May 25 14:21:23 siika sip-proxy[6697]: ERROR: tm [../../forward.h:216]: msg_s=
end(): msg_send: ERROR: tcp_send failed
May 25 14:21:23 siika sip-proxy[6697]: ERROR: tm [t_fwd.c:1592]: t_send_branc=
h(): ERROR: t_send_branch: sending request on branch 0 failed
May 25 14:21:23 siika sip-proxy[6697]: ERROR: tm [t_fwd.c:1595]: t_send_branc=
h(): putting branch 0 on hold=20
May 25 14:21:23 siika sip-proxy[6697]: ERROR: <script>: =3D=3D=3D=3D=3D t rel=
ay return code: 1
May 25 14:21:23 siika sip-proxy[6696]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:24 siika sip-proxy[6698]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:26 siika sip-proxy[6695]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:28 siika sip-proxy[6708]: ERROR: <script>: =3D=3D=3D=3D failure =
route block

that is, branch failure block was not executed.

second time 20 sec later i got:

May 25 14:21:44 siika sip-proxy[6694]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:44 siika sip-proxy[6694]: ERROR: <script>: =3D=3D=3D=3D=3D after=
 t_newtrans()
May 25 14:21:44 siika sip-proxy[6694]: ERROR: tm [../../forward.h:216]: msg_s=
end(): msg_send: ERROR: tcp_send failed
May 25 14:21:44 siika sip-proxy[6694]: ERROR: tm [t_fwd.c:1592]: t_send_branc=
h(): ERROR: t_send_branch: sending request on branch 0 failed
May 25 14:21:44 siika sip-proxy[6694]: ERROR: tm [t_fwd.c:1595]: t_send_branc=
h(): putting branch 0 on hold=20
May 25 14:21:44 siika sip-proxy[6694]: ERROR: <script>: =3D=3D=3D=3D=3D t rel=
ay return code: 1
May 25 14:21:45 siika sip-proxy[6693]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:46 siika sip-proxy[6692]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:48 siika sip-proxy[6691]: ERROR: <script>: =3D=3D=3D=3D=3D main =
route block
May 25 14:21:49 siika sip-proxy[6708]: ERROR: <script>: =3D=3D=3D=3D branch f=
ailure route block
May 25 14:21:49 siika sip-proxy[6708]: ERROR: <script>: =3D=3D=3D=3D failure =
route block

that is, branch failure route block was executed.

-- juha

complete config used in test:

loadmodule "pv"
loadmodule "xlog"

modparam("tm", "fr_timer", 5000)
modparam("tm", "local_ack_mode", 2)
modparam("tm", "failure_reply_mode", 3)
modparam("tm", "failure_exec_mode", 1)

route {
xlog("=3D=3D=3D=3D=3D main route block\n");
t_newtran();
xlog("=3D=3D=3D=3D=3D after t_newtrans()\n");
$ru =3D "sip:foo(a)127.0.0.1:9;transport=3Dtcp";
t_on_failure("x");
t_on_branch_failure("x");
set_forward_no_connect();
t_relay();
$var(rc) =3D $rc;
xlog("=3D=3D=3D=3D=3D t relay return code: $rc\n");
exit;
}

failure_route[x] {
xlog("=3D=3D=3D=3D failure route block\n");
exit;
}

event_route[tm:branch-failure:x] {
xlog("=3D=3D=3D=3D branch failure route block\n");
}


----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=3Ddetails&task_id=3D296#comment892

You are receiving this message because you have requested it from the Flyspra=
y bugtracking system.  If you did not expect this message or don't want to re=
ceive mails in future, you can change your notification settings at the URL s=
hown above.


--===============1511976678==--