sr-dev March 2026

sr-dev@lists.kamailio.org

35 participants
467 discussions

git:6.0:a738a715: ims_ocs: Add memory check
by Xenofon Karamanos 31 Mar '26

31 Mar '26

Module: kamailio Branch: 6.0 Commit: a738a715e6988f121a8a13c3baa92a63546b9e22 URL: https://github.com/kamailio/kamailio/commit/a738a715e6988f121a8a13c3baa92a6… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2026-03-31T16:53:30Z ims_ocs: Add memory check (cherry picked from commit 53b47f5be5961dfca0142c74d549f7de5ce768b8) --- Modified: src/modules/ims_ocs/ims_ocs_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a738a715e6988f121a8a13c3baa92a6… Patch: https://github.com/kamailio/kamailio/commit/a738a715e6988f121a8a13c3baa92a6… --- diff --git a/src/modules/ims_ocs/ims_ocs_mod.c b/src/modules/ims_ocs/ims_ocs_mod.c index d8aed134762..44aa77ea56c 100644 --- a/src/modules/ims_ocs/ims_ocs_mod.c +++ b/src/modules/ims_ocs/ims_ocs_mod.c @@ -96,6 +96,10 @@ static int mod_init(void) callback_singleton = shm_malloc(sizeof(int)); + if(callback_singleton == 0) { + LM_ERR("No shared memory left\n"); + goto error; + } *callback_singleton = 0; cdp_avp = 0; @@ -113,6 +117,10 @@ static int mod_init(void) return 0; error: + /* clean up */ + if(callback_singleton) { + shm_free(callback_singleton); + } LM_ERR("Failed to initialise ims_ocs module\n"); return -1; }

1 0

git:6.0:476258a1: ims_ocs: Free after copying the values
by Xenofon Karamanos 31 Mar '26

31 Mar '26

Module: kamailio Branch: 6.0 Commit: 476258a122b42e67deece356238238a3b022ceef URL: https://github.com/kamailio/kamailio/commit/476258a122b42e67deece356238238a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2026-03-31T16:53:30Z ims_ocs: Free after copying the values - Remove extra freeavplist call - Add len check (cherry picked from commit a56942affd35d41890c23f1d3b5bb519f87ef5ad) --- Modified: src/modules/ims_ocs/ocs_avp_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/476258a122b42e67deece356238238a… Patch: https://github.com/kamailio/kamailio/commit/476258a122b42e67deece356238238a… --- diff --git a/src/modules/ims_ocs/ocs_avp_helper.c b/src/modules/ims_ocs/ocs_avp_helper.c index f350a79a12b..378b2a209bc 100644 --- a/src/modules/ims_ocs/ocs_avp_helper.c +++ b/src/modules/ims_ocs/ocs_avp_helper.c @@ -208,8 +208,7 @@ int getUnits(AAAMessage *msg, int *used, int *service, int *group) list2 = cdp_avp->cdp->AAAUngroupAVPS(req_units->data); value = cdpb.AAAFindMatchingAVPList( list2, list2.head, AVP_CC_Time, 0, 0); - cdpb.AAAFreeAVPList(&list2); - if(value) + if(value && value->data.len >= 4) units = get_4bytes(value->data.s); cdpb.AAAFreeAVPList(&list2); }

1 0

git:5.8:9527d0bf: ims_ocs: Fix typos in comments
by Xenofon Karamanos 31 Mar '26

31 Mar '26

Module: kamailio Branch: 5.8 Commit: 9527d0bfb52127a2ec6b9d8aaa4794fdcf133f67 URL: https://github.com/kamailio/kamailio/commit/9527d0bfb52127a2ec6b9d8aaa4794f… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2026-03-31T16:53:01Z ims_ocs: Fix typos in comments (cherry picked from commit 0eb01e0515c84314b0b7e334b348b331afeaf233) --- Modified: src/modules/ims_ocs/ocs_avp_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/9527d0bfb52127a2ec6b9d8aaa4794f… Patch: https://github.com/kamailio/kamailio/commit/9527d0bfb52127a2ec6b9d8aaa4794f… --- diff --git a/src/modules/ims_ocs/ocs_avp_helper.c b/src/modules/ims_ocs/ocs_avp_helper.c index fbefea83d8f..5f88f76c21a 100644 --- a/src/modules/ims_ocs/ocs_avp_helper.c +++ b/src/modules/ims_ocs/ocs_avp_helper.c @@ -27,9 +27,9 @@ /** * Returns the value of a certain AVP from a Diameter message. - * @param m - Diameter message to look into + * @param msg - Diameter message to look into * @param avp_code - the code to search for - * @param vendorid - the value of the vendor id to look for or 0 if none + * @param vendor_id - the value of the vendor id to look for or 0 if none * @param func - the name of the calling function, for debugging purposes * @returns the str with the payload on success or an empty string on failure */

1 0

git:5.8:6bf1abc4: ims_ocs: Add memory check
by Xenofon Karamanos 31 Mar '26

31 Mar '26

Module: kamailio Branch: 5.8 Commit: 6bf1abc4b9fa4f923f0800483b21e5583120dc2a URL: https://github.com/kamailio/kamailio/commit/6bf1abc4b9fa4f923f0800483b21e55… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2026-03-31T16:53:01Z ims_ocs: Add memory check (cherry picked from commit 53b47f5be5961dfca0142c74d549f7de5ce768b8) --- Modified: src/modules/ims_ocs/ims_ocs_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/6bf1abc4b9fa4f923f0800483b21e55… Patch: https://github.com/kamailio/kamailio/commit/6bf1abc4b9fa4f923f0800483b21e55… --- diff --git a/src/modules/ims_ocs/ims_ocs_mod.c b/src/modules/ims_ocs/ims_ocs_mod.c index 3ee4e4ab485..e3c5b3328a9 100644 --- a/src/modules/ims_ocs/ims_ocs_mod.c +++ b/src/modules/ims_ocs/ims_ocs_mod.c @@ -91,6 +91,10 @@ static int mod_init(void) callback_singleton = shm_malloc(sizeof(int)); + if(callback_singleton == 0) { + LM_ERR("No shared memory left\n"); + goto error; + } *callback_singleton = 0; cdp_avp = 0; @@ -108,6 +112,10 @@ static int mod_init(void) return 0; error: + /* clean up */ + if(callback_singleton) { + shm_free(callback_singleton); + } LM_ERR("Failed to initialise ims_ocs module\n"); return -1; }

1 0

git:5.8:20758c4c: ims_ocs: Free after copying the values
by Xenofon Karamanos 31 Mar '26

31 Mar '26

Module: kamailio Branch: 5.8 Commit: 20758c4cda8506c47ea85b85bf3644f0bacd0123 URL: https://github.com/kamailio/kamailio/commit/20758c4cda8506c47ea85b85bf3644f… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2026-03-31T16:53:01Z ims_ocs: Free after copying the values - Remove extra freeavplist call - Add len check (cherry picked from commit a56942affd35d41890c23f1d3b5bb519f87ef5ad) --- Modified: src/modules/ims_ocs/ocs_avp_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/20758c4cda8506c47ea85b85bf3644f… Patch: https://github.com/kamailio/kamailio/commit/20758c4cda8506c47ea85b85bf3644f… --- diff --git a/src/modules/ims_ocs/ocs_avp_helper.c b/src/modules/ims_ocs/ocs_avp_helper.c index 3fdde977f44..fbefea83d8f 100644 --- a/src/modules/ims_ocs/ocs_avp_helper.c +++ b/src/modules/ims_ocs/ocs_avp_helper.c @@ -206,8 +206,7 @@ int getUnits(AAAMessage *msg, int *used, int *service, int *group) list2 = cdp_avp->cdp->AAAUngroupAVPS(req_units->data); value = cdpb.AAAFindMatchingAVPList( list2, list2.head, AVP_CC_Time, 0, 0); - cdpb.AAAFreeAVPList(&list2); - if(value) + if(value && value->data.len >= 4) units = get_4bytes(value->data.s); cdpb.AAAFreeAVPList(&list2); }

1 0

git:master:3609b9d7: etc/kamailio.cfg: added checks for msg and r-uri size
by Daniel-Constantin Mierla 31 Mar '26

31 Mar '26

Module: kamailio Branch: master Commit: 3609b9d7005cfbf23bf9d79ba3e830aa804d03cf URL: https://github.com/kamailio/kamailio/commit/3609b9d7005cfbf23bf9d79ba3e830a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2026-03-31T17:42:11+02:00 etc/kamailio.cfg: added checks for msg and r-uri size - message up to 16384 and r-uri up to 512 bytes - discard quickly the messages that are too large for a typical UA, avoid extra processing to discover later UA is not valid (e.g., by auth) --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/3609b9d7005cfbf23bf9d79ba3e830a… Patch: https://github.com/kamailio/kamailio/commit/3609b9d7005cfbf23bf9d79ba3e830a… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index da204e82247..5cde0a6ea20 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -168,6 +168,10 @@ import_file "kamailio-local.cfg" #!define FLB_NATB 6 #!define FLB_NATSIPPING 7 +# - values +#!trydef MSG_MAX_SIZE 16384 +#!trydef RURI_MAX_SIZE 512 + ####### Global Parameters ######### /* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */ @@ -670,6 +674,14 @@ route[REQINIT] { # sl_send_reply("200", "OK"); exit; } + if($msg(len) > MSG_MAX_SIZE) { + sl_send_reply("403", "Message too large"); + exit; + } + if($(ru{s.len}) > RURI_MAX_SIZE) { + sl_send_reply("403", "R-URI too large"); + exit; + } if (!mf_process_maxfwd_header("10")) { sl_send_reply("483", "Too Many Hops"); @@ -1065,6 +1077,10 @@ reply_route { xlog("Malformed SIP response from $si:$sp\n"); drop; } + if($msg(len) > MSG_MAX_SIZE) { + drop; + } + return; }

1 0

git:master:9e1d97dd: modules: readme files regenerated - tls_wolfssl ... [skip ci]
by Kamailio Dev 31 Mar '26

31 Mar '26

Module: kamailio Branch: master Commit: 9e1d97dd3f0b4515195554b432660cc3f3d17821 URL: https://github.com/kamailio/kamailio/commit/9e1d97dd3f0b4515195554b432660cc… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2026-03-31T16:46:10+02:00 modules: readme files regenerated - tls_wolfssl ... [skip ci] --- Modified: src/modules/tls_wolfssl/README --- Diff: https://github.com/kamailio/kamailio/commit/9e1d97dd3f0b4515195554b432660cc… Patch: https://github.com/kamailio/kamailio/commit/9e1d97dd3f0b4515195554b432660cc… --- diff --git a/src/modules/tls_wolfssl/README b/src/modules/tls_wolfssl/README index 88bd5196a4d..299085d591e 100644 --- a/src/modules/tls_wolfssl/README +++ b/src/modules/tls_wolfssl/README @@ -38,9 +38,9 @@ Chapter 1. Admin Guide 1. Overview This module implements the TLS transport for Kamailio using the wolfSSL - library (https://www.wolfssl.com). To enable the Kamailio TLS support - this module must be loaded and enable_tls=yes core setting must be - added to the Kamailio config file. + library (https://www.wolfssl.com). To enable it, the module must be + configured and loaded and the enable_tls=yes core setting must set. + This module is mutually exclusive with the tls module. Is is highly recommended to run this module with MT-mode (tcp_main_threads = 1). @@ -48,7 +48,7 @@ Chapter 1. Admin Guide This module is derived from the tls module and adapted to wolfSSL. Credit goes to the authors of the tls module. - This module build from wolfSSl 5.2.0 onwards. There is a git submodule + This module builds from wolfSSl 5.2.0 onwards. There is a git submodule that contains a recent version of wolfSSL for easier building. This user is referred to the documentation of the tls module for @@ -71,7 +71,7 @@ Chapter 1. Admin Guide 3. Important Notes The wolfSSL TLS module is intended to be compiled with a recent version - of wolfSSL (5.2.0+). + of wolfSSL - 5.8.4+ is recommended. Kamailio shared memory allocators, used in MP-mode(tcp_main_threads = 0), support 16-byte alignment - it is possible to use this module with @@ -101,12 +101,12 @@ ble-pkcs11 5. Support for externalized keys (PKCS#11) - The module now supports loading a key from PKCS#11. MT-mode is required - for this functionality. The key naming convention follows a PKCS#11-URI - style: + The module now supports loading keys from PKCS#11 and up to 4 tokens + are supported. This feature is available in both MT- and MP- modes. The + key naming convention for keys follows a PKCS#11-URI-like style: ... -# in tls.cfg these pseudo-file names to refer to PKCS#11 keys -# MUST run in MT-mode +# in tls.cfg these pseudo-file names to refer to PKCS#11 keys; this format +# is not conformant to RFC 7512 private_key = /uri:pkcs11:module=/usr/lib64/libsoftokn3.so;token=MyToken;object= MyPrivateKey;pin=12345678

1 0

git:master:ecfee2ff: tls_wolfssl: optimizations and implement PKCS#11 in MP-mode
by S-P Chan 31 Mar '26

31 Mar '26

Module: kamailio Branch: master Commit: ecfee2ffde8e1e30f7ae36b5ab052a5cad259db0 URL: https://github.com/kamailio/kamailio/commit/ecfee2ffde8e1e30f7ae36b5ab052a5… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2026-03-31T22:32:47+08:00 tls_wolfssl: optimizations and implement PKCS#11 in MP-mode - MT-mode: wolfSSL by default has a limit of 8 Pkcs11Token(s); allocate one devId per module/token and mediate access with a mutex - MP mode: add support for PKCS#11 keys --- Modified: src/modules/tls_wolfssl/doc/tls_wolfssl.xml Modified: src/modules/tls_wolfssl/tls_domain.c Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c Modified: src/modules/tls_wolfssl/wolfssl_pkcs11.c --- Diff: https://github.com/kamailio/kamailio/commit/ecfee2ffde8e1e30f7ae36b5ab052a5… Patch: https://github.com/kamailio/kamailio/commit/ecfee2ffde8e1e30f7ae36b5ab052a5…

1 0

[kamailio/kamailio] Ims ocs checks (PR #4675)
by Xenofon Karamanos 31 Mar '26

31 Mar '26

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  1. First copy the value data and then free the avp (there was an extra free avp) 2. Add memory check for shm_malloc 3. Fix comments to match parameters You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4675?email_source=notifications&a… -- Commit Summary -- * ims_ocs: Free after copying the values * ims_ocs: Add memory check * ims_ocs: Fix typos in comments -- File Changes -- M src/modules/ims_ocs/ims_ocs_mod.c (8) M src/modules/ims_ocs/ocs_avp_helper.c (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4675.patch?email_source=notificat… -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4675 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4675(a)github.com>

2 1

git:master:0eb01e05: ims_ocs: Fix typos in comments
by Victor Seva 31 Mar '26

31 Mar '26

Module: kamailio Branch: master Commit: 0eb01e0515c84314b0b7e334b348b331afeaf233 URL: https://github.com/kamailio/kamailio/commit/0eb01e0515c84314b0b7e334b348b33… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2026-03-31T14:22:17+02:00 ims_ocs: Fix typos in comments --- Modified: src/modules/ims_ocs/ocs_avp_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/0eb01e0515c84314b0b7e334b348b33… Patch: https://github.com/kamailio/kamailio/commit/0eb01e0515c84314b0b7e334b348b33… --- diff --git a/src/modules/ims_ocs/ocs_avp_helper.c b/src/modules/ims_ocs/ocs_avp_helper.c index 378b2a209bc..18b143a60ad 100644 --- a/src/modules/ims_ocs/ocs_avp_helper.c +++ b/src/modules/ims_ocs/ocs_avp_helper.c @@ -29,9 +29,9 @@ /** * Returns the value of a certain AVP from a Diameter message. - * @param m - Diameter message to look into + * @param msg - Diameter message to look into * @param avp_code - the code to search for - * @param vendorid - the value of the vendor id to look for or 0 if none + * @param vendor_id - the value of the vendor id to look for or 0 if none * @param func - the name of the calling function, for debugging purposes * @returns the str with the payload on success or an empty string on failure */

1 0

← Newer
1
2
3
4
5
6
7
...
47
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2026