April 2025 - sr-dev - kamailio.org

git:master:408b48c6: github: rework issue_labeled [skip ci]
by Victor Seva 03 Apr '25

03 Apr '25

Module: kamailio Branch: master Commit: 408b48c6fc0ac608ca6271631220277ea865d434 URL: https://github.com/kamailio/kamailio/commit/408b48c6fc0ac608ca6271631220277… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-03T11:12:18+02:00 github: rework issue_labeled [skip ci] use actions/github-script instead --- Modified: .github/workflows/issue_labeled.yml --- Diff: https://github.com/kamailio/kamailio/commit/408b48c6fc0ac608ca6271631220277… Patch: https://github.com/kamailio/kamailio/commit/408b48c6fc0ac608ca6271631220277… --- diff --git a/.github/workflows/issue_labeled.yml b/.github/workflows/issue_labeled.yml index c0ad87c5e7b..31d546c733f 100644 --- a/.github/workflows/issue_labeled.yml +++ b/.github/workflows/issue_labeled.yml @@ -5,15 +5,16 @@ on: types: [labeled] jobs: - reply-helper: + label-helper: runs-on: ubuntu-latest steps: - - name: mailing list question + - uses: actions/github-script@v7 if: github.event.label.name == 'mailing list question' - run: gh issue close $ISSUE --comment "$MSG" - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - ISSUE: ${{ github.event.issue.number }} - MSG: | - This tracker is for reporting issues in the C code, for questions - about kamailio use sr-users(a)lists.kamailio.org mailing list. + with: + script: | + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: 'This tracker is for reporting issues in the C code, for questions about kamailio use sr-users(a)lists.kamailio.org mailing list.' + })

1 0

git:master:5b2d3925: github: Issue label helper workflow [skip ci]
by Victor Seva 03 Apr '25

03 Apr '25

Module: kamailio Branch: master Commit: 5b2d39253b7a1a8aca313f0c5d8861637a3f367a URL: https://github.com/kamailio/kamailio/commit/5b2d39253b7a1a8aca313f0c5d88616… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-03T10:57:04+02:00 github: Issue label helper workflow [skip ci] reacts when an issue get a label: * 'mailing list question' => small comment and close it --- Added: .github/workflows/issue_labeled.yml --- Diff: https://github.com/kamailio/kamailio/commit/5b2d39253b7a1a8aca313f0c5d88616… Patch: https://github.com/kamailio/kamailio/commit/5b2d39253b7a1a8aca313f0c5d88616… --- diff --git a/.github/workflows/issue_labeled.yml b/.github/workflows/issue_labeled.yml new file mode 100644 index 00000000000..c0ad87c5e7b --- /dev/null +++ b/.github/workflows/issue_labeled.yml @@ -0,0 +1,19 @@ +name: Issue Label helper + +on: + issues: + types: [labeled] + +jobs: + reply-helper: + runs-on: ubuntu-latest + steps: + - name: mailing list question + if: github.event.label.name == 'mailing list question' + run: gh issue close $ISSUE --comment "$MSG" + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + ISSUE: ${{ github.event.issue.number }} + MSG: | + This tracker is for reporting issues in the C code, for questions + about kamailio use sr-users(a)lists.kamailio.org mailing list.

1 0

git:master:c32aab3a: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 03 Apr '25

03 Apr '25

Module: kamailio Branch: master Commit: c32aab3aa2b1a76cfc870325ef08451913ca8b4e URL: https://github.com/kamailio/kamailio/commit/c32aab3aa2b1a76cfc870325ef08451… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-03T09:16:09+02:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/c32aab3aa2b1a76cfc870325ef08451… Patch: https://github.com/kamailio/kamailio/commit/c32aab3aa2b1a76cfc870325ef08451… --- diff --git a/src/modules/tm/README b/src/modules/tm/README index cbe98e02e6f..c0385295106 100644 --- a/src/modules/tm/README +++ b/src/modules/tm/README @@ -163,8 +163,9 @@ Daniel-Constantin Mierla 5.9. tm.hash_stats 5.10. tm.reply 5.11. tm.reply_callid - 5.12. tm.clean - 5.13. tm.stats + 5.12. tm.retransmit_reply + 5.13. tm.clean + 5.14. tm.stats 6. Event Routes @@ -303,9 +304,10 @@ Daniel-Constantin Mierla 1.109. t_clean usage 1.110. t_exists usage 1.111. t_cell_append_branches usage - 1.112. event_route[tm:branch-failure:id] usage - 1.113. event_route[tm:local-request] usage - 1.114. event_route[tm:local-response] usage + 1.112. Using “tm.retransmit_reply” + 1.113. event_route[tm:branch-failure:id] usage + 1.114. event_route[tm:local-request] usage + 1.115. event_route[tm:local-response] usage Chapter 1. Admin Guide @@ -449,8 +451,9 @@ Chapter 1. Admin Guide 5.9. tm.hash_stats 5.10. tm.reply 5.11. tm.reply_callid - 5.12. tm.clean - 5.13. tm.stats + 5.12. tm.retransmit_reply + 5.13. tm.clean + 5.14. tm.stats 6. Event Routes @@ -3194,8 +3197,9 @@ reply_route { 5.9. tm.hash_stats 5.10. tm.reply 5.11. tm.reply_callid - 5.12. tm.clean - 5.13. tm.stats + 5.12. tm.retransmit_reply + 5.13. tm.clean + 5.14. tm.stats 5.1. tm.list @@ -3290,14 +3294,26 @@ reply_route { * body - (optional, may not be present) reply body (if present, requires the “Content-Type” and “Content-length” headers) -5.12. tm.clean +5.12. tm.retransmit_reply + + Retransmit the reply for an existing SIP transaction. + + Parameters: + * trans_id - transaction identifier (has the hash_entry:label format) + + Example 1.112. Using “tm.retransmit_reply” +... +kamcli rpc tm.retransmit_reply 1234:5678 +... + +5.13. tm.clean Trigger a hard clean of expired transactions. Parameters: * none -5.13. tm.stats +5.14. tm.stats Gets information about current and past TM transaction handling. @@ -3320,7 +3336,7 @@ reply_route { enabled with the t_on_branch_failure function. This event_route uses the BRANCH_FAILURE_ROUTE route type. - Example 1.112. event_route[tm:branch-failure:id] usage + Example 1.113. event_route[tm:branch-failure:id] usage ... request_route { ... @@ -3346,7 +3362,7 @@ event_route[tm:branch-failure:myroute] { The request can still be updated, i.e., changes are possible to R-URI ($ru), destination URI ($du) or the send socket ($fs). - Example 1.113. event_route[tm:local-request] usage + Example 1.114. event_route[tm:local-request] usage ... event_route [tm:local-request] { xlog("L_INFO", "Routing locally generated $rm to $ru\n"); @@ -3359,7 +3375,7 @@ event_route [tm:local-request] { Executed after the tm module sent a local generated, transaction stateful response. - Example 1.114. event_route[tm:local-response] usage + Example 1.115. event_route[tm:local-response] usage ... event_route[tm:local-response] { xlog("tm:local-response replied locally\n");

1 0

git:master:7d2f49f1: tm: docs for rpc tm.retransmit_reply
by Daniel-Constantin Mierla 03 Apr '25

03 Apr '25

Module: kamailio Branch: master Commit: 7d2f49f1f4f0971aa77cb40009e8db31cc3063a1 URL: https://github.com/kamailio/kamailio/commit/7d2f49f1f4f0971aa77cb40009e8db3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-03T09:03:11+02:00 tm: docs for rpc tm.retransmit_reply --- Modified: src/modules/tm/doc/rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/7d2f49f1f4f0971aa77cb40009e8db3… Patch: https://github.com/kamailio/kamailio/commit/7d2f49f1f4f0971aa77cb40009e8db3… --- diff --git a/src/modules/tm/doc/rpc.xml b/src/modules/tm/doc/rpc.xml index 808ecbfcba0..726c5aa2df4 100644 --- a/src/modules/tm/doc/rpc.xml +++ b/src/modules/tm/doc/rpc.xml @@ -219,6 +219,31 @@ </para></listitem> </itemizedlist> </section> + + <section id="tm.rpc.retransmit_reply"> + <title> + <function moreinfo="none">tm.retransmit_reply</function> + </title> + <para> + Retransmit the reply for an existing SIP transaction. + </para> + <para>Parameters: </para> + <itemizedlist> + <listitem><para> + <emphasis>trans_id</emphasis> - transaction identifier + (has the hash_entry:label format) + </para></listitem> + </itemizedlist> + <example> + <title>Using <quote>tm.retransmit_reply</quote></title> + <programlisting format="linespecific"> +... +kamcli rpc tm.retransmit_reply 1234:5678 +... +</programlisting> + </example> + </section> + <section id="tm.rpc.clean"> <title> <function moreinfo="none">tm.clean</function>

1 0

git:master:d8b3c16d: tm: added rpc.retransmit_reply rpc command
by Daniel-Constantin Mierla 03 Apr '25

03 Apr '25

Module: kamailio Branch: master Commit: d8b3c16d8b1bd99db758b389ab8147ad43c35e28 URL: https://github.com/kamailio/kamailio/commit/d8b3c16d8b1bd99db758b389ab8147a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-03T09:03:11+02:00 tm: added rpc.retransmit_reply rpc command --- Modified: src/modules/tm/t_reply.c Modified: src/modules/tm/t_reply.h Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/d8b3c16d8b1bd99db758b389ab8147a… Patch: https://github.com/kamailio/kamailio/commit/d8b3c16d8b1bd99db758b389ab8147a… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index aa899f9acc0..670260d93e8 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -3123,6 +3123,53 @@ void rpc_reply_callid(rpc_t *rpc, void *c) } } +/* + * Syntax: + * + * ":tm.retransmit_reply:[response file]\n + * trans_id\n + * \n" + */ +void rpc_retransmit_reply(rpc_t *rpc, void *c) +{ + int ret; + tm_cell_t *trans; + tm_cell_t *orig_t = NULL; + int orig_branch; + unsigned int hash_index, label; + str ti; + + if(rpc->scan(c, "S", &ti) < 1) { + rpc->fault(c, 400, "Transaction ID expected"); + return; + } + + if(sscanf(ti.s, "%u:%u", &hash_index, &label) != 2) { + ERR("Invalid trans_id (%s)\n", ti.s); + rpc->fault(c, 400, "Invalid transaction ID"); + return; + } + LM_DBG("hash_index=%u label=%u\n", hash_index, label); + + tm_get_tb(&orig_t, &orig_branch); + if(t_lookup_ident(&trans, hash_index, label) < 0) { + ERR("Lookup failed\n"); + rpc->fault(c, 481, "No such transaction"); + return; + } + + /* it is refcounted now */ + ret = t_retransmit_reply(trans); + UNREF(trans); + tm_set_tb(orig_t, orig_branch); + + if(ret < 0) { + LM_ERR("Reply retransmission failed\n"); + rpc->fault(c, 500, "Reply retransmission failed"); + return; + } +} + /** * re-entrant locking of reply mutex */ diff --git a/src/modules/tm/t_reply.h b/src/modules/tm/t_reply.h index 250dd2e347a..0fe1c09eb81 100644 --- a/src/modules/tm/t_reply.h +++ b/src/modules/tm/t_reply.h @@ -226,6 +226,7 @@ void t_drop_replies(int v); void rpc_reply(rpc_t *rpc, void *c); void rpc_reply_callid(rpc_t *rpc, void *c); +void rpc_retransmit_reply(rpc_t *rpc, void *c); int faked_env(struct cell *t, struct sip_msg *msg, int is_async_env); struct sip_msg *fake_req(struct sip_msg *shmem_msg, int extra_flags, diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 8bb6da0a2aa..0df18a8bd1b 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -2864,6 +2864,11 @@ static const char *rpc_reply_doc[2] = { 0 }; +static const char *rpc_retransmit_reply_doc[2] = { + "Retransmit the transaction reply", + 0 +}; + static const char *rpc_reply_callid_doc[2] = { "Reply transaction by call-id", 0 @@ -2937,6 +2942,7 @@ static const char *tm_rpc_clean_doc[2] = { static rpc_export_t tm_rpc[] = { {"tm.cancel", rpc_cancel, rpc_cancel_doc, 0}, {"tm.reply", rpc_reply, rpc_reply_doc, 0}, + {"tm.retransmit_reply", rpc_retransmit_reply, rpc_retransmit_reply_doc, 0}, {"tm.reply_callid", rpc_reply_callid, rpc_reply_callid_doc, 0}, {"tm.stats", tm_rpc_stats, tm_rpc_stats_doc, 0}, {"tm.hash_stats", tm_rpc_hash_stats, tm_rpc_hash_stats_doc, 0},

1 0

git:master:577f1b19: modules: readme files regenerated - siputils ... [skip ci]
by Kamailio Dev 02 Apr '25

02 Apr '25

Module: kamailio Branch: master Commit: 577f1b19383f94e61c535d9a3ea8bc13b77bdee8 URL: https://github.com/kamailio/kamailio/commit/577f1b19383f94e61c535d9a3ea8bc1… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-02T16:31:10+02:00 modules: readme files regenerated - siputils ... [skip ci] --- Modified: src/modules/siputils/README --- Diff: https://github.com/kamailio/kamailio/commit/577f1b19383f94e61c535d9a3ea8bc1… Patch: https://github.com/kamailio/kamailio/commit/577f1b19383f94e61c535d9a3ea8bc1…

1 0

git:master:16fd5f7d: siputils: docs for contact_param_encode_alias()
by Daniel-Constantin Mierla 02 Apr '25

02 Apr '25

Module: kamailio Branch: master Commit: 16fd5f7d25cd2743428471fcb6c768d4e71bc4c6 URL: https://github.com/kamailio/kamailio/commit/16fd5f7d25cd2743428471fcb6c768d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-02T16:12:05+02:00 siputils: docs for contact_param_encode_alias() --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/16fd5f7d25cd2743428471fcb6c768d… Patch: https://github.com/kamailio/kamailio/commit/16fd5f7d25cd2743428471fcb6c768d… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index e92472284df..fffdf2db361 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -1284,7 +1284,7 @@ if(is_first_hop("1")) { ... } the sending interface.IP address. </para> <para> - Return Codes: + Return Codes: </para> <itemizedlist> <listitem><para> @@ -1351,6 +1351,28 @@ if (is_method("REGISTER") and src_ip == 10.0.0.0/8) { contact_param_encode("ksu", "sip:1.2.3.4:5060;transport=tcp"); } ... +</programlisting> + </example> + </section> + <section id="siputils.f.contact_param_encode_alias"> + <title> + <function moreinfo="none">contact_param_encode_alias(pname, saddr)</function> + </title> + <para> + Similar to contact_param_encode() but it also adds the alias parameter + with the encoded source address to the original Contact URI. + </para> + <para> + This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE. + </para> + <example> + <title><function>contact_param_encode_alias</function> usage</title> + <programlisting format="linespecific"> +... +if (is_method("SUBSCRIBE") and src_ip == 10.0.0.0/8) { + contact_param_encode_alias("ksu", "sip:1.2.3.4:5060;transport=tcp"); +} +... </programlisting> </example> </section> @@ -1561,7 +1583,7 @@ if (sip_parse_headers()) { <section id="siputils.v.pcv_status"> <title><varname>$pcv(status)</varname></title> <para> - Returns whether the PCV header was successfully parsed, deleted, + Returns whether the PCV header was successfully parsed, deleted, newly generated or other. <itemizedlist> <listitem><para>

1 0

git:master:26aeb724: siputils: function to encode contact with alias
by Daniel-Constantin Mierla 02 Apr '25

02 Apr '25

Module: kamailio Branch: master Commit: 26aeb724afb434d641600a1dd57c8298adea3dab URL: https://github.com/kamailio/kamailio/commit/26aeb724afb434d641600a1dd57c829… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-02T16:01:27+02:00 siputils: function to encode contact with alias --- Modified: src/modules/siputils/contact_ops.c Modified: src/modules/siputils/contact_ops.h Modified: src/modules/siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/26aeb724afb434d641600a1dd57c829… Patch: https://github.com/kamailio/kamailio/commit/26aeb724afb434d641600a1dd57c829…

1 0

git:master:c532a67d: parser/sdp: check if value is exceeded when looking for o= version field
by Daniel-Constantin Mierla 02 Apr '25

02 Apr '25

Module: kamailio Branch: master Commit: c532a67db654efb21f81e058b7e3a86229766a40 URL: https://github.com/kamailio/kamailio/commit/c532a67db654efb21f81e058b7e3a86… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-02T09:38:03+02:00 parser/sdp: check if value is exceeded when looking for o= version field --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c532a67db654efb21f81e058b7e3a86… Patch: https://github.com/kamailio/kamailio/commit/c532a67db654efb21f81e058b7e3a86… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 893ef0e58a4..5e9b3f121ab 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -735,7 +735,12 @@ int extract_sess_version(str *oline, str *sess_version) } i++; - } while(len < oline->len && i < 3); + } while((cp < oline->s + oline->len) && i < 3); + + if(cp >= oline->s + oline->len) { + LM_ERR("broken o= line - version field not found\n"); + return -1; + } len = cp - cp0 - 1; LM_DBG("end %d: >%.*s<\n", len, len, cp0);

1 0

[kamailio/kamailio] kex: add KDMQ to request statistic (PR #4197)
by vlitvinov 02 Apr '25

02 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description KDMQ messages were added as a separate received request method in the statistic. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4197 -- Commit Summary -- * kex: add KDMQ to request statistic -- File Changes -- M src/modules/kex/core_stats.c (5) M src/modules/kex/core_stats.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4197.patch https://github.com/kamailio/kamailio/pull/4197.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4197 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4197(a)github.com>

2 3