<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Hello,<br>
<br>
I reworked a bit the patch for req_uri storage in dialog structure and
applied the rest. All happened for kamailio 3.0, changes therefore are
in GIT:<br>
<a class="moz-txt-link-freetext" href="http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-3.0.x-from-git">http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-3.0.x-from-git</a><br>
<br>
Would be great if you can test. Documentation is not yet updated, there
is a new parameter to specify what to use to populate the ruri column,
here is something that you can use for your case (where you need
original uri):<br>
<br>
modparam("dialog", "ruri_pvar", "$avp(s:uri)")<br>
<br>
route {<br>
...<br>
$abp(s:uri) = $ou;<br>
...<br>
}<br>
<br>
Klaus, when you have time, please have a second look over the changes
in dialoginfo module.<br>
<br>
Thanks,<br>
Daniel<br>
<br>
<br>
On 12/17/09 5:28 PM, Santiago Gimeno wrote:
<blockquote
cite="mid:9519d5860912170828x64fbae31n75d17748fa27b612@mail.gmail.com"
type="cite">Hi,<br>
<br>
We have posted the patch here:<br>
<br>
<a moz-do-not-send="true"
href="http://sip-router.org/tracker/index.php?do=details&task_id=20">http://sip-router.org/tracker/index.php?do=details&task_id=20</a><br>
<br>
It's against kamailio-1.5.<br>
<br>
Hope it helps,<br>
<br>
Best regards,<br>
<br>
Santi<br>
<br>
<br>
<div class="gmail_quote">2009/12/17 Santiago Gimeno <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:santiago.gimeno@gmail.com">santiago.gimeno@gmail.com</a>></span><br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi
Klaus,<br>
<br>
<div class="gmail_quote">
<div class="im">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi
Santi!<br>
<br>
I think you are correct. I can not remember why I implemented it
different. Are the contact URIs available in the dialog structure? Then
it can easily be fixed.<br>
</blockquote>
</div>
<div><br>
We have another patch that fixes this, we'll try to post it later today.<br>
<br>
Thanks,<br>
<br>
Santi<br>
</div>
<div>
<div class="h5">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
regards<br>
klaus<br>
<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><br>
Best regards,<br>
<br>
Santi<br>
<br>
<br>
I checked it quickly and the only thing that does not seem ok is how<br>
the r-uri is taken in modules/dialog/dlg_handlers.c:<br>
<br>
- instead of:<br>
<br>
+ if(parse_orig_ruri(msg)< 0) {<br>
+ LM_ERR("bad request or missing RURI\n");<br>
+ return -1;<br>
+ }<br>
+<br>
<br>
should be:<br>
<br>
+ if(parse_sip_msg_uri(msg)< 0) {<br>
+ LM_ERR("bad request or missing RURI\n");<br>
+ return -1;<br>
+ }<br>
+<br>
<br>
and instead of:<br>
<br>
<br>
+ &(msg->first_line.u.request.uri) );<br>
<br>
should be<br>
<br>
+ GET_RURI(msg) );<br>
<br>
<br>
This ensures that latest R-URI value is taken -- you used to get<br>
original r-uri.<br>
<br>
If someone can test and report, I will commit quickly.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<br>
<br>
<br>
<br>
On 12/16/09 4:07 PM, Francisco Javier Lizarán Vilches wrote:<br>
</div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
-----Mensaje original-----<br>
De: <a moz-do-not-send="true"
href="mailto:users-bounces@lists.kamailio.org" target="_blank">users-bounces@lists.kamailio.org</a>
<mailto:<a moz-do-not-send="true"
href="mailto:users-bounces@lists.kamailio.org" target="_blank">users-bounces@lists.kamailio.org</a>>
[mailto:<a moz-do-not-send="true"
href="mailto:users-bounces@lists.kamailio.org" target="_blank">users-bounces@lists.kamailio.org</a>]
<div><br>
En nombre de Daniel-Constantin Mierla<br>
Enviado el: miércoles, 16 de diciembre de 2009 10:38<br>
Para: David<br>
</div>
CC: <a moz-do-not-send="true" href="mailto:users@lists.kamailio.org"
target="_blank">users@lists.kamailio.org</a> <mailto:<a
moz-do-not-send="true" href="mailto:users@lists.kamailio.org"
target="_blank">users@lists.kamailio.org</a>>
<div><br>
Asunto: Re: [Kamailio-Users] Presence_Dialoginfo versioning<br>
<br>
<br>
<br>
On 12/15/09 4:37 PM, David wrote:<br>
<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
OK, it turns out that the presence application is properly updating<br>
subscriptions within a dialog, and creating new subscriptions outside<br>
a dialog.<br>
<br>
The difficultly is that I am rewriting the To: header, since I used<br>
dirty tools, it was dropping ;tag=, so the server thought it was a
new<br>
dialog and the phone the same dialog.<br>
<br>
</blockquote>
This should be fixed once r-uri is used instead of To header, right?
I<br>
am trying to find some time to fix it, maybe with a mod param option.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
</div>
</blockquote>
<div> Hi Daniel,<br>
<br>
Some time ago we posted a patch to try to accomplish what you
mention:<br>
</div>
<a moz-do-not-send="true"
href="http://sip-router.org/tracker/index.php?do=details&task_id=18"
target="_blank">http://sip-router.org/tracker/index.php?do=details&task_id=18</a>
<<a moz-do-not-send="true"
href="http://sip-router.org/tracker/index.php?do=details&task_id=18"
target="_blank">http://sip-router.org/tracker/index.php?do=details&task_id=18</a>>
<div><br>
<br>
Hope it helps.<br>
<br>
Regards:<br>
Francisco<br>
<br>
<br>
</div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div> I am testing to make sure that the issue is
resolved.<br>
<br>
David<br>
<br>
<br>
<br>
On 2009-12-15 04:12, Olle E. Johansson wrote:<br>
<br>
</div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div> 15 dec 2009 kl. 09.59 skrev Daniel-Constantin
Mierla:<br>
<br>
<br>
</div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hello,
<div>
<div><br>
<br>
On 12/15/09 2:20 AM, <a moz-do-not-send="true"
href="http://kamailio.org" target="_blank">kamailio.org</a>@<a
moz-do-not-send="true" href="http://spam.lublink.net" target="_blank">spam.lublink.net</a>
<mailto:<a moz-do-not-send="true"
href="mailto:kamailio.org@spam.lublink.net" target="_blank">kamailio.org@spam.lublink.net</a>>
wrote:<br>
<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Alright, I finally found the proper RFC,<br>
<a moz-do-not-send="true"
href="http://www.rfc-editor.org/rfc/rfc4235.txt" target="_blank">http://www.rfc-editor.org/rfc/rfc4235.txt</a><br>
<br>
Section 4.1 :<br>
<br>
"version: This attribute allows the recipient of dialog<br>
information documents to properly order them. Versions start at 0,<br>
and increment by one for each new document sent to a subscriber.<br>
Versions are scoped within a subscription. Versions MUST be<br>
representable using a non-negative 32 bit integer."<br>
<br>
Versions are scoped within a subscription, so when a new<br>
subscription is started, ( after the 1 hour expiry ), the version<br>
should be reset as it is a new subscription and therefore a new<br>
scope ?<br>
<br>
When the subscription expires, is it renewed or is a new<br>
subscription created? Is the scope separate, or is it the same<br>
subscription updated?<br>
<br>
</blockquote>
I think this is another questionable thing about SIP. IMO, it is<br>
same subscription if the dialog attributes do not change (call-id,<br>
from tag and to tag). But others can argue is it a new subscription.<br>
Anyone else on this one?<br>
<br>
<br>
</div>
</div>
</blockquote>
<div>
<div> The proper RFC for generic subscription/notify
questions is RFC 3265.<br>
<br>
"3.1.1 Subscription Duration<br>
SUBSCRIBE requests SHOULD contain an Expires header (defined in SIP<br>
[2]). This expires value indicates<br>
the duration of the subscription. In order to keep subscriptions<br>
effective beyond the duration communicated<br>
in the Expires header, subscribers need to refresh subscriptions on a<br>
periodic basis using a new<br>
SUBSCRIBE message on the same dialog as defined in SIP [2]"<br>
<br>
This indicates to me that it's the same subscription as long as you<br>
refresh it.<br>
<br>
RFC4235 refers to RFC 3265 for general terminology about
subscriptions.<br>
<br>
/O<br>
<br>
</div>
</div>
</blockquote>
<div>
<div> _______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
</div>
</div>
<a moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a> <mailto:<a
moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a>>
<div><br>
<a moz-do-not-send="true"
href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a moz-do-not-send="true"
href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
<br>
</div>
</blockquote>
<div> --<br>
Daniel-Constantin Mierla<br>
* <a moz-do-not-send="true" href="http://www.asipto.com/"
target="_blank">http://www.asipto.com/</a><br>
<br>
<br>
_______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
</div>
<a moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a> <mailto:<a
moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a>>
<div><br>
<a moz-do-not-send="true"
href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a moz-do-not-send="true"
href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
</div>
</blockquote>
<div> _______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
</div>
<a moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a> <mailto:<a
moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a>>
<div><br>
<a moz-do-not-send="true"
href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a moz-do-not-send="true"
href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
<br>
</div>
</blockquote>
<div><br>
-- Daniel-Constantin Mierla<br>
* <a moz-do-not-send="true" href="http://www.asipto.com/"
target="_blank">http://www.asipto.com/</a><br>
<br>
<br>
_______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
</div>
<a moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a> <mailto:<a
moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a>>
<div><br>
<a moz-do-not-send="true"
href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a moz-do-not-send="true"
href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
<br>
<br>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
<a moz-do-not-send="true" href="mailto:Users@lists.kamailio.org"
target="_blank">Users@lists.kamailio.org</a><br>
<a moz-do-not-send="true"
href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a moz-do-not-send="true"
href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users"
target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
</div>
</blockquote>
</blockquote>
</div>
</div>
</div>
<br>
</blockquote>
</div>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Kamailio (OpenSER) - Users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Users@lists.kamailio.org">Users@lists.kamailio.org</a>
<a class="moz-txt-link-freetext" href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a>
<a class="moz-txt-link-freetext" href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a></pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
* <a class="moz-txt-link-freetext" href="http://www.asipto.com/">http://www.asipto.com/</a>
</pre>
</body>
</html>