Hi Daniel,<br><br><br><div class="gmail_quote">El 16 de diciembre de 2009 17:30, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>></span> escribió:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
Hello Francisco,<br>
<br>
somehow I missed that patch, thanks for reminder! Is it against
sip-router or kamailio 1.5.x?<br></div></blockquote><div><br>I'm a Francisco's workmate. The patch is against kamailio 1.5. We have been using this patch in our test environment for a couple of months without problems.<br>
<br>BTW, we have noticed that in the dialog-info+xml body the <target uri="..."> is set to the same value as the <identity> for both local and remote elements. Is this correct? or should they be set to the local and remote contact instead?<br>
<br>Best regards,<br><br>Santi<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>
<br>
I checked it quickly and the only thing that does not seem ok is how
the r-uri is taken in
modules/dialog/dlg_handlers.c:<br>
<br>
- instead of:<br>
<br>
<pre>+ if(parse_orig_ruri(msg)< 0) {
+ LM_ERR("bad request or missing RURI\n");
+ return -1;
+ }
+
</pre>
should be:<br>
<br>
<pre>+ if(parse_sip_msg_uri(msg)< 0) {
+ LM_ERR("bad request or missing RURI\n");
+ return -1;
+ }
+
</pre>
and instead of:<br>
<br>
<br>
<pre>+ &(msg->first_line.u.request.uri) );
</pre>
should be <br>
<br>
<pre>+ GET_RURI(msg) );
</pre>
<br>
This ensures that latest R-URI value is taken -- you used to get
original r-uri.<br>
<br>
If someone can test and report, I will commit quickly.<br>
<br>
Cheers,<br>
Daniel<br> </div></blockquote><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div text="#000000" bgcolor="#ffffff"><div><div></div>
<div class="h5"><br>
<br>
<br>
On 12/16/09 4:07 PM, Francisco Javier Lizarán Vilches wrote:
<blockquote type="cite">
<blockquote type="cite">
<pre>-----Mensaje original-----
De: <a href="mailto:users-bounces@lists.kamailio.org" target="_blank">users-bounces@lists.kamailio.org</a> [<a href="mailto:users-bounces@lists.kamailio.org" target="_blank">mailto:users-bounces@lists.kamailio.org</a>]
En nombre de Daniel-Constantin Mierla
Enviado el: miércoles, 16 de diciembre de 2009 10:38
Para: David
CC: <a href="mailto:users@lists.kamailio.org" target="_blank">users@lists.kamailio.org</a>
Asunto: Re: [Kamailio-Users] Presence_Dialoginfo versioning
On 12/15/09 4:37 PM, David wrote:
</pre>
<blockquote type="cite">
<pre>OK, it turns out that the presence application is properly updating
subscriptions within a dialog, and creating new subscriptions outside
a dialog.
The difficultly is that I am rewriting the To: header, since I used
dirty tools, it was dropping ;tag=, so the server thought it was a new
dialog and the phone the same dialog.
</pre>
</blockquote>
<pre>This should be fixed once r-uri is used instead of To header, right? I
am trying to find some time to fix it, maybe with a mod param option.
Cheers,
Daniel
</pre>
</blockquote>
<pre>Hi Daniel,
Some time ago we posted a patch to try to accomplish what you mention:
<a href="http://sip-router.org/tracker/index.php?do=details&task_id=18" target="_blank">http://sip-router.org/tracker/index.php?do=details&task_id=18</a>
Hope it helps.
Regards:
Francisco
</pre>
<blockquote type="cite">
<pre> </pre>
<blockquote type="cite">
<pre>I am testing to make sure that the issue is resolved.
David
On 2009-12-15 04:12, Olle E. Johansson wrote:
</pre>
<blockquote type="cite">
<pre>15 dec 2009 kl. 09.59 skrev Daniel-Constantin Mierla:
</pre>
<blockquote type="cite">
<pre>Hello,
On 12/15/09 2:20 AM, <a href="mailto:kamailio.org@spam.lublink.net" target="_blank">kamailio.org@spam.lublink.net</a> wrote:
</pre>
<blockquote type="cite">
<pre>Alright, I finally found the proper RFC,
<a href="http://www.rfc-editor.org/rfc/rfc4235.txt" target="_blank">http://www.rfc-editor.org/rfc/rfc4235.txt</a>
Section 4.1 :
"version: This attribute allows the recipient of dialog
information documents to properly order them. Versions start at 0,
and increment by one for each new document sent to a subscriber.
Versions are scoped within a subscription. Versions MUST be
representable using a non-negative 32 bit integer."
Versions are scoped within a subscription, so when a new
subscription is started, ( after the 1 hour expiry ), the version
should be reset as it is a new subscription and therefore a new
scope ?
When the subscription expires, is it renewed or is a new
subscription created? Is the scope separate, or is it the same
subscription updated?
</pre>
</blockquote>
<pre>I think this is another questionable thing about SIP. IMO, it is
same subscription if the dialog attributes do not change (call-id,
from tag and to tag). But others can argue is it a new subscription.
Anyone else on this one?
</pre>
</blockquote>
<pre>The proper RFC for generic subscription/notify questions is RFC 3265.
"3.1.1 Subscription Duration
SUBSCRIBE requests SHOULD contain an Expires header (defined in SIP
[2]). This expires value indicates
the duration of the subscription. In order to keep subscriptions
effective beyond the duration communicated
in the Expires header, subscribers need to refresh subscriptions on a
periodic basis using a new
SUBSCRIBE message on the same dialog as defined in SIP [2]"
This indicates to me that it's the same subscription as long as you
refresh it.
RFC4235 refers to RFC 3265 for general terminology about subscriptions.
/O
</pre>
</blockquote>
<pre>_______________________________________________
Kamailio (OpenSER) - Users mailing list
<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a>
<a href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a>
<a href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<pre>--
Daniel-Constantin Mierla
* <a href="http://www.asipto.com/" target="_blank">http://www.asipto.com/</a>
_______________________________________________
Kamailio (OpenSER) - Users mailing list
<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a>
<a href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a>
<a href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<pre>_______________________________________________
Kamailio (OpenSER) - Users mailing list
<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a>
<a href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a>
<a href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<br>
</div></div><pre cols="72">--
Daniel-Constantin Mierla
* <a href="http://www.asipto.com/" target="_blank">http://www.asipto.com/</a>
</pre>
</div>
<br>_______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
<a href="mailto:Users@lists.kamailio.org">Users@lists.kamailio.org</a><br>
<a href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br></blockquote></div><br>