<div dir="ltr"><div>Hello again,</div><div><br></div><div>I've just tested 5.6.0~rc0+bpo11.20220506004754.1 from 56-nightly, but loose_route() still returns false for early-dialog UPDATE... Does this build include c309122 and ceb688b referenced in <a href="https://github.com/kamailio/kamailio/issues/3090">https://github.com/kamailio/kamailio/issues/3090</a>?</div><div><br></div><div>Cheers,</div><div>George<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 7 Apr 2022 at 10:21, George Diamantopoulos <<a href="mailto:georgediam@gmail.com">georgediam@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hello all,</div><div><br></div><div>Thanks for the feedback, Henning. There seems to have already been a ticket about this but it's closed now: <a href="https://github.com/kamailio/kamailio/issues/2659" target="_blank">https://github.com/kamailio/kamailio/issues/2659</a></div><div><br></div><div>I'm a little confused here. It seems early-dialog UPDATE should be handled similarly to PRACK, so I guess maybe a patch like <a href="https://github.com/kamailio/kamailio/commit/37830f53b1f21fba5beef5d8e22913c431dcd708" target="_blank">https://github.com/kamailio/kamailio/commit/37830f53b1f21fba5beef5d8e22913c431dcd708</a> would be needed.</div><div><br></div><div>However, Daniel has commented in this issue about the need to do record_route() in config. To quote him: "The module requires record routing, so if the UPDATE requires to re-enforce Record-Route, then you have to do it. [...] I was aware that only NOTIFY requires to re-enforce Record-Route, but
can be also a matter of UA implementation to want it for other requests."<br></div><div><br></div><div>However, RR reinforcement for NOTIFY only happens (in the kamailio sample configuration file) in route[WITHINDLG] only if loose_route() check is successful. In my case, UPDATEs fail this test, so control goes directly to "sl_send_reply("404","Not here");", same as the author of the aforementioned ticket. Unless Daniel meant one needs to reinforce RR for PRACKs in order for subsequent UPDATEs to work?</div><div><br></div><div>Any thoughts?</div><div><br></div><div>BR,</div><div>George<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 6 Apr 2022 at 22:48, Henning Westerholt <<a href="mailto:hw@gilawa.com" target="_blank">hw@gilawa.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="DE">
<div>
<p class="MsoNormal"><span>Hello,<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Thanks for the update. Opening a github issue about it is probably a good idea.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Cheers,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Henning<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">-- <u></u>
<u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Henning Westerholt –
</span><span><a href="https://skalatan.de/blog/" target="_blank"><span style="color:rgb(5,99,193)" lang="EN-GB">https://skalatan.de/blog/</span></a></span><span lang="EN-GB"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Kamailio services –
</span><span><a href="https://gilawa.com/" target="_blank"><span style="color:rgb(5,99,193)" lang="EN-GB">https://gilawa.com</span></a></span><span lang="EN-GB"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<div style="border-color:rgb(225,225,225) currentcolor currentcolor;border-style:solid none none;border-width:1pt medium medium;padding:3pt 0cm 0cm">
<p class="MsoNormal" style="margin-left:35.4pt"><b>From:</b> sr-users <<a href="mailto:sr-users-bounces@lists.kamailio.org" target="_blank">sr-users-bounces@lists.kamailio.org</a>>
<b>On Behalf Of </b>George Diamantopoulos<br>
<b>Sent:</b> Wednesday, April 6, 2022 7:29 PM<br>
<b>To:</b> Kamailio (SER) - Users Mailing List <<a href="mailto:sr-users@lists.kamailio.org" target="_blank">sr-users@lists.kamailio.org</a>><br>
<b>Subject:</b> Re: [SR-Users] TOPOS (5.1.[23]) breaks PRACK<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">This seems to be a topos issue regardless of backend, I tried with mariadb as storage and UPDATE routing fails in the same way as it does with redis. I'll probably open an issue on Github about this (early dialog
UPDATE broken by topos). PRACK seems to work fine in my case. Direction of UPDATE vs PRACK however is different, not sure if that's important in any way.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">BR,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">George<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">On Wed, 6 Apr 2022 at 06:31, George Diamantopoulos <<a href="mailto:georgediam@gmail.com" target="_blank">georgediam@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Hello again,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">I have confirmed the problem doesn't manifest without loading the topos module. I'll see if I can also try a different topos backend this week to confirm if this is a topos_redis issue or topos in general.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">BR,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">George<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">On Tue, 22 Mar 2022 at 17:11, George Diamantopoulos <<a href="mailto:georgediam@gmail.com" target="_blank">georgediam@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Hello Henning,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">This is on kamailio 5.5.4.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">I'll try with a different backend and without topos and post the result here as soon as I find the time, just curious if anyone has stumbled on this with topos_redis before. Thanks!<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">BR,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">George<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal" style="margin-left:35.4pt"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">On Tue, 22 Mar 2022 at 15:51, Henning Westerholt <<a href="mailto:hw@gilawa.com" target="_blank">hw@gilawa.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">
Hello,<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB">please give a recent 5.5.x Kamailio a try. There was a fix regarding early-dialog UPDATE handling in topos committed one year ago.</span><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB"> </span><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB">Cheers,</span><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB"> </span><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB">Henning</span><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB"> </span><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB">-- </span><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB">Henning Westerholt – </span><a href="https://skalatan.de/blog/" target="_blank"><span style="color:rgb(5,99,193)" lang="EN-GB">https://skalatan.de/blog/</span></a><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB">Kamailio services – </span><a href="https://gilawa.com/" target="_blank"><span style="color:rgb(5,99,193)" lang="EN-GB">https://gilawa.com</span></a><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:35.4pt">
<span lang="EN-GB"> </span><u></u><u></u></p>
<div style="border-style:solid none none;border-width:1pt medium medium;padding:3pt 0cm 0cm;border-color:currentcolor">
<p class="MsoNormal" style="margin-left:70.8pt">
<b>From:</b> sr-users <<a href="mailto:sr-users-bounces@lists.kamailio.org" target="_blank">sr-users-bounces@lists.kamailio.org</a>>
<b>On Behalf Of </b>George Diamantopoulos<br>
<b>Sent:</b> Monday, March 21, 2022 11:53 PM<br>
<b>To:</b> <a href="mailto:d.tryba@pocos.nl" target="_blank">d.tryba@pocos.nl</a>; Kamailio (SER) - Users Mailing List <<a href="mailto:sr-users@lists.kamailio.org" target="_blank">sr-users@lists.kamailio.org</a>><br>
<b>Subject:</b> Re: [SR-Users] TOPOS (5.1.[23]) breaks PRACK<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-left:70.8pt">
<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">
Hello all,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">
Any chance this could be affecting early-dialog UPDATE methods as well? I haven't tried with a different backend (mysql) yet, but loose_route returns false...<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">
BR,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">
George<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal" style="margin-left:70.8pt">
<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">
On Fri, 25 May 2018 at 18:00, Daniel Tryba <<a href="mailto:d.tryba@pocos.nl" target="_blank">d.tryba@pocos.nl</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-style:none none none solid;border-width:medium medium medium 1pt;padding:0cm 0cm 0cm 6pt;margin:5pt 0cm 5pt 4.8pt;border-color:currentcolor currentcolor currentcolor rgb(204,204,204)">
<p class="MsoNormal" style="margin-left:70.8pt">
On Wed, May 23, 2018 at 10:51:37PM +0200, Daniel-Constantin Mierla wrote:<br>
> I got a bit of time to look at this issue, can you try with the patch<br>
> from the next commit?<br>
> <br>
> ?? -<br>
> <a href="https://github.com/kamailio/kamailio/commit/2a3ca5942291d29de05b14338a36cecbec11f129" target="_blank">
https://github.com/kamailio/kamailio/commit/2a3ca5942291d29de05b14338a36cecbec11f129</a><br>
> <br>
<br>
This off by 1 fix solved the PRACK issue with redis backend.<br>
<br>
<br>
_______________________________________________<br>
Kamailio (SER) - Users Mailing List<br>
<a href="mailto:sr-users@lists.kamailio.org" target="_blank">sr-users@lists.kamailio.org</a><br>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote></div>
</blockquote></div>