<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hello,</p>
    <p>the README was edited directly, which is not the way to do it. I
      added a note in the pull request about how changes to module docs
      have to be done, see also the wiki page:</p>
    <p>  - <a
        href="https://www.kamailio.org/wiki/devel/module-docbook-readme">https://www.kamailio.org/wiki/devel/module-docbook-readme</a></p>
    <p>Cheers,<br>
      Daniel<br>
    </p>
    <div class="moz-cite-prefix">On 12.08.20 16:17, sagar malam wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAEZuF3v_=4cfGRkTKCJQ-UFE6f5BQMa8ERmYUmdsq-BhHa4F8Q@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">Hello Henning, 
        <div><br>
        </div>
        <div>I have created pull request for same</div>
      </div>
      <br>
      <div class="gmail_quote">
        <div dir="ltr" class="gmail_attr">On Tue, Aug 11, 2020 at 9:10
          PM Henning Westerholt <<a href="mailto:hw@skalatan.de"
            moz-do-not-send="true">hw@skalatan.de</a>> wrote:<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0px 0px 0px
          0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
          <div lang="DE">
            <div class="gmail-m_-163799773736049264WordSection1">
              <p class="MsoNormal"><span lang="EN-GB">Hi Sagar,</span></p>
              <p class="MsoNormal"><span lang="EN-GB"> </span></p>
              <p class="MsoNormal"><span lang="EN-GB">the documentation
                  can be improved by creating a “pull request” on github
                  for it. Then it can be applied to the repository.</span></p>
              <p class="MsoNormal"><span lang="EN-GB"> </span></p>
              <p class="MsoNormal"><span lang="EN-GB">Cheers,</span></p>
              <p class="MsoNormal"><span lang="EN-GB"> </span></p>
              <p class="MsoNormal"><span lang="EN-GB">Henning</span></p>
              <p class="MsoNormal"><span lang="EN-GB"> </span></p>
              <p class="MsoNormal"><span lang="EN-GB">-- </span></p>
              <p class="MsoNormal"><span lang="EN-GB">Henning Westerholt
                  –
                </span><span><a href="https://skalatan.de/blog/"
                    target="_blank" moz-do-not-send="true"><span
                      style="color:rgb(5,99,193)" lang="EN-GB">https://skalatan.de/blog/</span></a></span><span
                  lang="EN-GB"></span></p>
              <p class="MsoNormal"><span lang="EN-GB">Kamailio services
                  –
                </span><span><a href="https://gilawa.com/"
                    target="_blank" moz-do-not-send="true"><span
                      style="color:rgb(5,99,193)" lang="EN-GB">https://gilawa.com</span></a></span><span>
                  <span lang="EN-GB"></span></span></p>
              <p class="MsoNormal"><span lang="EN-GB"> </span></p>
              <div
style="border-right:none;border-bottom:none;border-left:none;border-top:1pt
                solid rgb(225,225,225);padding:3pt 0cm 0cm">
                <p class="MsoNormal" style="margin-left:35.4pt"><b>From:</b>
                  sr-users <<a
                    href="mailto:sr-users-bounces@lists.kamailio.org"
                    target="_blank" moz-do-not-send="true">sr-users-bounces@lists.kamailio.org</a>>
                  <b>On Behalf Of </b>sagar malam<br>
                  <b>Sent:</b> Monday, August 10, 2020 7:58 PM<br>
                  <b>To:</b> <a href="mailto:miconda@gmail.com"
                    target="_blank" moz-do-not-send="true">miconda@gmail.com</a><br>
                  <b>Cc:</b> Kamailio (SER) - Users Mailing List <<a
                    href="mailto:sr-users@lists.kamailio.org"
                    target="_blank" moz-do-not-send="true">sr-users@lists.kamailio.org</a>><br>
                  <b>Subject:</b> Re: [SR-Users] Kamalio 5.4.0 should
                  support ka_add_destination function of KeepAlive
                  module ?</p>
              </div>
              <p class="MsoNormal" style="margin-left:35.4pt"> </p>
              <div>
                <p class="MsoNormal" style="margin-left:35.4pt">It
                  worked. Thanks so much. </p>
                <div>
                  <p class="MsoNormal" style="margin-left:35.4pt">Is
                    there any way I can help to correct documentation ?</p>
                </div>
              </div>
              <p class="MsoNormal" style="margin-left:35.4pt"> </p>
              <div>
                <div>
                  <p class="MsoNormal" style="margin-left:35.4pt">On
                    Mon, Aug 10, 2020 at 8:28 PM Daniel-Constantin
                    Mierla <<a href="mailto:miconda@gmail.com"
                      target="_blank" moz-do-not-send="true">miconda@gmail.com</a>>
                    wrote:</p>
                </div>
                <blockquote
style="border-top:none;border-right:none;border-bottom:none;border-left:1pt
                  solid rgb(204,204,204);padding:0cm 0cm 0cm
                  6pt;margin-left:4.8pt;margin-right:0cm">
                  <div>
                    <p style="margin-left:35.4pt">Hello,</p>
                    <p style="margin-left:35.4pt">the documentation is
                      somehow incorrect, the function is exported with
                      two parameters, the second being named owner. By
                      name, I assume it has the purpose as described in
                      the section:</p>
                    <p style="margin-left:35.4pt">  - <a
href="https://kamailio.org/docs/modules/5.4.x/modules/keepalive.html#dev-add_destination"
                        target="_blank" moz-do-not-send="true">
https://kamailio.org/docs/modules/5.4.x/modules/keepalive.html#dev-add_destination</a></p>
                    <p style="margin-left:35.4pt">So try to provide a
                      2nd string parameter that can be any value, for
                      example you can use "config".</p>
                    <p style="margin-left:35.4pt">Cheers,<br>
                      Daniel</p>
                    <div>
                      <p class="MsoNormal" style="margin-left:35.4pt">On
                        08.08.20 08:54, sagar malam wrote:</p>
                    </div>
                    <blockquote style="margin-top:5pt;margin-bottom:5pt">
                      <div>
                        <div>
                          <p class="MsoNormal"
                            style="margin-left:35.4pt">Hello  </p>
                        </div>
                        <div>
                          <p class="MsoNormal"
                            style="margin-left:35.4pt"> </p>
                        </div>
                        <p class="MsoNormal" style="margin-left:35.4pt">I
                          want to use ka_add_destination function of KA
                          module but i am getting this error :
                          <br>
                          [root@SBC-4-1] kamailio -c -f
                          /usr/local/etc/kamailio/kamailio.cfg<br>
                          loading modules under config path:
                          /usr/local/lib64/kamailio/modules/<br>
                           0(48016) ERROR: <core>
                          [core/cfg.y:3451]: yyparse(): cfg. parser:
                          failed to find command ka_add_destination
                          (params 1)<br>
                           0(48016) CRITICAL: <core>
                          [core/cfg.y:3592]: yyerror_at(): parse error
                          in config file
                          /usr/local/etc/kamailio/kamailio.cfg, line
                          1449, column 58: unknown command, missing
                          loadmodule?<br>
                          <br>
                          I know that 5.3.3 version does not support
                          this function but 5.4.0 should as per
                          documentation :
                          <br>
                          <a
href="https://kamailio.org/docs/modules/5.4.x/modules/keepalive.html#keepalive.ka_add_destination"
                            target="_blank" moz-do-not-send="true">https://kamailio.org/docs/modules/5.4.x/modules/keepalive.html#keepalive.ka_add_destination</a><br>
                          <br>
                          Keepalive module is compiled and loaded in
                          cfg.<br clear="all">
                        </p>
                        <div>
                          <p class="MsoNormal"
                            style="margin-left:35.4pt"> </p>
                        </div>
                        <p class="MsoNormal" style="margin-left:35.4pt">--
                        </p>
                        <div>
                          <div>
                            <p class="MsoNormal"
                              style="margin-left:35.4pt">Thanks, </p>
                            <div>
                              <p class="MsoNormal"
                                style="margin-left:35.4pt"> </p>
                            </div>
                            <div>
                              <p class="MsoNormal"
                                style="margin-left:35.4pt">Sagar</p>
                            </div>
                          </div>
                        </div>
                      </div>
                      <p class="MsoNormal" style="margin-left:35.4pt"> </p>
                      <pre style="margin-left:35.4pt">_______________________________________________</pre>
                      <pre style="margin-left:35.4pt">Kamailio (SER) - Users Mailing List</pre>
                      <pre style="margin-left:35.4pt"><a href="mailto:sr-users@lists.kamailio.org" target="_blank" moz-do-not-send="true">sr-users@lists.kamailio.org</a></pre>
                      <pre style="margin-left:35.4pt"><a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users" target="_blank" moz-do-not-send="true">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a></pre>
                    </blockquote>
                    <pre style="margin-left:35.4pt">-- </pre>
                    <pre style="margin-left:35.4pt">Daniel-Constantin Mierla -- <a href="http://www.asipto.com" target="_blank" moz-do-not-send="true">www.asipto.com</a></pre>
                    <pre style="margin-left:35.4pt"><a href="http://www.twitter.com/miconda" target="_blank" moz-do-not-send="true">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda" target="_blank" moz-do-not-send="true">www.linkedin.com/in/miconda</a></pre>
                    <pre style="margin-left:35.4pt">Funding: <a href="https://www.paypal.me/dcmierla" target="_blank" moz-do-not-send="true">https://www.paypal.me/dcmierla</a></pre>
                  </div>
                </blockquote>
              </div>
              <p class="MsoNormal" style="margin-left:35.4pt"><br
                  clear="all">
              </p>
              <div>
                <p class="MsoNormal" style="margin-left:35.4pt"> </p>
              </div>
              <p class="MsoNormal" style="margin-left:35.4pt">-- </p>
              <div>
                <div>
                  <p class="MsoNormal" style="margin-left:35.4pt">Thanks,</p>
                  <div>
                    <p class="MsoNormal" style="margin-left:35.4pt"> </p>
                  </div>
                  <div>
                    <p class="MsoNormal" style="margin-left:35.4pt">Sagar</p>
                  </div>
                </div>
              </div>
            </div>
          </div>
        </blockquote>
      </div>
      <br clear="all">
      <div><br>
      </div>
      -- <br>
      <div dir="ltr" class="gmail_signature">
        <div dir="ltr">Thanks,
          <div><br>
          </div>
          <div>Sagar</div>
        </div>
      </div>
    </blockquote>
    <pre class="moz-signature" cols="72">-- 
Daniel-Constantin Mierla -- <a class="moz-txt-link-abbreviated" href="http://www.asipto.com">www.asipto.com</a>
<a class="moz-txt-link-abbreviated" href="http://www.twitter.com/miconda">www.twitter.com/miconda</a> -- <a class="moz-txt-link-abbreviated" href="http://www.linkedin.com/in/miconda">www.linkedin.com/in/miconda</a>
Funding: <a class="moz-txt-link-freetext" href="https://www.paypal.me/dcmierla">https://www.paypal.me/dcmierla</a></pre>
  </body>
</html>