<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>OK, thanks for reporting back. I backported the commit to branch
5.3.</p>
<p>Cheers,<br>
Daniel<br>
</p>
<div class="moz-cite-prefix">On 21.05.20 11:10, Chris Martineau
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:LO2P265MB12938E83C69B1721F0FFA47A9CB70@LO2P265MB1293.GBRP265.PROD.OUTLOOK.COM">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<style type="text/css">.style1 {font-family: "Times New Roman";}</style>
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Sorry
Daniel, don’t think I followed up on this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">It
works a treat, thanks for your help.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Chris<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span
lang="EN-US"> Chris Martineau
<br>
<b>Sent:</b> 06 May 2020 11:57<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:miconda@gmail.com">miconda@gmail.com</a>; Kamailio (SER) - Users
Mailing List <a class="moz-txt-link-rfc2396E" href="mailto:sr-users@lists.kamailio.org"><sr-users@lists.kamailio.org></a><br>
<b>Subject:</b> RE: [SR-Users] PRACK support in
RTPENGINE module?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Todays
task, I had to port it into an earlier version for a legacy
version test.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span
lang="EN-US"> Daniel-Constantin Mierla <<a
href="mailto:miconda@gmail.com" moz-do-not-send="true">miconda@gmail.com</a>>
<br>
<b>Sent:</b> 06 May 2020 10:53<br>
<b>To:</b> Chris Martineau <<a
href="mailto:Chris.Martineau@semafone.com"
moz-do-not-send="true">Chris.Martineau@semafone.com</a>>;
Kamailio (SER) - Users Mailing List <<a
href="mailto:sr-users@lists.kamailio.org"
moz-do-not-send="true">sr-users@lists.kamailio.org</a>><br>
<b>Subject:</b> Re: [SR-Users] PRACK support in
RTPENGINE module?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Have you had the chance to do any testing? It will help
deciding to push the commit to branch 5.3 for the release of
5.3.4.<o:p></o:p></p>
<p>Cheers,<br>
Daniel<o:p></o:p></p>
<div>
<p class="MsoNormal">On 05.05.20 09:55, Chris Martineau wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks
Daniel,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Will
test and advise.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Chris</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span
lang="EN-US"> sr-users
<a href="mailto:sr-users-bounces@lists.kamailio.org"
moz-do-not-send="true"><sr-users-bounces@lists.kamailio.org></a>
<b>On Behalf Of </b>Daniel-Constantin Mierla<br>
<b>Sent:</b> 04 May 2020 19:09<br>
<b>To:</b> Kamailio (SER) - Users Mailing List <a
href="mailto:sr-users@lists.kamailio.org"
moz-do-not-send="true">
<sr-users@lists.kamailio.org></a><br>
<b>Subject:</b> Re: [SR-Users] PRACK support in
RTPENGINE module?</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">I pushed a patch to rtpengine module to
handle PRACK in both manage()<br>
and answer() functions.<br>
<br>
Chris: can you test and see if works as expected? If yes, it
will be<br>
backported.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
On 04.05.20 19:51, Alex Balashov wrote:<br>
> Oh, sorry. I misread; it seemed to me that
rtpengine_answer1_f() was<br>
> part of a cascade of fixup functions that goes back to<br>
> rtpengine_manage(), but not to _answer(). You're right
of course.<br>
><br>
> On Mon, May 04, 2020 at 07:49:19PM +0200,
Daniel-Constantin Mierla wrote:<br>
><br>
>> Hello,<br>
>><br>
>> Chris mentioned that rtpengine_answer() is also not
supporting (or is<br>
>> ruling out all request types but ACK), so the C
code is limiting in both<br>
>> cases, no matter using rtpengine_manage() or
rtpengine_answer().<br>
>><br>
>> The rtpengine manage() was built as a wrapper
around offer()/answer()<br>
>> and it makes the decision of which one is executed
in various cases<br>
>> (request/reply/failure route), but not what
offer()/answer() functions<br>
>> do internally.<br>
>><br>
>> So in this case the code has to allow execution for
PRACK, it was an<br>
>> omission, likely not a scenario that popped up so
far.<br>
>><br>
>> Cheers,<br>
>> Daniel<br>
>><br>
>> On 04.05.20 19:22, Alex Balashov wrote:<br>
>>> Hello Chris,<br>
>>><br>
>>> rtpengine_manage() is just a wrapper that makes
context-sensitive<br>
>>> invocations of rtpengine_offer() and
rtpengine_answer(), so that you<br>
>>> don't have to choose which of them to call
manually. But it's not<br>
>>> perfect. <br>
>>><br>
>>> There are nevertheless situations where this
manual use of the<br>
>>> offer/answer functions is necessary, and it
sounds like this is one of<br>
>>> them.<br>
>>><br>
>>> There is a larger question of whether
rtpengine_manage() should support<br>
>>> PRACK; it seems like the answer is yes. But
this lacking cannot be<br>
>>> framed as "RTPEngine doesn't support PRACK" or
anything like that.<br>
>>> RTPEngine can support any SDP-bearing request
and reply, since RTPEngine<br>
>>> does not care about SIP semantics per se.<br>
>>><br>
>>> -- Alex<br>
>>><br>
>>> -- <br>
>>> Alex Balashov | Principal | Evariste Systems
LLC<br>
>>><br>
>>> Tel: +1-706-510-6800 / +1-800-250-5920
(toll-free)<br>
>>> Web: <a href="http://www.evaristesys.com"
moz-do-not-send="true">
http://www.evaristesys.com/</a>, <a
href="http://www.csrpswitch.com" moz-do-not-send="true">
http://www.csrpswitch.com/</a><br>
>>><br>
>>> _______________________________________________<br>
>>> Kamailio (SER) - Users Mailing List<br>
>>> <a href="mailto:sr-users@lists.kamailio.org"
moz-do-not-send="true">sr-users@lists.kamailio.org</a><br>
>>> <a
href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users"
moz-do-not-send="true">
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><br>
>> -- <br>
>> Daniel-Constantin Mierla -- <a
href="http://www.asipto.com" moz-do-not-send="true">
www.asipto.com</a><br>
>> <a href="http://www.twitter.com/miconda"
moz-do-not-send="true">
www.twitter.com/miconda</a> -- <a
href="http://www.linkedin.com/in/miconda"
moz-do-not-send="true">
www.linkedin.com/in/miconda</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Kamailio (SER) - Users Mailing List<br>
>> <a href="mailto:sr-users@lists.kamailio.org"
moz-do-not-send="true">sr-users@lists.kamailio.org</a><br>
>> <a
href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users"
moz-do-not-send="true">
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><br>
> -- <br>
> Alex Balashov | Principal | Evariste Systems LLC<br>
><br>
> Tel: +1-706-510-6800 / +1-800-250-5920 (toll-free)<br>
> Web: <a href="http://www.evaristesys.com/"
moz-do-not-send="true">
http://www.evaristesys.com/</a>, <a
href="http://www.csrpswitch.com/" moz-do-not-send="true">
http://www.csrpswitch.com/</a><br>
<br>
-- <br>
Daniel-Constantin Mierla -- <a href="http://www.asipto.com"
moz-do-not-send="true">
www.asipto.com</a><br>
<a href="http://www.twitter.com/miconda"
moz-do-not-send="true">www.twitter.com/miconda</a> --
<a href="http://www.linkedin.com/in/miconda"
moz-do-not-send="true">
www.linkedin.com/in/miconda</a><br>
<br>
<br>
_______________________________________________<br>
Kamailio (SER) - Users Mailing List<br>
<a href="mailto:sr-users@lists.kamailio.org"
moz-do-not-send="true">sr-users@lists.kamailio.org</a><br>
<a
href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users"
moz-do-not-send="true">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<p><b><span
style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#666666">Disclaimer</span></b><span
style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#666666"><o:p></o:p></span></p>
<p><span
style="font-size:8.0pt;font-family:"Verdana",sans-serif;color:#666666">Semafone
is a limited company, registered in England, with
registered number 06963868. Our registered office is at
Pannell House, Park Street, Guildford, Surrey, GU1 4HN,
United Kingdom. The information contained in this
communication from the sender is confidential. It is
intended solely for use by the recipient and others
authorized to receive it. If you are not the recipient,
you are hereby notified that any disclosure, copying,
distribution or taking action in relation of the contents
of this information is strictly prohibited and may be
unlawful. If you have received this email in error, please
send it back to us, and immediately and permanently delete
it.<br>
<br>
This email has been scanned for viruses and malware, and
may have been automatically archived by Mimecast Ltd, an
innovator in Software as a Service (SaaS) for business.
Providing a safer and more useful place for your human
generated data. Specializing in; Security, archiving and
compliance. To find out more Click Here (<a
href="https://linkprotect.cudasvc.com/url?a=http%3a%2f%2fwww.mimecast.com%2fproducts%2f&c=E,1,6-EEFrJJBxQuWdKCU8nDShSCY8ftP3YG5HunAYbdqAhHg54p0k9SuXsxW6A7W32wpQKE1kZjwLwDwP1TF3_r3j4JAl62AkawRf-TI3zTOblg9g,,&typo=1"
moz-do-not-send="true">https://protect-eu.mimecast.com/s/6sS0CE8WmI1xZECyHvaY?domain=linkprotect.cudasvc.com</a>)
Although Semafone has taken reasonable precautions to
ensure no viruses are present in this email, Semafone
cannot accept responsibility for any loss or damage
sustained as a result of computer viruses and the
recipient must ensure that the email (and any attachments)
are virus free.<o:p></o:p></span></p>
</blockquote>
<pre>-- <o:p></o:p></pre>
<pre>Daniel-Constantin Mierla -- <a href="http://www.asipto.com" moz-do-not-send="true">www.asipto.com</a><o:p></o:p></pre>
<pre><a href="http://www.twitter.com/miconda" moz-do-not-send="true">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda" moz-do-not-send="true">www.linkedin.com/in/miconda</a><o:p></o:p></pre>
</div>
<br>
<br>
<p style="font-family: Verdana; font-size:10pt; color:#666666;"><b>Disclaimer</b></p>
<p style="font-family: Verdana; font-size:8pt; color:#666666;">Semafone
is a limited company, registered in England, with registered
number 06963868. Our registered office is at Pannell House, Park
Street, Guildford, Surrey, GU1 4HN, United Kingdom.
The information contained in this communication from the sender
is confidential. It is intended solely for use by the recipient
and others authorized to receive it. If you are not the
recipient, you are hereby notified that any disclosure, copying,
distribution or taking action in relation of the contents of
this information is strictly prohibited and may be unlawful. If
you have received this email in error, please send it back to
us, and immediately and permanently delete it.<br>
<br>
This email has been scanned for viruses and malware, and may
have been automatically archived by Mimecast Ltd, an innovator
in Software as a Service (SaaS) for business. Providing a safer
and more useful place for your human generated data.
Specializing in; Security, archiving and compliance. To find out
more Click Here
(<a class="moz-txt-link-freetext" href="https://protect-eu.mimecast.com/s/6sS0CE8WmI1xZECyHvaY?domain=linkprotect.cudasvc.com">https://protect-eu.mimecast.com/s/6sS0CE8WmI1xZECyHvaY?domain=linkprotect.cudasvc.com</a>)
Although Semafone has taken reasonable precautions to ensure no
viruses are present in this email, Semafone cannot accept
responsibility for any loss or damage sustained as a result of
computer viruses and the recipient must ensure that the email
(and any attachments) are virus free.</p>
</blockquote>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla -- <a class="moz-txt-link-abbreviated" href="http://www.asipto.com">www.asipto.com</a>
<a class="moz-txt-link-abbreviated" href="http://www.twitter.com/miconda">www.twitter.com/miconda</a> -- <a class="moz-txt-link-abbreviated" href="http://www.linkedin.com/in/miconda">www.linkedin.com/in/miconda</a>
Funding: <a class="moz-txt-link-freetext" href="https://www.paypal.me/dcmierla">https://www.paypal.me/dcmierla</a></pre>
</body>
</html>