<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=iso-8859-1"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"Préformaté HTML Car";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.PrformatHTMLCar
{mso-style-name:"Préformaté HTML Car";
mso-style-priority:99;
mso-style-link:"Préformaté HTML";
font-family:Consolas;
color:black;
mso-fareast-language:EN-US;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle26
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle27
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle28
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=FR link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:windowtext'>Hello Daniel,<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>I confirm that we did that indeed. Just added the support of "_" instead of rollback on the whole code.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Thank you!<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Igor.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='color:windowtext;mso-fareast-language:FR'>De :</span></b><span style='color:windowtext;mso-fareast-language:FR'> Daniel-Constantin Mierla <miconda@gmail.com> <br><b>Envoyé :</b> mercredi 11 septembre 2019 09:51<br><b>À :</b> igor.potjevlesch@gmail.com; 'Kamailio (SER) - Users Mailing List' <sr-users@lists.kamailio.org><br><b>Objet :</b> Re: [SR-Users] lookup(aliases) issues with 5.2<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p>Hello,<o:p></o:p></p><p>I will think what would be good ways to optimizie.<o:p></o:p></p><p>If you want to change the code, probably doesn't make sense to revert the entire patch locally, just allow '_' -- you should change:<o:p></o:p></p><p>if(!isalnum(*p) && (*p != '.') && (*p != '-')) {<o:p></o:p></p><p>to<o:p></o:p></p><p>if(!isalnum(*p) && (*p != '.') && (*p != '-') && (*p != '_')) {<o:p></o:p></p><p>in src/core/parser/parse_uri.c -- see function parse_uri() and case URI_HOST_P.<o:p></o:p></p><p>Cheers,<br>Daniel<o:p></o:p></p><p><o:p> </o:p></p><div><p class=MsoNormal>On 29.08.19 10:21, <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a> wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span style='color:windowtext'>Hello Daniel, Henning,</span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>I'd be interested, but if I'm the only one... Otherwise I can indeed remove this patch as Henning suggests, but it embarrasses me to have a different source code.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Tell me if it's possible to make it customizable. Otherwise I will consider either removing the patch or finding another workaround.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Regards,</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Igor.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-GB style='color:windowtext;mso-fareast-language:FR'>De :</span></b><span lang=EN-GB style='color:windowtext;mso-fareast-language:FR'> Daniel-Constantin Mierla <a href="mailto:miconda@gmail.com"><miconda@gmail.com></a> <br><b>Envoyé :</b> mercredi 28 août 2019 20:26<br><b>À :</b> <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a>; 'Kamailio (SER) - Users Mailing List' <a href="mailto:sr-users@lists.kamailio.org"><sr-users@lists.kamailio.org></a><br><b>Objet :</b> Re: [SR-Users] lookup(aliases) issues with 5.2</span><o:p></o:p></p></div></div><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p>Hello,<o:p></o:p></p><p>I haven't authored that patch and also never needed an underscore in host part of the URI, but also it didn't affect me before that change. I guess Juha wanted o be compliant with the RFC.<o:p></o:p></p><p>If people need to allow an extended set of chars in the host part, I am fine to add some parameter to control that.<o:p></o:p></p><p>Cheers,<br>Daniel<o:p></o:p></p><div><p class=MsoNormal>On 28.08.19 15:34, <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a> wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span style='color:windowtext'>Hello,</span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'>Hmm, ok. Saw it.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Is it possible to reconsider a less strict control?</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Regards,</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Igor.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-GB style='color:windowtext;mso-fareast-language:FR'>De :</span></b><span lang=EN-GB style='color:windowtext;mso-fareast-language:FR'> Daniel-Constantin Mierla <a href="mailto:miconda@gmail.com"><miconda@gmail.com></a> <br><b>Envoyé :</b> mercredi 28 août 2019 10:25<br><b>À :</b> <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a>; 'Kamailio (SER) - Users Mailing List' <a href="mailto:sr-users@lists.kamailio.org"><sr-users@lists.kamailio.org></a><br><b>Objet :</b> Re: [SR-Users] lookup(aliases) issues with 5.2</span><o:p></o:p></p></div></div><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p>Hello,<o:p></o:p></p><p>reading again I see that the error with the host uri is printed from the C code. I thought of another issue that was reported related to IPv6 addresses in the URI that kamctl rejected.<o:p></o:p></p><p>The problem is that the underscore is not allowed in hostname: the relevant standard is RFC 1123, section 2.1 "Host Names and Numbers" which limits host names to letters-digits-hyphen.<o:p></o:p></p><p>I checked the commits log and it seems this more strict verification was added by next commit:<o:p></o:p></p><p>commit 4994960324d5353222b3de08515bed07802ab7bc<br>Author: Juha Heinanen <a href="mailto:jh@tutpro.com"><jh@tutpro.com></a><br>Date: Wed Jan 10 08:39:48 2018 +0200<br><br> core/parser: more strict parsing of sip uri host<o:p></o:p></p><p>Regarding the $ALL_METHODS not being defined, iirc, you should set it to . (or maybe -1 in this case).<o:p></o:p></p><p>Cheers,<br>Daniel<o:p></o:p></p><div><p class=MsoNormal>On 28.08.19 10:12, <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a> wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span style='color:windowtext'>Hello Daniel,</span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>We moved to the latest 5.2.4 but hostname with underscore are still not handle properly. </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Is it a real design choice or a mistake somewhere in the code that handle domain name?</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Regards,</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Igor.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='color:windowtext;mso-fareast-language:FR'>De :</span></b><span style='color:windowtext;mso-fareast-language:FR'> <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a> <a href="mailto:igor.potjevlesch@gmail.com"><igor.potjevlesch@gmail.com></a> <br><b>Envoyé :</b> mardi 27 août 2019 11:53<br><b>À :</b> <a href="mailto:miconda@gmail.com">miconda@gmail.com</a>; 'Kamailio (SER) - Users Mailing List' <a href="mailto:sr-users@lists.kamailio.org"><sr-users@lists.kamailio.org></a><br><b>Objet :</b> RE: [SR-Users] lookup(aliases) issues with 5.2</span><o:p></o:p></p></div></div><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'>Hello Daniel,</span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Thank you for getting back to me.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>We will update with 5.2.4 and I'll let you know if it's solved.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Regards,</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'>Igor.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB style='color:windowtext'> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='color:windowtext;mso-fareast-language:FR'>De :</span></b><span style='color:windowtext;mso-fareast-language:FR'> Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>> <br><b>Envoyé :</b> mardi 27 août 2019 09:39<br><b>À :</b> Kamailio (SER) - Users Mailing List <<a href="mailto:sr-users@lists.kamailio.org">sr-users@lists.kamailio.org</a>>; <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a><br><b>Objet :</b> Re: [SR-Users] lookup(aliases) issues with 5.2</span><o:p></o:p></p></div></div><p class=MsoNormal> <o:p></o:p></p><p>Hello,<o:p></o:p></p><div><p class=MsoNormal>On 27.08.19 09:27, <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a> wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hello!<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>Any help on that matter? Sounds like the domain parsing have been updated. Is it possible to back on the previous mode?</span><o:p></o:p></p></blockquote><p>did you mean backporting to older branches? If yes, it was done to branch 5.2, have you tried with latest version in that branch?<o:p></o:p></p><p>Cheers,<br>Daniel<o:p></o:p></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>Regards,</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>Igor.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='mso-fareast-language:FR'>De :</span></b><span style='mso-fareast-language:FR'> <a href="mailto:igor.potjevlesch@gmail.com">igor.potjevlesch@gmail.com</a> <a href="mailto:igor.potjevlesch@gmail.com"><igor.potjevlesch@gmail.com></a> <br><b>Envoyé :</b> vendredi 23 août 2019 18:53<br><b>À :</b> 'Kamailio (SER) - Users Mailing List' <a href="mailto:sr-users@lists.kamailio.org"><sr-users@lists.kamailio.org></a><br><b>Objet :</b> lookup(aliases) issues with 5.2</span><o:p></o:p></p></div></div><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Hello!<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>I have notice some issues with lookup(aliases) since I upgraded to 5.2 from 5.1:</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>First with kamctl: If this default command is executed:</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN" "$2" \</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS" "$BR_FLAGS" "$ALL_METHODS"</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>as $ALL_METHODS is not defined, there is a huge value in methods and then lookup(aliases) fails with -2. </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>I have to update kamctl script and put -1 ("-1") instead of the variable. So, now, methods is a NULL value in DB and my alias is not ignored. But I use to make my alias like this: <a href="sip:number@blabla_1.local">sip:number@blabla_1.local</a></span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>Which is no longer works: ERROR: registrar [common.c:62]: extract_aor(): failed to parse AoR [<a href="sip:number@blabla_1.local">sip:number@blabla_1.local</a>]</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>Any idea of the difference since 5.2 with this behaviour? Without the underscore, the AoR seems to be valid but I need to support underscore as before.</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>Regards,</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-GB>Igor.</span><o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'><span style='mso-fareast-language:FR'> </span><o:p></o:p></p><pre>_______________________________________________<o:p></o:p></pre><pre>Kamailio (SER) - Users Mailing List<o:p></o:p></pre><pre><a href="mailto:sr-users@lists.kamailio.org">sr-users@lists.kamailio.org</a><o:p></o:p></pre><pre><a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><o:p></o:p></pre></blockquote><pre>-- <o:p></o:p></pre><pre>Daniel-Constantin Mierla -- <a href="http://www.asipto.com">www.asipto.com</a><o:p></o:p></pre><pre><a href="http://www.twitter.com/miconda">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda">www.linkedin.com/in/miconda</a><o:p></o:p></pre></blockquote><pre>-- <o:p></o:p></pre><pre>Daniel-Constantin Mierla -- <a href="http://www.asipto.com">www.asipto.com</a><o:p></o:p></pre><pre><a href="http://www.twitter.com/miconda">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda">www.linkedin.com/in/miconda</a><o:p></o:p></pre></blockquote><pre>-- <o:p></o:p></pre><pre>Daniel-Constantin Mierla -- <a href="http://www.asipto.com">www.asipto.com</a><o:p></o:p></pre><pre><a href="http://www.twitter.com/miconda">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda">www.linkedin.com/in/miconda</a><o:p></o:p></pre></blockquote><pre>-- <o:p></o:p></pre><pre>Daniel-Constantin Mierla -- <a href="http://www.asipto.com">www.asipto.com</a><o:p></o:p></pre><pre><a href="http://www.twitter.com/miconda">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda">www.linkedin.com/in/miconda</a><o:p></o:p></pre><pre>Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- <a href="https://asipto.com/u/kat">https://asipto.com/u/kat</a><o:p></o:p></pre></div></body></html>