<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello,</p>
<p>the patch should be fine for now. My review is mainly targeting
to see if other tm callbacks suffer from same situation and if I
can find a better solution. But for your specific case, should be
ok to use as it is now.<br>
</p>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 20.11.17 12:13, Marco Capetta wrote:<br>
</div>
<blockquote type="cite"
cite="mid:829749c7-612e-a4a3-23fb-0f40fc97d1ed@sipwise.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<tt>Hi Daniel</tt><tt>,<br>
<br>
did you have time to review the fix, or can I use the last
suggested patch?<br>
<br>
Thanks!<br>
<br>
Cheers,<br>
Marco<br>
</tt><br>
<div class="moz-cite-prefix"><tt>On 11/14/2017 08:39 AM,
Daniel-Constantin Mierla wrote:</tt><tt><br>
</tt></div>
<blockquote type="cite"
cite="mid:1ee086cd-4f74-d654-cff4-d7d075b59247@gmail.com">
<pre wrap="">Hello,
ok, thanks for testing, good to know the issue was identified! I will do
another review soon to see if there would be a better fix for the case.
Cheers,
Daniel
On 13.11.17 09:46, Marco Capetta wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Daniel,
we left the test system running the whole weekend and so far we haven't see any new ACC record for provisional response messages.
I think that the latest patch solved the issue.
Thank you
Cheers
Marco
----- Original Message -----
From: "Daniel-Constantin Mierla" <a class="moz-txt-link-rfc2396E" href="mailto:miconda@gmail.com" moz-do-not-send="true"><miconda@gmail.com></a>
To: "Kamailio (SER) - Users Mailing List" <a class="moz-txt-link-rfc2396E" href="mailto:sr-users@lists.kamailio.org" moz-do-not-send="true"><sr-users@lists.kamailio.org></a>, "Andrew Pogrebennyk" <a class="moz-txt-link-rfc2396E" href="mailto:apogrebennyk@sipwise.com" moz-do-not-send="true"><apogrebennyk@sipwise.com></a>
Sent: Friday, November 10, 2017 9:48:29 AM
Subject: Re: [SR-Users] 183 acc records even if early_media equals to 0
On 10.11.17 09:42, Andrew Pogrebennyk wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 11/10/2017 09:34 AM, Marco Capetta wrote:
</pre>
<blockquote type="cite">
<pre wrap="">+
if(relayed_msg->REPLY_STATUS==uas_rb->activ_type) {
+
run_trans_callbacks_with_buf( TMCB_RESPONSE_OUT, uas_rb, t->uas.request,
+
relayed_msg, relayed_code);
+ }
</pre>
</blockquote>
<pre wrap="">my guess is that in case of fake reply like a 408 the relayed_msg is -1
so addressing the member by pointer fails.
I have suggested Marco to try with if(relayed_msg==FAKED_REPLY ||
relayed_msg->REPLY_STATUS==uas_rb->activ_type)
Not sure if there are any other cases where relayed_msg is a NULL but we
will test this and let you know if it helps.
</pre>
</blockquote>
<pre wrap="">Indeed, I noticed that is the FAKED_REPLY looking at the locals in the
backtrace he sent to me. I think it is better to use relayed_code
instead of relayed_msg->REPLY_STATUS in that condition.
Cheers,
Daniel
</pre>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<div style="line-height:16px; margin:6px 0; padding:8px 8px 8px
8px; border-top:1px #aeb1a6 dotted; border-bottom:1px #aeb1a6
dotted; font-family: 'Lucida Sans', Lucida Grande, Verdana,
Arial, Sans-Serif; font-size:11px; color:#555555;"> <strong
style="color:#333333; text-transform:uppercase;
font-size:10px;"> Marco Capetta </strong> <br>
Operations Engineer
<p> <a href="http://www.sipwise.com" style="color:rgb(0, 136,
204) !important; text-decoration:none !important;
border-bottom:1px dotted #AAA;" moz-do-not-send="true">
Sipwise GmbH </a> , Campus 21/Europaring F15<br>
AT-2345 Brunn am Gebirge </p>
<p> Phone: <a href="tel:+4313012044" style="color:rgb(0,
136, 204) !important; text-decoration:none !important;
border-bottom:1px dotted #AAA;" moz-do-not-send="true">
+43(0)1 301 2044 </a> <br>
Email: <a href="mailto:mcapetta@sipwise.com"
style="color:rgb(0, 136, 204) !important;
text-decoration:none !important; border-bottom:1px dotted
#AAA;" moz-do-not-send="true"> mcapetta@sipwise.com </a>
<br>
Website: <a href="http://www.sipwise.com"
style="color:rgb(0, 136, 204) !important;
text-decoration:none !important; border-bottom:1px dotted
#AAA;" moz-do-not-send="true"> www.sipwise.com </a> </p>
<p> Particulars according Austrian Companies Code paragraph 14<br>
"Sipwise GmbH" - Europaring F15 - 2345 Brunn am Gebirge<br>
FN:305595f, Commercial Court Vienna, ATU64002206 </p>
</div>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-abbreviated" href="http://www.twitter.com/miconda">www.twitter.com/miconda</a> -- <a class="moz-txt-link-abbreviated" href="http://www.linkedin.com/in/miconda">www.linkedin.com/in/miconda</a>
Kamailio Advanced Training - <a class="moz-txt-link-abbreviated" href="http://www.asipto.com">www.asipto.com</a>
Kamailio World Conference - May 14-16, 2018 - <a class="moz-txt-link-abbreviated" href="http://www.kamailioworld.com">www.kamailioworld.com</a></pre>
</body>
</html>