<p></p>
<p><b>@henningw</b> commented on this pull request.</p>

<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/petermarianF/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/petermarianF">@petermarianF</a> Thank you for integrating all the comments and sorry for the delay. I've added two more comments, which are probably some minor things.</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3279#discussion_r1038357575">src/modules/ims_usrloc_pcscf/udomain.h</a>:</p>
<pre style='color:#555'>> @@ -82,5 +83,7 @@ int update_security(udomain_t* _d, security_type _t, security_t* _s, struct pcon
 int update_temp_security(udomain_t* _d, security_type _t, security_t* _s, struct pcontact* _c);
 
 int preload_udomain(db1_con_t* _c, udomain_t* _d);
-
+int audit_usrloc_expired_pcontacts(udomain_t* _d);
+int db_load_pcontact(udomain_t* _d, str *_aor, int insert_cache, struct pcontact** _c, pcontact_info_t* contact_info);
+int db_delete_presentityuri_from_pua(str *presentity_uri);
</pre>
<p dir="auto">This probably can be removed as well, as there is no implementation.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3279#discussion_r1038358494">src/modules/ims_usrloc_pcscf/usrloc_db.c</a>:</p>
<pre style='color:#555'>> @@ -301,7 +307,7 @@ int db_insert_pcontact(struct pcontact* _c)
        SET_PROPER_NULL_FLAG(_c->rinstance, values, LP_RINSTANCE_IDX);
        SET_PROPER_NULL_FLAG(_c->rx_session_id, values, LP_RX_SESSION_ID_IDX);
 
-       VAL_DOUBLE(GET_FIELD_IDX(values, LP_REG_STATE_IDX)) = _c->reg_state;
+       VAL_INT(GET_FIELD_IDX(values, LP_REG_STATE_IDX)) = _c->reg_state;
</pre>
<p dir="auto">Why you are changing this from double to int?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3279#pullrequestreview-1202820417">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZJOPQTRIA45UEHBZDDWLIV5HANCNFSM6AAAAAAR3RTGSI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZNMYBCU6PPXJRMMOMTWLIV5HA5CNFSM6AAAAAAR3RTGSKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSHWGKUC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3279/review/1202820417</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3279#pullrequestreview-1202820417",
"url": "https://github.com/kamailio/kamailio/pull/3279#pullrequestreview-1202820417",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>