<p></p>
<p><b>@rfuchs</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3230#discussion_r964780579">src/modules/rtpengine/rtpengine.c</a>:</p>
<pre style='color:#555'>> @@ -2529,6 +2551,7 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t *bencbuf, struct sip_
 
        body.s = NULL;
        ng_flags.flags = bencode_list(bencbuf);
+       ng_flags.received-from = bencode_list(bencbuf);
</pre>
<p dir="auto">Typo here (dash instead of underscore). Maybe at least try to compile it before submitting?</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3230#discussion_r964783738">src/modules/rtpengine/rtpengine.c</a>:</p>
<pre style='color:#555'>> @@ -2649,13 +2672,18 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t *bencbuf, struct sip_
                bencode_dictionary_add_str(ng_flags.dict, "via-branch", &viabranch);
        }
 
-       item = bencode_list(bencbuf);
-       bencode_dictionary_add(ng_flags.dict, "received-from", item);
-       bencode_list_add_string(item, (msg->rcv.src_ip.af == AF_INET) ? "IP4" : (
-               (msg->rcv.src_ip.af == AF_INET6) ? "IP6" :
-               "?"
-       ) );
-       bencode_list_add_string(item, ip_addr2a(&msg->rcv.src_ip));
+       if (ng_flags.received_from && ng_flags.received_from->child) {
+               bencode_dictionary_add(ng_flags.dict, "received-from", ng_flags.received_from);
+       }
+       else {
+               item = bencode_list(bencbuf);
</pre>
<p dir="auto">Just a suggestion, but you could reuse <code class="notranslate">ng_flags.received_from</code> here instead of creating a new list item. But up to you.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3230#pullrequestreview-1099086127">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZO7Q37KWULNX7WBZXDV5CDPLANCNFSM6AAAAAAQCU7W34">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZNLNGSJYBQ4ENGHZE3V5CDPLA5CNFSM6AAAAAAQCU7W36WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSBQK4S6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3230/review/1099086127</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3230#pullrequestreview-1099086127",
"url": "https://github.com/kamailio/kamailio/pull/3230#pullrequestreview-1099086127",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>