<p></p>
<blockquote>
<p dir="auto">The name of the parameter <code class="notranslate">separate_header_values</code> should be changed to <code class="notranslate">header_mode</code> to be even more generic and reused if anything else related to header management needs to be added in the future (e.g., add Via before or after Route).</p>
<p dir="auto">From implementation point of view, the current solution is "good enough" because it is doing a basic split on comma, working with the common format seen for these headers. Otherwise, at least the <code class="notranslate">Record/-Route</code> can have comma in its value, being defined as <code class="notranslate">name-addr</code> by grammar and in the eventuality of a display name, comma is allowed inside. Not sure if Via is allowed to have quoted value parameter, because I think inside it is also allowed to have comma.</p>
<p dir="auto">Anyhow, given that this commit adds this behaviour for particular deployments when some UA doesn't support headers with multiple comma separated values, I am fine to merge the implementation as it is, after renaming the parameter.</p>
</blockquote>
<p dir="auto">Thanks for feedback <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/miconda/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/miconda">@miconda</a>  changes done.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3220#issuecomment-1221265108">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMZMNLG7PXJG7GL6TLV2CPPLANCNFSM56W2LFQQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZMT27DXYPTLIL4Q2BLV2CPPLA5CNFSM56W2LFQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJDFQNVA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3220/c1221265108</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3220#issuecomment-1221265108",
"url": "https://github.com/kamailio/kamailio/pull/3220#issuecomment-1221265108",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>