<p></p>
<p><b>@piotrgregor</b> commented on this pull request.</p>

<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mrtrev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mrtrev">@mrtrev</a> Thank you very much for the PR. Indeed, certificate chain is not handled in libstirshaken when doing disk I/O. These changes would ideally go there. Methods that need to be changed (in libstirshaken) are:</p>
<p dir="auto"><code class="notranslate">stir_shaken_load_x509_from_file</code> - read complete cert/chain object with <code class="notranslate">PEM_read_X509</code>/<code class="notranslate">sk_X509_push</code> just as you're doing that in <code class="notranslate">stirshaken_handle_cache_from_disk</code></p>
<p dir="auto"><code class="notranslate">stir_shaken_x509_to_disk</code> - write complete cett/chain object with <code class="notranslate">PEM_write_X509</code>/<code class="notranslate">sk_X509_num</code> just as you're doing this in <code class="notranslate">stirshaken_handle_cache_to_disk</code></p>
<p dir="auto">Can you please suggest these changes to <a href="https://github.com/signalwire/libstirshaken">libstirshaken</a>? Then we do not need to make changes to this module (maybe just the logging related).</p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/miconda/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/miconda">@miconda</a> I suggest this is handled in libstirshaken, then optionally cosmetic changes (<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mrtrev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mrtrev">@mrtrev</a> proposed also some more logging) are merged.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3175#pullrequestreview-1027418018">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZPPZLR5BZ445ZSXA53VSLDF7ANCNFSM52P2GZPA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZOBVW2GL7QLGAU3XD3VSLDF7A5CNFSM52P2GZPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHU6SPIQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3175/review/1027418018</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3175#pullrequestreview-1027418018",
"url": "https://github.com/kamailio/kamailio/pull/3175#pullrequestreview-1027418018",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>