<p></p>
<blockquote>
<p dir="auto">Thanks for the PR!</p>
<p dir="auto">For reference, the git commit message has to be prefixed with the component name, in this case <code class="notranslate">tm: </code>, not the pull request name.</p>
<p dir="auto">Then, I don't think the list of reply codes and classes has to be in shared memory, they do not change at runtime. I see same is done in dispatcher module, so probably should be changed in both modules later.</p>
<p dir="auto">I am going to merge it manually.</p>
</blockquote>
<p dir="auto">Thanks for feedback Daniel.</p>
<p dir="auto">i will pay more attention to git commit message next time.</p>
<p dir="auto">for list of reply codes in shared memory i wanted also to be able to update it dynamically through kamcmd.<br>
even if right now i dont see (talking for myself) it happen quite often.</p>
<p dir="auto">so i started by put them in shared memory to continue after.</p>
<p dir="auto">Thanks.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3129#issuecomment-1145784239">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZIGQ5JHMQTHPFL5AVTVNHG3NANCNFSM5XOAW5TQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZIIID6ORRX5DALNEBLVNHG3NA5CNFSM5XOAW5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIRFUPLY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3129/c1145784239</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3129#issuecomment-1145784239",
"url": "https://github.com/kamailio/kamailio/pull/3129#issuecomment-1145784239",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>