<h4 dir="auto">Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code class="notranslate">doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4 dir="auto">Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4 dir="auto">Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4 dir="auto">Description</h4>
<p dir="auto">This change modifies <code class="notranslate">pv_www_authenticate</code> and related functions to add flag 32. If the flag is set and <code class="notranslate">nonce_count</code> is enabled then we skip updating nc in <code class="notranslate">pre_auth</code>. On success we call <code class="notranslate">check_nonce</code> once more to do the nc update. This can be used to chain calls to authenticate against multiple passwords.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/3133'>https://github.com/kamailio/kamailio/pull/3133</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/3133/commits/a82e5657b66272c0833c1d1d6a55ee29acc315a5" class="commit-link">a82e565</a> auth: Add flag for not invalidating nc on auth failure</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/kamailio/kamailio/pull/3133/files">8 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-aae88d2b7c8e3bf7feb09188d904a48bec64b38bdbf3b747c7102a3604afab27">src/modules/auth/api.c</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-fbfe1cd27c2b1527a0bc484bc197fb5b6b4275c409c79207ac7181723ffd5a80">src/modules/auth/api.h</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-46ae257470510ec733f8e2d37fa9cab1c0030aacd7345eb134fd74d9b1b642f2">src/modules/auth/auth_mod.c</a>
(31)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-8f31510e608d937185d092b86477fb6d05166a65d61b125caad2b76b95695138">src/modules/auth/doc/auth_functions.xml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-71e6858e875b1877a9afb7cb4c3610f1f5f0c4896b8dce3d9cd51b88f384198e">src/modules/auth/nc.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-b34441482e7753ce99399dfdcbc64479809e91143c3bc5c5583f090d5c0b6781">src/modules/auth/nc.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-8eded69c257270c1ff4bf33adfedc554e56f8eca89018042819e42ec9be93b6f">src/modules/auth/nonce.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3133/files#diff-4e6a5ca2e11763ff7e38359a1bab1fe63285fcbc336353b11909518a782e6450">src/modules/auth/nonce.h</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/3133.patch'>https://github.com/kamailio/kamailio/pull/3133.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/3133.diff'>https://github.com/kamailio/kamailio/pull/3133.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3133">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMXYR2FH4D7ZK2RWSTVNILGTANCNFSM5XZHYTNQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZI3BHAHSQA6NPCFB53VNILGTA5CNFSM5XZHYTN2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4SY2EOGA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3133</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3133",
"url": "https://github.com/kamailio/kamailio/pull/3133",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>