<p></p>
<p><b>@henningw</b> commented on this pull request.</p>

<p dir="auto">I was probably not clear in my previous comment. I have added it to the appropriate places in your patch, maybe its more clear this way.</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3079#discussion_r857584844">src/modules/pua_dialoginfo/pua_dialoginfo.c</a>:</p>
<pre style='color:#555'>> -                            __dialog_sendpublish, dlginfo, free_dlginfo_cell) != 0) {
-                       LM_ERR("cannot register callback for interesting dialog types\n");
-                       free_dlginfo_cell(dlginfo);
-                       return NULL;
-               }
-        } else {
-               if (dlg_api.register_dlgcb(dlg,
-                               DLGCB_FAILED| DLGCB_CONFIRMED_NA | DLGCB_TERMINATED
-                               | DLGCB_EXPIRED | DLGCB_EARLY,
-                               __dialog_sendpublish, dlginfo, free_dlginfo_cell) != 0) {
-                       LM_ERR("cannot register callback for interesting dialog types\n");
-                       free_dlginfo_cell(dlginfo);
-                       return NULL;
-               }
-        }
+       if (dlg_api.register_dlgcb(dlg, dialog_event_types,
</pre>
<p dir="auto">This will allocate new memory and copy the call back types to the new allocated structure.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3079#discussion_r857585214">src/modules/pua_dialoginfo/pua_dialoginfo.c</a>:</p>
<pre style='color:#555'>> @@ -856,6 +844,9 @@ static int mod_init(void)
                LM_DBG("configured to use headers for uri values\n");
        }
 
+       if(publish_dialog_req_within)
+               dialog_event_types |= DLGCB_REQ_WITHIN;
</pre>
<p dir="auto">This will change the callback types, it will be not synchronized with the structure inside the dialog module.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3079#pullrequestreview-951799464">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZP64K37FWGZANX2TELVG2HV7ANCNFSM5TDA5NIQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZKKXWQNCWAPNVU2NQDVG2HV7A5CNFSM5TDA5NI2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHC5U5KA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3079/review/951799464</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3079#pullrequestreview-951799464",
"url": "https://github.com/kamailio/kamailio/pull/3079#pullrequestreview-951799464",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>