<h4 dir="auto">Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4 dir="auto">Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4 dir="auto">Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1148009045" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/3037" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/3037/hovercard" href="https://github.com/kamailio/kamailio/issues/3037">#3037</a></li>
</ul>
<h4 dir="auto">Description</h4>
<p dir="auto">I can not remember the last time I wrote any C which was likely a class assignment last century. Anyways I came across this issue and it seemed in reach to get the ball rolling. I know this PR needs more work but my goal is to share my progress to help move this feature forward.</p>
<p dir="auto">Based on <a href="https://github.com/svaarala/duktape/tree/master/extras/module-node">https://github.com/svaarala/duktape/tree/master/extras/module-node</a><br>
added:</p>
<ul dir="auto">
<li>duk_module_node.h</li>
<li>duk_module_node.c</li>
</ul>
<p dir="auto">updated:</p>
<ul dir="auto">
<li>app_jsdt_api.h</li>
<li>app_jsdt_api.c</li>
</ul>
<p dir="auto">Included the extra header and initialize the bindings after 'load JS context' was created.</p>
<p dir="auto">added <code>cb_resolve_module</code> to resolve the full file system path for requested_id and parent_id<br>
added <code>cb_load_module</code> function which uses <code>jsdt_load_file</code> to load resolved file</p>
<p dir="auto">With absolute and relative modules working I met my current requirements to allow breaking routing into multiple smaller files.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/3038'>https://github.com/kamailio/kamailio/pull/3038</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/3038/commits/e5adee1742a0e06d955e78a943108cae9b2e7f0e" class="commit-link">e5adee1</a> app_jsdt: add duk_module_node for JS module resolution</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/kamailio/kamailio/pull/3038/files">4 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3038/files#diff-0e2f93e349fc8d59eae59328e1782bbd742fb7ed362b93239a4bde1fc74a9c33">src/modules/app_jsdt/app_jsdt_api.c</a>
(65)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3038/files#diff-0d862012619c9aada46a60fb856a9e19c3f6f3f523f8e44c3f52c5b15ca874dd">src/modules/app_jsdt/app_jsdt_api.h</a>
(3)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/3038/files#diff-a73bfec92e40ae6f8a5cec46869433917988fa092d4060ee860319175d0b9340">src/modules/app_jsdt/duk_module_node.c</a>
(333)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/3038/files#diff-723c7d910d9342e932422464334b679240df855c43009c8d0814f6771dea279b">src/modules/app_jsdt/duk_module_node.h</a>
(17)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/3038.patch'>https://github.com/kamailio/kamailio/pull/3038.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/3038.diff'>https://github.com/kamailio/kamailio/pull/3038.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3038">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZLKMAJE5KWBAXIFESTU4TJB5ANCNFSM5PEHYL5A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZPSUQBFH72E5KSAGNDU4TJB5A5CNFSM5PEHYL5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4RDNZDUQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3038</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3038",
"url": "https://github.com/kamailio/kamailio/pull/3038",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>