<p></p>
<p><b>@alexyosifov</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3029#discussion_r810663476">src/modules/ims_ipsec_pcscf/cmd.c</a>:</p>
<pre style='color:#555'>>      // Update contacts only for initial registration, for re-registration the existing contacts shouldn't be updated.
-    if(ci.via_port == SIP_PORT){
+    if(ci.via_port == SIP_PORT && req_sec_params == NULL){
</pre>
<p dir="auto"><strong>ipsec_create()</strong> should be invoked exactly before 401 reply. From my practice in received REGISTER on 5060 there is always <strong>sec-agree</strong> header and this <strong>if</strong> block will never been TRUE.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3029#pullrequestreview-888068815">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZL46E2OEY5AXJJWVF3U4EVAPANCNFSM5OR36KPA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZOPLSNRJUBOYMWC7RLU4EVAPA5CNFSM5OR36KPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGTXNVTY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3029/review/888068815</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3029#pullrequestreview-888068815",
"url": "https://github.com/kamailio/kamailio/pull/3029#pullrequestreview-888068815",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>