<h4 dir="auto">Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4 dir="auto">Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4 dir="auto">Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="495622607" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2069" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2069/hovercard" href="https://github.com/kamailio/kamailio/issues/2069">#2069</a></li>
</ul>
<h4 dir="auto">Description</h4>
<p dir="auto">The Erlang module is not working at all with newer Kamailio versions. One of the issues was already found in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="495622607" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2069" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2069/hovercard" href="https://github.com/kamailio/kamailio/issues/2069">#2069</a> but no code was submitted. The second one I believe is related to <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c641edd69993/hovercard" href="https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c641edd69993"><tt>7bb2669</tt></a> in that the erlang module assumes that pvi.type is zero and uses that field to type the custom fields it manages and this commit starts populating pvi.type with a 4.</p>
<p dir="auto">I don't have a solid grasp on pvapi.c so if the experts have a better way to fix this up I am all ears. These two commits do get the module working properly and I am able to use both the custom erlang PV terms and the RPC feature from my proxy now.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/3024'>https://github.com/kamailio/kamailio/pull/3024</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/3024/commits/4073c8b3523f9af46d547dcb00488d588c34e276" class="commit-link">4073c8b</a> Erlang: Erlang module assumes pvi.type is zero</li>
<li><a href="https://github.com/kamailio/kamailio/pull/3024/commits/7c8824566defb64a35e228a05d0c91a019afdae5" class="commit-link">7c88245</a> Erlang: Revert breaking change</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/kamailio/kamailio/pull/3024/files">4 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3024/files#diff-2fb23a5c61dcc4b851e84aad095cbbc9548851676a6770e65709dc4d04703486">src/modules/erlang/pv_atom.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3024/files#diff-9e54ee458ea6a05fbcde4f95d18b8d28d4b842244f53e143a575b039b6dac4e3">src/modules/erlang/pv_pid.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3024/files#diff-a869302b290631ec84f3e42a49cc6677ac31eac1d917dee1683f02158d5d34c5">src/modules/erlang/pv_ref.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3024/files#diff-b089d851d0cb607fcb8f9554465f66ebffbf2617046c6f3c0823845a2c418711">src/modules/erlang/pv_xbuff.c</a>
(13)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/3024.patch'>https://github.com/kamailio/kamailio/pull/3024.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/3024.diff'>https://github.com/kamailio/kamailio/pull/3024.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3024">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZPZMR67KY3YULWK4LDU24CSBANCNFSM5OH5NWNA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZPP74Y65KJEYHCIMITU24CSBA5CNFSM5OH5NWNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4Q5F2WJQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3024</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3024",
"url": "https://github.com/kamailio/kamailio/pull/3024",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>