<p></p>
<p><b>@lnicola</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3003#discussion_r784865860">src/modules/presence_xml/add_events.c</a>:</p>
<pre style='color:#555'>> @@ -49,6 +51,15 @@ int xml_add_events(void)
 {
        pres_ev_t event;
 
+       /* read default expires from presence, if exists */
+       int pres_default_expires = 3600;
+       modparam_t type = 0;
+       int *param = find_param_export(find_module_by_name("presence"), "default_expires", INT_PARAM, &type);
+       if ( param && (type == INT_PARAM) ) 
</pre>
⬇️ Suggested change
<pre style="color: #555">-      if ( param && (type == INT_PARAM) ) 
+       if(param && type == INT_PARAM) 
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3003#pullrequestreview-852948125">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZNOMSGHVICZFUHVJILUWAUHLANCNFSM5L62RGHA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZNEUKP7UC3KI6CT2HLUWAUHLA5CNFSM5L62RGHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGLLPJHI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3003/review/852948125</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3003#pullrequestreview-852948125",
"url": "https://github.com/kamailio/kamailio/pull/3003#pullrequestreview-852948125",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>