<p></p>
<p dir="auto">In the method <code>acquire_spi</code>, the condition of acquiring and releasing is not aligned. It seems the lock would be acquired but released only when <code>spi_data->spi_val == initial_val</code>, Would it lead to missing lock release?<br>
<a href="https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fcaddfe19/src/modules/ims_ipsec_pcscf/spi_gen.c#L83-L85">https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fcaddfe19/src/modules/ims_ipsec_pcscf/spi_gen.c#L83-L85</a><br>
<a href="https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fcaddfe19/src/modules/ims_ipsec_pcscf/spi_gen.c#L109-L111">https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fcaddfe19/src/modules/ims_ipsec_pcscf/spi_gen.c#L109-L111</a></p>
<p dir="auto">In the method <code>release_spi</code>, the lock may be re-acquired so missing lock release in the method <code>acquire_spi</code> could lead to a deadlock.<br>
<a href="https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fcaddfe19/src/modules/ims_ipsec_pcscf/spi_gen.c#L126-L134">https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fcaddfe19/src/modules/ims_ipsec_pcscf/spi_gen.c#L126-L134</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/2939">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMAQ7TANE47ZPKZ23TUMSFSVANCNFSM5IIXDZTA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABO7UZOJ37DMWDXXBSHPEVTUMSFSVA5CNFSM5IIXDZTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4PX74XZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/issues/2939",
"url": "https://github.com/kamailio/kamailio/issues/2939",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>