<p></p>
> Thanks for the pull request. Just inventing a new patch category is<br>
> not the right approach, sorry.<br>
><br>
> Please just use "core" for the core part and the other module parts as<br>
> individual commits per module with the respective module name as<br>
> prefix.<br>
<br>
<br>
No problem, will do.<br>
<br>
> One small question, why do you add this additional quotes and space<br>
> around the TIME_T_INT_FMT #define?<br>
<br>
You mean this, right?<br>
<br>
LM_DBG("converting datetime value %" TIME_T_INT_FMT " to str\n", VAL_TIME(v));<br>
<br>
Below wouldn't work:<br>
LM_DBG("converting datetime value %TIME_T_INT_FMT to str\n", VAL_TIME(v));<br>
<br>
Or maybe I didn't understand your question?<br>
<br>
Kind regards,<br>
Seb<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2894#issuecomment-949915253">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZJ6OVTJBUDTMIV37U3UIG5GLANCNFSM5GRDMKEA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABO7UZOHOPHQ77SLUMTNOMTUIG5GLA5CNFSM5GRDMKEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHCPI45I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2894#issuecomment-949915253",
"url": "https://github.com/kamailio/kamailio/pull/2894#issuecomment-949915253",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>